Skip to content

[Synapse] adding parameters for dataflow activity#16577

Closed
bannama wants to merge 19 commits intoAzure:masterfrom
bannama:bhaskara/dataflowParametersForSynapse
Closed

[Synapse] adding parameters for dataflow activity#16577
bannama wants to merge 19 commits intoAzure:masterfrom
bannama:bhaskara/dataflowParametersForSynapse

Conversation

@bannama
Copy link
Contributor

@bannama bannama commented Oct 28, 2021

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. If updating an existing version, please select the specific langauge SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that label “WaitForARMFeedback” will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.

  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

sashahdo and others added 3 commits October 27, 2021 08:30
@sashahdo
[Hub Generated] Review request for Microsoft.Consumption to add versi…
6515578 
…on stable/2019-10-01 (Azure#16503)

* Lowered minItems to 0 to match API implementation

* Added missing ThresholdType value.
@CaihuaRui
Review request for Microsoft.AppPlatform to add a new field container…
3a96589 
…ProbeSettings to DeploymentSettings in version 2021-09-01-preview (Azure#16545)
@msyyc
Update CODEOWNERS (Azure#16562)
f6a8a2e
@openapi-workflow-bot
Copy link

openapi-workflow-bot bot commented Oct 28, 2021

Hi, @bannama Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-workflow-bot
    Copy link

    openapi-workflow-bot bot commented Oct 28, 2021

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Oct 28, 2021 •
    edited
    Loading

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand] 
    There are no breaking changes.

    ️🔄LintDiff inProgress [Detail]
    ️⚠️Avocado: 1 Warnings warning [Detail]
    Rule Message
    ⚠️ MULTIPLE_API_VERSION The default tag contains multiple API versions swaggers.
    readme: specification/compute/resource-manager/readme.md
    tag: specification/compute/resource-manager/readme.md#tag-package-2021-07-01
    ️️✔️ModelValidation succeeded [Detail] [Expand] 
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand] 
    Validation passes for SemanticValidation.
    ️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand] 
    There is no credential detected.
    ️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand] 
    Validation passes for SDKTrack2Validation

    ️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand] 
    Validation passes for PrettierCheck.
    ️️✔️[Staging] SpellCheck succeeded [Detail] [Expand] 
    Validation passes for SpellCheck.
    ️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand] 
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @ghost ghost added the Synapses label Oct 28, 2021
    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Oct 28, 2021 •
    edited
    Loading

    Swagger Generation Artifacts

    ️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]

    Only 0 items are rendered, please refer to log for more details.

    ️❌[Staging] SDK Breaking Change Tracking failed [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️️✔️ azure-powershell succeeded [Detail] [Expand]

    Only 0 items are rendered, please refer to log for more details.

    ️⚠️ azure-sdk-for-python-track2 warning [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️⚠️ azure-sdk-for-java warning [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️❌ azure-sdk-for-net failed [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

    Only 0 items are rendered, please refer to log for more details.

    ️🔄 azure-sdk-for-go inProgress [Detail]
    ️❌ azure-sdk-for-go-track2 failed [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️❌ azure-resource-manager-schemas failed [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️⚠️ azure-sdk-for-python warning [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]

    Only 0 items are rendered, please refer to log for more details.

    Posted by Swagger Pipeline | How to fix these errors?

    @sukodava @markcowl
    Remove Provisioning Details from RestorePoint (Azure#16099)
    94afa34 
    * Add blockchain to latest profile

* Add additional types

* Remove Provisioning Details from RestorePoint

* Fix prettier

* JSON format

* fix

* Change 'timeCreated'

Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com>
    robga and others added 4 commits October 28, 2021 09:54
    @robga
    Revert "Robga/policy (Azure#16255)" (Azure#16537)
    d5ccfc1 
    This reverts commit 780a637.
    @msyyc
    Guidance and rules for release request (Azure#16561)
    c24ee32 
    * 0.1.0

* update

* format
    @Alancere
    add batch tag (Azure#16578)
    91a3a54
    @BigCat20196 @msyyc
    config desktopvirtualization readme and readme python (Azure#16579)
    2b56c8a 
    * config readme

* Update readme.python.md

Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>
    @wonner
    Copy link
    Contributor

    wonner commented Oct 28, 2021

    Hi @bannama , you can directly edit file under folder 2020-12-01. 2019-06-01-preview is a pretty old API version. We won’t use that API version to build Synapse SDK.

    tombuildsstuff and others added 4 commits October 28, 2021 17:03
    @tombuildsstuff
    marketplacenotifications: fixing an invalid operation id (Azure#16326)
    da8f07c 
    Since both of these share the same operation id - neither is currently valid / can work
as such this fixes these to use the canonical name (List and Get) based on the convention
    @rokulka @heaths
    [QuestionAnswering] Move stable version from feature branch to main (A…
    6d7653f 
    …zure#16510)

* move stable to main

* fix validation failures

* update operationIds

* update model names

* Rename properties with x-ms-client-name

* Properly declare ShortAnswerOptions.enable as constant true

After Azure/autorest#4184, modelAsString: false
must be added

* Fix linting error

Co-authored-by: Heath Stewart <heaths@microsoft.com>
    @parvsaxena
    Add new version for scanning 2021-10-01-preview (for dns change) (Azu…
    c599abd 
    …re#16447)

* add new version for dns change

* address check failures

* fix readme path

Co-authored-by: Parv Saxena <pasaxena@microsoft.com>
    @heaths
    Resolve archboard feedback for Question Answering (Azure#16589)
    34a2c07
    @bannama bannama force-pushed the bhaskara/dataflowParametersForSynapse branch from 5fecd9b to 6d102b2 Compare October 28, 2021 19:54
    @bannama
    Copy link
    Contributor Author

    bannama commented Oct 28, 2021

    @wonner updated the file under the 2020-12-01 version. please review

    @wonner
    Copy link
    Contributor

    wonner commented Oct 28, 2021 •
    edited
    Loading

    Hi @bannama ,you should send PR to main branch but not master. I can’t just change the “base” of the PR to main branch since it will bring other commit. Could you please sync to main branch? Thanks.

    Daniel Stack and others added 3 commits October 29, 2021 09:04
    Dev maps microsoft.maps 2021 12 01 preview (Azure#16153)
    50d599c 
    * Adds base for updating Microsoft.Maps from version preview/2021-07-01-preview to version 2021-12-01-preview

* Updates readme

* Updates API version in new specs and examples

* CORS and AccountSas

* fix examples

* fixing

* fix example

* fixing example

* fix convention and systemdata

* creator examples

* fix by rule supress

* content updates

* fixes from specs pipeline
    @uratzmon @markcowl @msyyc
    Feature/uratzmon/2021 10 27 preview (Azure#16566)
    330702f 
    * Add blockchain to latest profile

* Add additional types

* copy paste the last version

* replace the version string where necessary

* add examples files

* add new APIs

* fix checks Azure#1

* Update specification/vi/resource-manager/readme.md

* delete unnecessary part

Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com>
Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>
    @a-santamaria
    Service Fabric managed clusters api version 2021-11-01-preview (Azure…
    69eacf0 
    …#16424)

* initial comming copy from 2021-09-01-privatepreview

* update swagger to version 2021-11-01-preview

* update examples

* adding serviceEndpoints

* fix node type update tags

* run prettier

* remove api version enum as recommended not to get flagged on cros version breaking changes

Co-authored-by: Alfredo Santamaria Gomez <alsantam@microsoft.com>
    @wonner wonner changed the base branch from master to main October 29, 2021 04:57
    This was referenced Oct 29, 2021
    Draft
    Draft
    Draft
    Draft
    Draft
    Draft
    Draft
    Draft
    Draft
    Draft
    Draft
    Draft
    Draft
    This was referenced Oct 29, 2021
    Draft
    Draft
    Draft
    Draft
    Draft
    Draft
    Draft
    Draft
    Draft
    Draft
    Draft
    Draft
    Draft
    Draft
    Draft
    Draft
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Reviewers

    @idear1203 idear1203 Awaiting requested review from idear1203

    @wonner wonner Awaiting requested review from wonner

    @00Kai0 00Kai0 Awaiting requested review from 00Kai0

    @ArcturusZhang ArcturusZhang Awaiting requested review from ArcturusZhang

    @dkulkarni-ms dkulkarni-ms Awaiting requested review from dkulkarni-ms dkulkarni-ms is a code owner

    @grizzlytheodore grizzlytheodore Awaiting requested review from grizzlytheodore

    @haagha haagha Awaiting requested review from haagha haagha is a code owner

    @hyonholee hyonholee Awaiting requested review from hyonholee

    @jsntcy jsntcy Awaiting requested review from jsntcy

    @kjeur kjeur Awaiting requested review from kjeur kjeur is a code owner

    @madewithsmiles madewithsmiles Awaiting requested review from madewithsmiles

    @MS-syh2qs MS-syh2qs Awaiting requested review from MS-syh2qs MS-syh2qs is a code owner

    @msyyc msyyc Awaiting requested review from msyyc msyyc is a code owner

    @RAY-316 RAY-316 Awaiting requested review from RAY-316

    @Sandido Sandido Awaiting requested review from Sandido

    @yangyuan yangyuan Awaiting requested review from yangyuan

    1 more reviewer

    @jackmagic313 jackmagic313 jackmagic313 approved these changes

    Reviewers whose approvals may not affect merge requirements

    Assignees

    @lmazuel lmazuel

    Labels

    Synapses

    Projects

    None yet

    Milestone

    No milestone

    Development

    Successfully merging this pull request may close these issues.