Skip to content

add the list and cancel database operations#1635

Merged
dsgouda merged 1 commit intoAzure:currentfrom
jiawang003:current
Sep 12, 2017
Merged

add the list and cancel database operations#1635
dsgouda merged 1 commit intoAzure:currentfrom
jiawang003:current

Conversation

@jiawang003
Copy link
Copy Markdown
Contributor

@jiawang003 jiawang003 commented Sep 5, 2017 •
edited by azuresdkci
Loading

request to add the new list and cancel database operations under 2017-03-01-preview, run autorest validation without issue

@msftclas
Copy link
Copy Markdown

msftclas commented Sep 5, 2017

@jiawang003,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@azuresdkciprbot
Copy link
Copy Markdown

azuresdkciprbot commented Sep 5, 2017

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/sql/resource-manager/readme.md
Before the PR: Warning(s): 4 Error(s): 0
After the PR: Warning(s): 4 Error(s): 0

AutoRest Linter Guidelines | AutoRest Linter Issues

Send feedback and make AutoRest Linter Azure Bot smarter day by day!

Thanks for your co-operation.

@ravbhatnagar
Copy link
Copy Markdown
Contributor

ravbhatnagar commented Sep 8, 2017

Looks fine. Just one thing - Do you need an API to get a single operation - /operations/operationid as well?

@ravbhatnagar
Copy link
Copy Markdown
Contributor

ravbhatnagar commented Sep 8, 2017

@jiawang003 @jaredmoo FYI on above comment. Else looks good.

@jiawang003
Copy link
Copy Markdown
Contributor Author

jiawang003 commented Sep 8, 2017

customer need to find OperationId first. no need for now

@ravbhatnagar
Copy link
Copy Markdown
Contributor

ravbhatnagar commented Sep 8, 2017

Ok, just wanted to bring to your notice in case you missed. Looks good. ARM sign off.

@ravbhatnagar ravbhatnagar added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Sep 8, 2017
@dsgouda dsgouda merged commit b3f4823 into Azure:current Sep 12, 2017
@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Sep 12, 2017

No modification for AutorestCI/azure-sdk-for-node

@AutorestCI AutorestCI mentioned this pull request Sep 12, 2017
Merged
@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Sep 12, 2017

Build Status Azure/azure-sdk-for-ruby#971

@AutorestCI AutorestCI mentioned this pull request Sep 12, 2017
Closed
@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Sep 12, 2017

Build Status Azure/azure-sdk-for-python#1435

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ravbhatnagar ravbhatnagar Awaiting requested review from ravbhatnagar

2 more reviewers

@jianghaolu jianghaolu jianghaolu approved these changes

@jaredmoo jaredmoo jaredmoo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jianghaolu jianghaolu

@ravbhatnagar ravbhatnagar

Labels

ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@jiawang003 @msftclas @azuresdkciprbot @ravbhatnagar @AutorestCI @jianghaolu @jaredmoo @dsgouda