Skip to content

Adding missing Operations API to the Microsoft.Media Swagger#1628

Merged
sarangan12 merged 3 commits intoAzure:currentfrom
jonpayne:current
Sep 12, 2017
Merged

Adding missing Operations API to the Microsoft.Media Swagger#1628
sarangan12 merged 3 commits intoAzure:currentfrom
jonpayne:current

Conversation

@jonpayne
Copy link
Copy Markdown
Member

@jonpayne jonpayne commented Sep 1, 2017 •
edited by azuresdkci
Loading

  • Adding /providers/Microsoft.Media/operations that was previously missing
    from the Swagger file.

  • Adding and updating various descriptions.

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@jonpayne
Formatting updates to Microsoft.Media Swagger
2aef11b 
- Adding /providers/Microsoft.Media/operations that was previously missing
from the Swagger file.

- Adding and updating various descriptions.
@msftclas
Copy link
Copy Markdown

msftclas commented Sep 1, 2017

@jonpayne,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@sarangan12
Copy link
Copy Markdown
Contributor

sarangan12 commented Sep 1, 2017

Please take a look at these errors and try fixing them and update the PR:

  1. https://travis-ci.org/Azure/azure-rest-api-specs/jobs/270870509#L674 &&
  2. https://travis-ci.org/Azure/azure-rest-api-specs/jobs/270870507

@sarangan12
Copy link
Copy Markdown
Contributor

sarangan12 commented Sep 5, 2017

@jonpayne

Please let me know if the issues are fixed.

@sarangan12
Copy link
Copy Markdown
Contributor

sarangan12 commented Sep 7, 2017

@jonpayne

Please fix the issues and update the PR

@azuresdkciprbot
Copy link
Copy Markdown

azuresdkciprbot commented Sep 9, 2017

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/mediaservices/resource-manager/readme.md
Before the PR: Warning(s): 13 Error(s): 13
After the PR: Warning(s): 11 Error(s): 0

AutoRest Linter Guidelines | AutoRest Linter Issues

Send feedback and make AutoRest Linter Azure Bot smarter day by day!

Thanks for your co-operation.

sarangan12
sarangan12 suggested changes Sep 11, 2017
View reviewed changes
specification/mediaservices/resource-manager/Microsoft.Media/2015-10-01/media.json
@@ -85,13 +94,9 @@
},
"examples": {
Copy link
Copy Markdown
Contributor

@sarangan12 sarangan12 Sep 11, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is causing error in https://travis-ci.org/Azure/azure-rest-api-specs/jobs/273496691. Please fix it

@azuresdkciprbot
Copy link
Copy Markdown

azuresdkciprbot commented Sep 11, 2017

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/mediaservices/resource-manager/readme.md
Before the PR: Warning(s): 13 Error(s): 13
After the PR: Warning(s): 11 Error(s): 0

AutoRest Linter Guidelines | AutoRest Linter Issues

Send feedback and make AutoRest Linter Azure Bot smarter day by day!

Thanks for your co-operation.

@sarangan12 sarangan12 merged commit b88ba52 into Azure:current Sep 12, 2017
@AutorestCI AutorestCI mentioned this pull request Sep 12, 2017
Merged
@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Sep 12, 2017

Build Status Azure/azure-sdk-for-python#1437

@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Sep 12, 2017

No modification for AutorestCI/azure-sdk-for-node

1 similar comment
@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Sep 12, 2017

No modification for AutorestCI/azure-sdk-for-node

@AutorestCI AutorestCI mentioned this pull request Sep 12, 2017
Merged
@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Sep 12, 2017

Build Status Azure/azure-sdk-for-ruby#974

@lmazuel lmazuel mentioned this pull request Sep 12, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sarangan12 sarangan12 sarangan12 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@sarangan12 sarangan12

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jonpayne @msftclas @sarangan12 @azuresdkciprbot @AutorestCI