-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Supported Resource Types for hybrid profile AKS and ACR #16066
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Supported Resource Types for hybrid profile AKS and ACR #16066
Conversation
|
Hi, @Bhuvaneswari-Santharam Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Validation Report
|
|
Swagger pipeline restarted successfully, please wait for status update in this comment. |
|
@Bhuvaneswari-Santharam please clean up the commits |
1e593ba to
32bd874
Compare
|
@zhenglaizhang Could you please merge this PR? this is azurestack specific profile map, not a swagger spec. |
* Add blockchain to latest profile * Add additional types * Supported api for AKS and ACR Revert "Add additional types" This reverts commit 7b46097. Revert "Add blockchain to latest profile" This reverts commit 1bcc20d. Adding supported apis for ACR and AKS Revert "Add blockchain to latest profile" This reverts commit 1bcc20d. Adding supported apis for ACR and AKS Co-authored-by: Mark Cowlishaw <[email protected]> Co-authored-by: Bhuvaneswari Santharam <[email protected]>
* Add blockchain to latest profile * Add additional types * Supported api for AKS and ACR Revert "Add additional types" This reverts commit 7b46097. Revert "Add blockchain to latest profile" This reverts commit 1bcc20d. Adding supported apis for ACR and AKS Revert "Add blockchain to latest profile" This reverts commit 1bcc20d. Adding supported apis for ACR and AKS Co-authored-by: Mark Cowlishaw <[email protected]> Co-authored-by: Bhuvaneswari Santharam <[email protected]>
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label “WaitForARMFeedback” will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.