Add 2015-05-01 capabilities swagger by gaagra · Pull Request #1600 · Azure/azure-rest-api-specs

gaagra · 2017-08-29T02:57:21Z

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

Microsoft Contribution License Agreements (msftclas) · 2017-08-29T02:57:25Z

@gaagra,
Thanks for your contribution.
To ensure that the project team has proper rights to use your work, please complete the Contribution License Agreement at https://cla.microsoft.com.

It will cover your contributions to all Microsoft-managed open source projects.
Thanks,
Microsoft Pull Request Bot

Azure PR Bot (azuresdkciprbot) · 2017-08-29T03:08:47Z

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/sql/resource-manager/readme.md
Before the PR: Warning(s): 4 Error(s): 0
After the PR: Warning(s): 3 Error(s): 0

AutoRest Linter Guidelines | AutoRest Linter Issues

Send feedback and make AutoRest Linter Azure Bot smarter day by day!

Thanks for your co-operation.

Anu Thomas (anuchandy) · 2017-08-29T19:18:13Z

continuous-integration/travis-ci/pr The Travis CI build failed

gaagra please fix the linter, sematic and model validations -

https://travis-ci.org/Azure/azure-rest-api-specs/jobs/269428059
https://travis-ci.org/Azure/azure-rest-api-specs/jobs/269428060
https://travis-ci.org/Azure/azure-rest-api-specs/jobs/269428061

Anu Thomas (anuchandy) · 2017-08-29T19:49:48Z

This is a new swagger targeting API version 2015-05-01 so adding WaitForARMFeedBack label.

Anu Thomas (anuchandy)

Please fix the CI failures as pointed. Also provide examples for capabilities operations.

Anu Thomas (anuchandy) · 2017-08-30T17:53:32Z

gaagra it looks like swagger reference examples which does not exist.

You can repro this locally by running:

autorest --validation --azure-validator --message-format=json --input-file=./specification/sql/resource-manager/Microsoft.Sql/2015-05-01/capabilities.json

oav validate-spec ./specification/sql/resource-manager/Microsoft.Sql/2015-05-01/capabilities.json
oav validate-example ./specification/sql/resource-manager/Microsoft.Sql/2015-05-01/capabilities.json

Azure PR Bot (azuresdkciprbot) · 2017-09-01T00:38:00Z

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/sql/resource-manager/readme.md
Before the PR: Warning(s): 4 Error(s): 0
After the PR: Warning(s): 4 Error(s): 0

AutoRest Linter Guidelines | AutoRest Linter Issues

Send feedback and make AutoRest Linter Azure Bot smarter day by day!

Thanks for your co-operation.

Anu Thomas (anuchandy) · 2017-09-01T05:20:34Z

Gaurav Bhatnagar (@ravbhatnagar) please sign-off.

Anu Thomas (anuchandy)

looks good from SDK side.

Anu Thomas (anuchandy) · 2017-09-01T05:16:24Z

+            "modelAsString": false
+          }
+        },
+        "reason": {


Does service populate reason field only if status has a value other than Available (i.e. Visible, Default , Disabled )?

yes, that's correct

Jared Moore (jaredmoo) · 2017-09-01T22:47:39Z

 - Microsoft.Sql/2014-04-01/sql.core.json
 - Microsoft.Sql/2014-04-01/usages.json
 - Microsoft.Sql/2015-05-01-preview/blobAuditingPolicies.json
+- Microsoft.Sql/2015-05-01/capabilities.json


please add 2015-05-01-preview capabilities and use that one here.

Gaurav Bhatnagar (ravbhatnagar) · 2017-09-12T01:11:44Z

Signed off!

Samer Alameer (salameer) · 2017-09-15T23:17:05Z

Anu Thomas (@anuchandy)

its seems to me that this is ready for merging right :)

Azure SDK Bot (AutorestCI) · 2017-09-18T20:12:34Z

No modification for AutorestCI/azure-sdk-for-node

Azure SDK Bot (AutorestCI) · 2017-09-18T20:13:03Z

Azure/azure-sdk-for-python#1449

Azure SDK Bot (AutorestCI) · 2017-09-18T20:13:35Z

Azure/azure-sdk-for-ruby#981

Publish footprintMonitoring/preview/2020-02-01-preview SDK generation markdowns.

Add 2015-05-01 capabilities swagger

95fe8af

Microsoft Contribution License Agreements (msftclas) added the cla-required label Aug 29, 2017

Azure Builder (azuresdkci) assigned Anu Thomas (anuchandy) Aug 29, 2017

Anu Thomas (anuchandy) added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 29, 2017

Anu Thomas (anuchandy) requested changes Aug 29, 2017

View reviewed changes

update swagger and add examples file

b6fc6c2

Anu Thomas (anuchandy) approved these changes Sep 1, 2017

View reviewed changes

Jared Moore (jaredmoo) reviewed Sep 1, 2017

View reviewed changes

Gaurav Bhatnagar (ravbhatnagar) added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Sep 12, 2017

Anu Thomas (anuchandy) merged commit 26998d2 into Azure:current Sep 18, 2017

Azure SDK Bot (AutorestCI) mentioned this pull request Sep 18, 2017

[MgmtSQL] Add 2015-05-01 capabilities swagger Azure/azure-sdk-for-python#1449

Closed

Azure SDK Bot (AutorestCI) mentioned this pull request Sep 18, 2017

Automatic PR from RestAPI-PR1600 Azure/azure-sdk-for-ruby#981

Merged

Paul McClean (mccleanp) pushed a commit that referenced this pull request Mar 23, 2022

Merge pull request #1600 from jonunezd/addFPMonitoring20200615

2c2f40f

Publish footprintMonitoring/preview/2020-02-01-preview SDK generation markdowns.

Uh oh!

Conversation

gaagra commented Aug 29, 2017 • edited by azuresdkci Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR information

Quality of Swagger

Uh oh!

Microsoft Contribution License Agreements (msftclas) commented Aug 29, 2017

Uh oh!

Azure PR Bot (azuresdkciprbot) commented Aug 29, 2017

Uh oh!

Anu Thomas (anuchandy) commented Aug 29, 2017

Uh oh!

Anu Thomas (anuchandy) commented Aug 29, 2017

Uh oh!

Anu Thomas (anuchandy) left a comment

Choose a reason for hiding this comment

Uh oh!

Anu Thomas (anuchandy) commented Aug 30, 2017

Uh oh!

Azure PR Bot (azuresdkciprbot) commented Sep 1, 2017

Uh oh!

Anu Thomas (anuchandy) commented Sep 1, 2017

Uh oh!

Anu Thomas (anuchandy) left a comment

Choose a reason for hiding this comment

Uh oh!

Anu Thomas (anuchandy) Sep 1, 2017

Choose a reason for hiding this comment

Uh oh!

gaagra Sep 1, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Jared Moore (jaredmoo) Sep 1, 2017

Choose a reason for hiding this comment

Uh oh!

Gaurav Bhatnagar (ravbhatnagar) commented Sep 12, 2017

Uh oh!

Samer Alameer (salameer) commented Sep 15, 2017

Uh oh!

Azure SDK Bot (AutorestCI) commented Sep 18, 2017

Uh oh!

Azure SDK Bot (AutorestCI) commented Sep 18, 2017

Uh oh!

Azure SDK Bot (AutorestCI) commented Sep 18, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

gaagra commented Aug 29, 2017 •

edited by azuresdkci

Loading

gaagra Sep 1, 2017 •

edited

Loading