Guest Configuration S360 Swagger fixes #15988

aashish1987 · 2021-09-09T22:30:44Z

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- [X ] update existing version to fix swagger quality issue in s360
- Other, please clarify
When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month. - NA
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month. - September 2021
If updating an existing version, please select the specific langauge SDKs and CLIs that must be refreshed after the swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No refresh required for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs

Adding new properties

All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

Check this box if any of the following apply to the PR so that label “WaitForARMFeedback” will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
- Adding a new service
- Adding new API(s)
- Adding a new API version
  -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

Removing API(s) in a stable version
Removing properties in a stable version
Removing API version(s) in a stable version
Updating API in a stable or public preview version with Breaking Change Validation errors
Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

openapi-workflow-bot · 2021-09-09T22:30:46Z

Hi, @aashish1987 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

openapi-workflow-bot · 2021-09-09T22:30:47Z

[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

openapi-pipeline-app · 2021-09-09T22:30:49Z

Swagger Validation Report

️❌BreakingChange: 20 Errors, 0 Warnings failed [Detail]

Compared Swaggers (Based on Oad v0.9.0)
- current:stable/2018-11-20/guestconfiguration.json compared with base:stable/2018-11-20/guestconfiguration.json
- current:stable/2020-06-25/guestconfiguration.json compared with base:stable/2020-06-25/guestconfiguration.json
- current:stable/2021-01-25/guestconfiguration.json compared with base:stable/2021-01-25/guestconfiguration.json

Rule	Message
`❌` 1038 - AddedPath	The new version is adding a path that was not found in the old version. New: Microsoft.GuestConfiguration/stable/2018-11-20/guestconfiguration.json#L203:5
`❌` 1038 - AddedPath	The new version is adding a path that was not found in the old version. New: Microsoft.GuestConfiguration/stable/2018-11-20/guestconfiguration.json#L251:5
`❌` 1038 - AddedPath	The new version is adding a path that was not found in the old version. New: Microsoft.GuestConfiguration/stable/2020-06-25/guestconfiguration.json#L203:5
`❌` 1038 - AddedPath	The new version is adding a path that was not found in the old version. New: Microsoft.GuestConfiguration/stable/2020-06-25/guestconfiguration.json#L251:5
`❌` 1038 - AddedPath	The new version is adding a path that was not found in the old version. New: Microsoft.GuestConfiguration/stable/2021-01-25/guestconfiguration.json#L203:5
`❌` 1038 - AddedPath	The new version is adding a path that was not found in the old version. New: Microsoft.GuestConfiguration/stable/2021-01-25/guestconfiguration.json#L251:5
`❌` 1040 - AddedReadOnlyPropertyInResponse	The new version has a new read-only property 'vmssResourceId' in response that was not found in the old version. New: Microsoft.GuestConfiguration/stable/2018-11-20/guestconfiguration.json#L1128:7 Old: Microsoft.GuestConfiguration/stable/2018-11-20/guestconfiguration.json#L1002:7
`❌` 1040 - AddedReadOnlyPropertyInResponse	The new version has a new read-only property 'vmssResourceId' in response that was not found in the old version. New: Microsoft.GuestConfiguration/stable/2020-06-25/guestconfiguration.json#L1212:7 Old: Microsoft.GuestConfiguration/stable/2020-06-25/guestconfiguration.json#L1080:7
`❌` 1045 - AddedOptionalProperty	The new version has a new optional property 'contentType' that was not found in the old version. New: Microsoft.GuestConfiguration/stable/2018-11-20/guestconfiguration.json#L884:7 Old: Microsoft.GuestConfiguration/stable/2018-11-20/guestconfiguration.json#L785:7
`❌` 1045 - AddedOptionalProperty	The new version has a new optional property 'configurationProtectedParameter' that was not found in the old version. New: Microsoft.GuestConfiguration/stable/2018-11-20/guestconfiguration.json#L884:7 Old: Microsoft.GuestConfiguration/stable/2018-11-20/guestconfiguration.json#L785:7
`❌` 1045 - AddedOptionalProperty	The new version has a new optional property 'vmssVMList' that was not found in the old version. New: Microsoft.GuestConfiguration/stable/2018-11-20/guestconfiguration.json#L1021:7 Old: Microsoft.GuestConfiguration/stable/2018-11-20/guestconfiguration.json#L909:7
`❌` 1045 - AddedOptionalProperty	The new version has a new optional property 'parameterHash' that was not found in the old version. New: Microsoft.GuestConfiguration/stable/2018-11-20/guestconfiguration.json#L1021:7 Old: Microsoft.GuestConfiguration/stable/2018-11-20/guestconfiguration.json#L909:7
`❌` 1045 - AddedOptionalProperty	The new version has a new optional property 'contentType' that was not found in the old version. New: Microsoft.GuestConfiguration/stable/2020-06-25/guestconfiguration.json#L884:7 Old: Microsoft.GuestConfiguration/stable/2020-06-25/guestconfiguration.json#L785:7
`❌` 1045 - AddedOptionalProperty	The new version has a new optional property 'configurationProtectedParameter' that was not found in the old version. New: Microsoft.GuestConfiguration/stable/2020-06-25/guestconfiguration.json#L884:7 Old: Microsoft.GuestConfiguration/stable/2020-06-25/guestconfiguration.json#L785:7
`❌` 1045 - AddedOptionalProperty	The new version has a new optional property 'parameterHash' that was not found in the old version. New: Microsoft.GuestConfiguration/stable/2020-06-25/guestconfiguration.json#L1089:7 Old: Microsoft.GuestConfiguration/stable/2020-06-25/guestconfiguration.json#L977:7
`❌` 1045 - AddedOptionalProperty	The new version has a new optional property 'resourceType' that was not found in the old version. New: Microsoft.GuestConfiguration/stable/2020-06-25/guestconfiguration.json#L1089:7 Old: Microsoft.GuestConfiguration/stable/2020-06-25/guestconfiguration.json#L977:7
`❌` 1045 - AddedOptionalProperty	The new version has a new optional property 'vmssVMList' that was not found in the old version. New: Microsoft.GuestConfiguration/stable/2020-06-25/guestconfiguration.json#L1089:7 Old: Microsoft.GuestConfiguration/stable/2020-06-25/guestconfiguration.json#L977:7
`❌` 1045 - AddedOptionalProperty	The new version has a new optional property 'contentType' that was not found in the old version. New: Microsoft.GuestConfiguration/stable/2021-01-25/guestconfiguration.json#L1169:7 Old: Microsoft.GuestConfiguration/stable/2021-01-25/guestconfiguration.json#L1070:7
`❌` 1045 - AddedOptionalProperty	The new version has a new optional property 'configurationProtectedParameter' that was not found in the old version. New: Microsoft.GuestConfiguration/stable/2021-01-25/guestconfiguration.json#L1169:7 Old: Microsoft.GuestConfiguration/stable/2021-01-25/guestconfiguration.json#L1070:7
`❌` 1045 - AddedOptionalProperty	The new version has a new optional property 'parameterHash' that was not found in the old version. New: Microsoft.GuestConfiguration/stable/2021-01-25/guestconfiguration.json#L1374:7 Old: Microsoft.GuestConfiguration/stable/2021-01-25/guestconfiguration.json#L1262:7

️⚠️LintDiff: 12 Warnings warning [Detail]

Linted configuring files (Based on source branch, openapi-validator v1.10.1 , classic-openapi-validator v1.1.10 )
Linted configuring files (Based on target branch, openapi-validator v1.10.1 , classic-openapi-validator v1.1.10 )

The following errors/warnings are introduced by current PR:

Rule	Message
⚠️ R1003 - ListInOperationName	Since operation 'GuestConfigurationAssignments_SubscriptionList' response has model definition 'x-ms-pageable', it should be of the form '_list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.GuestConfiguration/stable/2018-11-20/guestconfiguration.json#L208
⚠️ R1003 - ListInOperationName	Since operation 'GuestConfigurationAssignments_RGList' response has model definition 'x-ms-pageable', it should be of the form '_list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.GuestConfiguration/stable/2018-11-20/guestconfiguration.json#L256
⚠️ R1003 - ListInOperationName	Since operation 'GuestConfigurationAssignments_SubscriptionList' response has model definition 'x-ms-pageable', it should be of the form '_list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.GuestConfiguration/stable/2020-06-25/guestconfiguration.json#L208
⚠️ R1003 - ListInOperationName	Since operation 'GuestConfigurationAssignments_RGList' response has model definition 'x-ms-pageable', it should be of the form '_list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.GuestConfiguration/stable/2020-06-25/guestconfiguration.json#L256
⚠️ R1003 - ListInOperationName	Since operation 'GuestConfigurationAssignments_SubscriptionList' response has model definition 'x-ms-pageable', it should be of the form '_list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.GuestConfiguration/stable/2021-01-25/guestconfiguration.json#L208
⚠️ R1003 - ListInOperationName	Since operation 'GuestConfigurationAssignments_RGList' response has model definition 'x-ms-pageable', it should be of the form '_list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.GuestConfiguration/stable/2021-01-25/guestconfiguration.json#L256
⚠️ R1005 - GetInOperationName	'GET' operation 'GuestConfigurationAssignments_SubscriptionList' should use method name 'Get' or Method name start with 'List'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.GuestConfiguration/stable/2018-11-20/guestconfiguration.json#L208
⚠️ R1005 - GetInOperationName	'GET' operation 'GuestConfigurationAssignments_RGList' should use method name 'Get' or Method name start with 'List'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.GuestConfiguration/stable/2018-11-20/guestconfiguration.json#L256
⚠️ R1005 - GetInOperationName	'GET' operation 'GuestConfigurationAssignments_SubscriptionList' should use method name 'Get' or Method name start with 'List'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.GuestConfiguration/stable/2020-06-25/guestconfiguration.json#L208
⚠️ R1005 - GetInOperationName	'GET' operation 'GuestConfigurationAssignments_RGList' should use method name 'Get' or Method name start with 'List'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.GuestConfiguration/stable/2020-06-25/guestconfiguration.json#L256
⚠️ R1005 - GetInOperationName	'GET' operation 'GuestConfigurationAssignments_SubscriptionList' should use method name 'Get' or Method name start with 'List'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.GuestConfiguration/stable/2021-01-25/guestconfiguration.json#L208
⚠️ R1005 - GetInOperationName	'GET' operation 'GuestConfigurationAssignments_RGList' should use method name 'Get' or Method name start with 'List'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.GuestConfiguration/stable/2021-01-25/guestconfiguration.json#L256

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule	Message
`❌` R2020 - RequiredPropertiesMissingInResourceModel	Model definition 'GuestConfigurationAssignment' must have the properties 'name', 'id' and 'type' in its hierarchy and these properties must be marked as readonly. Location: Microsoft.GuestConfiguration/stable/2020-06-25/guestconfiguration.json#L867
`❌` R2020 - RequiredPropertiesMissingInResourceModel	Model definition 'GuestConfigurationAssignment' must have the properties 'name', 'id' and 'type' in its hierarchy and these properties must be marked as readonly. Location: Microsoft.GuestConfiguration/stable/2021-01-25/guestconfiguration.json#L1146
`❌` R2020 - RequiredPropertiesMissingInResourceModel	Model definition 'GuestConfigurationAssignment' must have the properties 'name', 'id' and 'type' in its hierarchy and these properties must be marked as readonly. Location: Microsoft.GuestConfiguration/stable/2018-11-20/guestconfiguration.json#L867
`❌` R4009 - RequiredReadOnlySystemData	The response of operation:'GuestConfigurationAssignments_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.GuestConfiguration/stable/2020-06-25/guestconfiguration.json#L99
`❌` R4009 - RequiredReadOnlySystemData	The response of operation:'GuestConfigurationHCRPAssignments_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.GuestConfiguration/stable/2020-06-25/guestconfiguration.json#L539
`❌` R4009 - RequiredReadOnlySystemData	The response of operation:'GuestConfigurationAssignments_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.GuestConfiguration/stable/2020-06-25/guestconfiguration.json#L31
`❌` R4009 - RequiredReadOnlySystemData	The response of operation:'GuestConfigurationHCRPAssignments_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.GuestConfiguration/stable/2020-06-25/guestconfiguration.json#L471
`❌` R4011 - DeleteOperationResponses	The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.GuestConfiguration/stable/2020-06-25/guestconfiguration.json#L184
`❌` R4011 - DeleteOperationResponses	The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.GuestConfiguration/stable/2020-06-25/guestconfiguration.json#L624
`❌` R4011 - DeleteOperationResponses	The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.GuestConfiguration/stable/2021-01-25/guestconfiguration.json#L184
`❌` R4011 - DeleteOperationResponses	The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.GuestConfiguration/stable/2021-01-25/guestconfiguration.json#L624
`❌` R4011 - DeleteOperationResponses	The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.GuestConfiguration/stable/2018-11-20/guestconfiguration.json#L184
`❌` R4011 - DeleteOperationResponses	The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.GuestConfiguration/stable/2018-11-20/guestconfiguration.json#L624
`❌` R4018 - OperationsApiResponseSchema	The response schema of operations API '/providers/Microsoft.GuestConfiguration/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.GuestConfiguration/stable/2020-06-25/guestconfiguration.json#L811
`❌` R4018 - OperationsApiResponseSchema	The response schema of operations API '/providers/Microsoft.GuestConfiguration/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.GuestConfiguration/stable/2021-01-25/guestconfiguration.json#L1090
`❌` R4018 - OperationsApiResponseSchema	The response schema of operations API '/providers/Microsoft.GuestConfiguration/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.GuestConfiguration/stable/2018-11-20/guestconfiguration.json#L811
`❌` R4037 - MissingTypeObject	The schema 'GuestConfigurationAssignmentList' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.GuestConfiguration/stable/2020-06-25/guestconfiguration.json#L855
`❌` R4037 - MissingTypeObject	The schema 'GuestConfigurationAssignment' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.GuestConfiguration/stable/2020-06-25/guestconfiguration.json#L867
`❌` R4037 - MissingTypeObject	The schema 'GuestConfigurationNavigation' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.GuestConfiguration/stable/2020-06-25/guestconfiguration.json#L882
`❌` R4037 - MissingTypeObject	The schema 'ConfigurationParameter' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.GuestConfiguration/stable/2020-06-25/guestconfiguration.json#L952
`❌` R4037 - MissingTypeObject	The schema 'ConfigurationSetting' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.GuestConfiguration/stable/2020-06-25/guestconfiguration.json#L967
`❌` R4037 - MissingTypeObject	The schema 'AssignmentReport' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.GuestConfiguration/stable/2020-06-25/guestconfiguration.json#L1020
`❌` R4037 - MissingTypeObject	The schema 'GuestConfigurationAssignmentProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.GuestConfiguration/stable/2020-06-25/guestconfiguration.json#L1088
`❌` R4037 - MissingTypeObject	The schema 'GuestConfigurationAssignmentReportList' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.GuestConfiguration/stable/2020-06-25/guestconfiguration.json#L1180
`❌` R4037 - MissingTypeObject	The schema 'GuestConfigurationAssignmentReport' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.GuestConfiguration/stable/2020-06-25/guestconfiguration.json#L1192
`❌` R4037 - MissingTypeObject	The schema 'GuestConfigurationAssignmentReportProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.GuestConfiguration/stable/2020-06-25/guestconfiguration.json#L1211
`❌` R4037 - MissingTypeObject	The schema 'AssignmentInfo' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.GuestConfiguration/stable/2020-06-25/guestconfiguration.json#L1265
`❌` R4037 - MissingTypeObject	The schema 'VMInfo' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.GuestConfiguration/stable/2020-06-25/guestconfiguration.json#L1279
`❌` R4037 - MissingTypeObject	The schema 'ConfigurationInfo' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.GuestConfiguration/stable/2020-06-25/guestconfiguration.json#L1294
`❌` R4037 - MissingTypeObject	The schema 'AssignmentReportDetails' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.GuestConfiguration/stable/2020-06-25/guestconfiguration.json#L1309

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand]

Validation passes for SDKTrack2Validation

The following tags are being changed in this PR

️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2021-09-09T22:30:50Z

Swagger Generation Artifacts

️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️️✔️[Staging] SDK Breaking Change Tracking succeeded [Detail] [Expand]

Breaking Changes Tracking

️✔️azure-sdk-for-go - guestconfiguration/mgmt/2021-01-25/guestconfiguration - v57.2.0
️✔️azure-sdk-for-go - guestconfiguration/mgmt/2020-06-25/guestconfiguration - v57.2.0
️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-guestconfig - 1.0.0b1

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from ca93e24. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json

️✔️track2_azure-mgmt-guestconfig [View full logs] [Release SDK Changes]

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Model GuestConfigurationAssignmentProperties has a new parameter resource_type
info	[Changelog]   - Model GuestConfigurationAssignmentProperties has a new parameter vmss_vm_list
info	[Changelog]   - Model GuestConfigurationAssignmentProperties has a new parameter parameter_hash
info	[Changelog]   - Model GuestConfigurationAssignmentReportProperties has a new parameter vmss_resource_id
info	[Changelog]   - Model GuestConfigurationNavigation has a new parameter content_type
info	[Changelog]   - Model GuestConfigurationNavigation has a new parameter configuration_protected_parameter
info	[Changelog]   - Added operation GuestConfigurationAssignmentsOperations.subscription_list
info	[Changelog]   - Added operation GuestConfigurationAssignmentsOperations.rg_list

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from ca93e24. SDK Automation 14.0.0

command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️guestconfiguration/mgmt/2021-01-25/guestconfiguration [View full logs] [Release SDK Changes]

info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] ### New Content
info	[Changelog]
info	[Changelog] - New function `AssignmentsClient.SubscriptionListPreparer(context.Context) (*http.Request, error)`
info	[Changelog] - New function `AssignmentsClient.RGListSender(*http.Request) (*http.Response, error)`
info	[Changelog] - New function `AssignmentsClient.RGList(context.Context, string) (AssignmentList, error)`
info	[Changelog] - New function `AssignmentsClient.SubscriptionListSender(*http.Request) (*http.Response, error)`
info	[Changelog] - New function `Navigation.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `AssignmentsClient.RGListPreparer(context.Context, string) (*http.Request, error)`
info	[Changelog] - New function `AssignmentsClient.RGListResponder(*http.Response) (AssignmentList, error)`
info	[Changelog] - New function `AssignmentsClient.SubscriptionListResponder(*http.Response) (AssignmentList, error)`
info	[Changelog] - New function `AssignmentsClient.SubscriptionList(context.Context) (AssignmentList, error)`
info	[Changelog] - New field `ContentType` in struct `Navigation`
info	[Changelog] - New field `ConfigurationProtectedParameter` in struct `Navigation`
info	[Changelog] - New field `ParameterHash` in struct `AssignmentProperties`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 11 additive change(s).
info	[Changelog]

️✔️guestconfiguration/mgmt/2020-06-25/guestconfiguration [View full logs]

info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] ### New Content
info	[Changelog]
info	[Changelog] - New function `AssignmentsClient.SubscriptionListSender(*http.Request) (*http.Response, error)`
info	[Changelog] - New function `AssignmentsClient.RGList(context.Context, string) (AssignmentList, error)`
info	[Changelog] - New function `AssignmentsClient.SubscriptionListResponder(*http.Response) (AssignmentList, error)`
info	[Changelog] - New function `VMSSVMInfo.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `AssignmentsClient.SubscriptionList(context.Context) (AssignmentList, error)`
info	[Changelog] - New function `AssignmentsClient.RGListPreparer(context.Context, string) (*http.Request, error)`
info	[Changelog] - New function `AssignmentsClient.RGListSender(*http.Request) (*http.Response, error)`
info	[Changelog] - New function `Navigation.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `AssignmentsClient.SubscriptionListPreparer(context.Context) (*http.Request, error)`
info	[Changelog] - New function `AssignmentsClient.RGListResponder(*http.Response) (AssignmentList, error)`
info	[Changelog] - New struct `VMSSVMInfo`
info	[Changelog] - New field `ContentType` in struct `Navigation`
info	[Changelog] - New field `ConfigurationProtectedParameter` in struct `Navigation`
info	[Changelog] - New field `ParameterHash` in struct `AssignmentProperties`
info	[Changelog] - New field `ResourceType` in struct `AssignmentProperties`
info	[Changelog] - New field `VmssVMList` in struct `AssignmentProperties`
info	[Changelog] - New field `VmssResourceID` in struct `AssignmentReportProperties`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 15 additive change(s).
info	[Changelog]

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs]Release - Generate from ca93e24. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
cmderr	[generateScript.sh] (node:2413) UnhandledPromiseRejectionWarning: SyntaxError: Unexpected end of JSON input
cmderr	[generateScript.sh]     at JSON.parse (<anonymous>)
cmderr	[generateScript.sh]     at Object.readJsonFile (/home/vsts/work/1/s/azure-resource-manager-schemas/generator/utils.ts:174:17)
cmderr	[generateScript.sh]     at getCurrentTemplateRefs (/home/vsts/work/1/s/azure-resource-manager-schemas/generator/generate.ts:290:21)
cmderr	[generateScript.sh]     at /home/vsts/work/1/s/azure-resource-manager-schemas/generator/generate.ts:297:29
cmderr	[generateScript.sh] (Use `node --trace-warnings ...` to show where the warning was created)
cmderr	[generateScript.sh] (node:2413) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)
cmderr	[generateScript.sh] (node:2413) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
cmderr	[generateScript.sh] (node:2413) UnhandledPromiseRejectionWarning: SyntaxError: Unexpected end of JSON input
cmderr	[generateScript.sh]     at JSON.parse (<anonymous>)
cmderr	[generateScript.sh]     at Object.readJsonFile (/home/vsts/work/1/s/azure-resource-manager-schemas/generator/utils.ts:174:17)
cmderr	[generateScript.sh]     at getCurrentTemplateRefs (/home/vsts/work/1/s/azure-resource-manager-schemas/generator/generate.ts:290:21)
cmderr	[generateScript.sh]     at /home/vsts/work/1/s/azure-resource-manager-schemas/generator/generate.ts:297:29
cmderr	[generateScript.sh] (node:2413) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 2)
cmderr	[generateScript.sh] (node:2413) UnhandledPromiseRejectionWarning: SyntaxError: Unexpected end of JSON input
cmderr	[generateScript.sh]     at JSON.parse (<anonymous>)
cmderr	[generateScript.sh]     at Object.readJsonFile (/home/vsts/work/1/s/azure-resource-manager-schemas/generator/utils.ts:174:17)
cmderr	[generateScript.sh]     at getCurrentTemplateRefs (/home/vsts/work/1/s/azure-resource-manager-schemas/generator/generate.ts:290:21)
cmderr	[generateScript.sh]     at /home/vsts/work/1/s/azure-resource-manager-schemas/generator/generate.ts:297:29
cmderr	[generateScript.sh] (node:2413) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 3)
cmderr	[generateScript.sh] (node:2413) UnhandledPromiseRejectionWarning: SyntaxError: Unexpected end of JSON input
cmderr	[generateScript.sh]     at JSON.parse (<anonymous>)
cmderr	[generateScript.sh]     at Object.readJsonFile (/home/vsts/work/1/s/azure-resource-manager-schemas/generator/utils.ts:174:17)
cmderr	[generateScript.sh]     at getCurrentTemplateRefs (/home/vsts/work/1/s/azure-resource-manager-schemas/generator/generate.ts:290:21)
cmderr	[generateScript.sh]     at /home/vsts/work/1/s/azure-resource-manager-schemas/generator/generate.ts:297:29
cmderr	[generateScript.sh] (node:2413) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 4)
cmderr	[generateScript.sh] (node:2413) UnhandledPromiseRejectionWarning: SyntaxError: Unexpected end of JSON input
cmderr	[generateScript.sh]     at JSON.parse (<anonymous>)
cmderr	[generateScript.sh]     at Object.readJsonFile (/home/vsts/work/1/s/azure-resource-manager-schemas/generator/utils.ts:174:17)
cmderr	[generateScript.sh]     at getCurrentTemplateRefs (/home/vsts/work/1/s/azure-resource-manager-schemas/generator/generate.ts:290:21)
cmderr	[generateScript.sh]     at /home/vsts/work/1/s/azure-resource-manager-schemas/generator/generate.ts:297:29
cmderr	[generateScript.sh] (node:2413) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 5)
cmderr	[generateScript.sh] (node:2413) UnhandledPromiseRejectionWarning: SyntaxError: Unexpected end of JSON input
cmderr	[generateScript.sh]     at JSON.parse (<anonymous>)
cmderr	[generateScript.sh]     at Object.readJsonFile (/home/vsts/work/1/s/azure-resource-manager-schemas/generator/utils.ts:174:17)
cmderr	[generateScript.sh]     at getCurrentTemplateRefs (/home/vsts/work/1/s/azure-resource-manager-schemas/generator/generate.ts:290:21)
cmderr	[generateScript.sh]     at /home/vsts/work/1/s/azure-resource-manager-schemas/generator/generate.ts:297:29
cmderr	[generateScript.sh] (node:2413) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 6)

️✔️guestconfiguration [View full logs] [Release Schema Changes]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2021-09-09T22:32:40Z

Hi @aashish1987, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff.

Task	How to fix	Priority	Support (Microsoft alias)
Avocado	Fix-Avocado	High	ruowan
Semantic validation	Fix-SemanticValidation-Error	High	raychen, jianyxi
Model validation	Fix-ModelValidation-Error	High	raychen,jianyxi
LintDiff	Fix-LintDiff	high	jianyxi, ruoxuan

If you need further help, please feedback via swagger feedback."

openapi-workflow-bot · 2021-09-09T22:32:44Z

NewApiVersionRequired reason:

A service’s API is a contract with customers and is represented by using the api-version query parameter. Changes such as adding an optional property to a request/response or introducing a new operation is a change to the service’s contract and therefore requires a new api-version value. This is critically important for documentation, client libraries, and customer support.

EXAMPLE: if a customer calls a service in the public cloud using api-version=2020-07-27, the new property or operation may exist but if they call the service in a government cloud, air-gapped cloud, or Azure Stack Hub cloud using the same api-version, the property or operation may not exist. Because there is no clear relationship between the service api-version and the new property/operation, customers can’t trust the documentation and Azure customer have difficulty helping customers diagnose issues. In addition, each client library version documents the service version it supports. When an optional property or new operation is added to a service and its Swagger, new client libraries must be produced to expose this functionality to customers. Without updating the api-version, it is unclear to customers which version of a client library supports these new features.

openapi-workflow-bot · 2021-09-09T22:32:44Z

Hi @aashish1987, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
If you want to know the production traffic statistic, please see ARM Traffic statistic.
If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.

…i-specs

aashish1987 · 2021-09-14T21:04:32Z

Can someone please help me with the failures here?
I have updated the PR to point it to the new default main branch, but still it is complaining.

akning-ms · 2021-09-15T09:35:15Z

Can someone please help me with the failures here?
I have updated the PR to point it to the new default main branch, but still it is complaining.

which failure do you mean? @aashish1987

aashish1987 · 2021-09-15T17:41:12Z

Failing after 28s — Build #Azure OpenAPI failed
Failing after 21s — ShouldSendPRToMain failed

If you look into the section - Some checks were not successful you can see above two failures.
Not sure if those are warnings.

Also can someone please help me with the review.
@akning-ms

ArcturusZhang · 2021-09-16T02:48:21Z

/azp run

azure-pipelines · 2021-09-16T02:48:30Z

Azure Pipelines successfully started running 1 pipeline(s).

…#1912) Create to sync Azure/azure-rest-api-specs#15988 [ReCreate this PR](https://github.com/azure-resource-manager-schemas/compare/main...AzureSDKAutomation:sdkAuto/guestconfiguration?expand=1)

* Add GET all methods for resource group and subscription * Fix Linter Validation issue * Fix Swagger Correctness S360 items * Fix swagger validation comments * Fix model validaiton * Fix Lint errors * Fix model validation for examples Co-authored-by: Aashish Rajaram Salokhe <[email protected]>

Aashish Rajaram Salokhe and others added 4 commits August 12, 2021 14:39

Add GET all methods for resource group and subscription

43381b5

Fix Linter Validation issue

838bb79

Fix Swagger Correctness S360 items

2570a48

Merge branch 'Azure:master' into master

e35147b

openapi-assignment-bot bot assigned akning-ms Sep 9, 2021

openapi-pipeline-app bot added the CI-FixRequiredOnFailure label Sep 9, 2021

openapi-pipeline-app bot added BreakingChangeReviewRequired labels Sep 9, 2021

openapi-sdkautomation bot mentioned this pull request Sep 9, 2021

[AutoPR guestconfiguration] Guest Configuration S360 Swagger fixes AzureSDKAutomation/azure-resource-manager-schemas#4676

Closed

JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Sep 13, 2021

Aashish Rajaram Salokhe and others added 4 commits September 13, 2021 17:13

Fix swagger validation comments

d6e611a

Merge branch 'Azure:master' into master

ccfa3a4

Merge branch 'master' of https://github.com/aashish1987/azure-rest-ap…

5083c29

…i-specs

Fix model validaiton

e0419af

openapi-pipeline-app bot removed the BreakingChangeReviewRequired label Sep 14, 2021

Fix Lint errors

b5c44ce

openapi-sdkautomation bot mentioned this pull request Sep 14, 2021

[AutoPR track2_azure-mgmt-guestconfig] Guest Configuration S360 Swagger fixes AzureSDKAutomation/azure-sdk-for-python#7355

Closed

Fix model validation for examples

245e977

openapi-pipeline-app bot added CI-FixRequiredOnFailure and removed CI-FixRequiredOnFailure labels Sep 14, 2021

aashish1987 changed the base branch from master to main September 14, 2021 20:53

openapi-pipeline-app bot removed the CI-FixRequiredOnFailure label Sep 14, 2021

ArcturusZhang approved these changes Sep 16, 2021

View reviewed changes

ArcturusZhang merged commit ca93e24 into Azure:main Sep 16, 2021

Guest Configuration S360 Swagger fixes #15988

Guest Configuration S360 Swagger fixes #15988

Uh oh!

Conversation

aashish1987 commented Sep 9, 2021

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

Uh oh!

openapi-workflow-bot bot commented Sep 9, 2021

Uh oh!

openapi-workflow-bot bot commented Sep 9, 2021

Uh oh!

openapi-pipeline-app bot commented Sep 9, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Swagger Validation Report

Uh oh!

openapi-pipeline-app bot commented Sep 9, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Swagger Generation Artifacts

Breaking Changes Tracking

Uh oh!

openapi-workflow-bot bot commented Sep 9, 2021

Uh oh!

openapi-workflow-bot bot commented Sep 9, 2021

Uh oh!

openapi-workflow-bot bot commented Sep 9, 2021

Uh oh!

aashish1987 commented Sep 14, 2021

Uh oh!

akning-ms commented Sep 15, 2021

Uh oh!

aashish1987 commented Sep 15, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ArcturusZhang commented Sep 16, 2021

Uh oh!

azure-pipelines bot commented Sep 16, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

openapi-pipeline-app bot commented Sep 9, 2021 •

edited

Loading

openapi-pipeline-app bot commented Sep 9, 2021 •

edited

Loading

aashish1987 commented Sep 15, 2021 •

edited

Loading