-
Notifications
You must be signed in to change notification settings - Fork 5.6k
initial PR to the new release branch #15842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
lirenhe
merged 8 commits into
Azure:network-may-release
from
amosarbiv-work:amosarbiv/IDPS-API-SPECS
Oct 15, 2021
Merged
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
08c3ad9
initial PR to the new release branch
amosarbiv-work b15be0d
moved body to end of request parameters, changed api version number i…
amosarbiv-work 93ab1ea
Added action name for the list idps filter values
amosarbiv-work 6d697a0
changed to match camel casing for the action added
amosarbiv-work 9d4c906
fixed CR issues
amosarbiv-work 2e90567
fixing auto checks
amosarbiv-work 9ebeb15
fixed ARM cr issues
amosarbiv-work e204172
fixing the resource type to match specification
amosarbiv-work File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
68 changes: 68 additions & 0 deletions
68
...r/Microsoft.Network/stable/2021-05-01/examples/FirewallPolicyQuerySignatureOverrides.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,68 @@ | ||
| { | ||
| "parameters": { | ||
| "api-version": "2021-05-01", | ||
| "subscriptionId": "e747cc13-97d4-4a79-b463-42d7f4e558f2", | ||
| "resourceGroupName": "rg1", | ||
| "firewallPolicyName": "firewallPolicy", | ||
| "parameters": { | ||
| "filters": [ | ||
| { | ||
| "field": "Mode", | ||
| "values": [ | ||
| "Deny" | ||
| ] | ||
| } | ||
| ], | ||
| "search": "", | ||
| "orderBy": { | ||
| "field": "severity", | ||
| "order": "Ascending" | ||
| }, | ||
| "resultsPerPage": 20, | ||
| "skip": 0 | ||
| } | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "body": { | ||
| "signatures": [ | ||
| { | ||
| "signatureId": 2000015, | ||
| "mode": 2, | ||
| "severity": 1, | ||
| "direction": 2, | ||
| "group": "A Network Trojan was detected", | ||
| "description": "P2P Phatbot Control Connection", | ||
| "sourcePorts": [ | ||
| "any" | ||
| ], | ||
| "destinationPorts": [ | ||
| "any" | ||
| ], | ||
| "lastUpdated": "2010-07-30T00:00:00", | ||
| "inheritedFromParentPolicy": false, | ||
| "protocol": "tcp" | ||
| }, | ||
| { | ||
| "signatureId": 2000106, | ||
| "mode": 2, | ||
| "severity": 1, | ||
| "direction": 1, | ||
| "group": "Attempted User Privilege Gain", | ||
| "description": "WEB_SERVER SQL sp_delete_alert attempt", | ||
| "sourcePorts": [ | ||
| "any" | ||
| ], | ||
| "destinationPorts": [ | ||
| "any" | ||
| ], | ||
| "lastUpdated": "2019-09-27T00:00:00", | ||
| "inheritedFromParentPolicy": false, | ||
| "protocol": "http" | ||
| } | ||
| ], | ||
| "matchingRecordsCount": 2 | ||
| } | ||
| } | ||
| } | ||
| } |
22 changes: 22 additions & 0 deletions
22
...Network/stable/2021-05-01/examples/FirewallPolicyQuerySignatureOverridesFilterValues.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| { | ||
| "parameters": { | ||
| "api-version": "2021-05-01", | ||
| "subscriptionId": "e747cc13-97d4-4a79-b463-42d7f4e558f2", | ||
| "resourceGroupName": "rg1", | ||
| "firewallPolicyName": "firewallPolicy", | ||
| "parameters": { | ||
| "filterName": "severity" | ||
| } | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "body": { | ||
| "filterValues": [ | ||
| "low", | ||
| "medium", | ||
| "high" | ||
| ] | ||
| } | ||
| } | ||
| } | ||
| } |
24 changes: 24 additions & 0 deletions
24
...ger/Microsoft.Network/stable/2021-05-01/examples/FirewallPolicySignatureOverridesGet.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| { | ||
| "parameters": { | ||
| "api-version": "2021-05-01", | ||
| "subscriptionId": "e747cc13-97d4-4a79-b463-42d7f4e558f2", | ||
| "resourceGroupName": "rg1", | ||
| "firewallPolicyName": "firewallPolicy", | ||
| "parameters": {} | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "body": { | ||
| "id": "/subscriptions/e747cc13-97d4-4a79-b463-42d7f4e558f2/resourceGroups/rg1/providers/Microsoft.Network/firewallPolicies/firewallPolicy/IntrusionDetectionSignaturesOverrides/default", | ||
| "name": "default", | ||
| "type": "Microsoft.Network/firewallPolicies/intrusionDetectionSignaturesOverrides", | ||
| "properties": { | ||
| "signatures": { | ||
| "2000105": "Off", | ||
| "2000106": "Deny" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
26 changes: 26 additions & 0 deletions
26
...er/Microsoft.Network/stable/2021-05-01/examples/FirewallPolicySignatureOverridesList.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| { | ||
| "parameters": { | ||
| "api-version": "2021-05-01", | ||
| "subscriptionId": "e747cc13-97d4-4a79-b463-42d7f4e558f2", | ||
| "resourceGroupName": "rg1", | ||
| "firewallPolicyName": "firewallPolicy", | ||
| "parameters": {} | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "body": [ | ||
pilor marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| { | ||
| "id": "/subscriptions/e747cc13-97d4-4a79-b463-42d7f4e558f2/resourceGroups/rg1/providers/Microsoft.Network/firewallPolicies/firewallPolicy/IntrusionDetectionSignaturesOverrides/default", | ||
|
||
| "name": "default", | ||
| "type": "Microsoft.Network/firewallPolicies/intrusionDetectionSignaturesOverrides", | ||
| "properties": { | ||
| "signatures": { | ||
| "2000105": "Off", | ||
| "2000106": "Deny" | ||
| } | ||
| } | ||
| } | ||
| ] | ||
| } | ||
| } | ||
| } | ||
34 changes: 34 additions & 0 deletions
34
...r/Microsoft.Network/stable/2021-05-01/examples/FirewallPolicySignatureOverridesPatch.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| { | ||
| "parameters": { | ||
| "api-version": "2021-05-01", | ||
| "subscriptionId": "e747cc13-97d4-4a79-b463-42d7f4e558f2", | ||
| "resourceGroupName": "rg1", | ||
| "firewallPolicyName": "firewallPolicy", | ||
| "parameters": { | ||
| "id": "/subscriptions/e747cc13-97d4-4a79-b463-42d7f4e558f2/resourceGroups/rg1/providers/Microsoft.Network/firewallPolicies/firewallPolicy/IntrusionDetectionSignaturesOverrides/default", | ||
| "name": "default", | ||
| "type": "Microsoft.Network/firewallPolicies/intrusionDetectionSignaturesOverrides", | ||
| "properties": { | ||
| "signatures": { | ||
| "2000105": "Off", | ||
| "2000106": "Deny" | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "body": { | ||
| "id": "/subscriptions/e747cc13-97d4-4a79-b463-42d7f4e558f2/resourceGroups/rg1/providers/Microsoft.Network/firewallPolicies/firewallPolicy/IntrusionDetectionSignaturesOverrides/default", | ||
| "name": "default", | ||
| "type": "Microsoft.Network/firewallPolicies/intrusionDetectionSignaturesOverrides", | ||
| "properties": { | ||
| "signatures": { | ||
| "2000105": "Off", | ||
| "2000106": "Deny" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } |
34 changes: 34 additions & 0 deletions
34
...ger/Microsoft.Network/stable/2021-05-01/examples/FirewallPolicySignatureOverridesPut.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| { | ||
| "parameters": { | ||
| "api-version": "2021-05-01", | ||
| "subscriptionId": "e747cc13-97d4-4a79-b463-42d7f4e558f2", | ||
| "resourceGroupName": "rg1", | ||
| "firewallPolicyName": "firewallPolicy", | ||
| "parameters": { | ||
| "id": "/subscriptions/e747cc13-97d4-4a79-b463-42d7f4e558f2/resourceGroups/rg1/providers/Microsoft.Network/firewallPolicies/firewallPolicy/IntrusionDetectionSignaturesOverrides/default", | ||
| "name": "default", | ||
| "type": "Microsoft.Network/firewallPolicies/intrusionDetectionSignaturesOverrides", | ||
| "properties": { | ||
| "signatures": { | ||
| "2000105": "Off", | ||
| "2000106": "Deny" | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "body": { | ||
| "id": "/subscriptions/e747cc13-97d4-4a79-b463-42d7f4e558f2/resourceGroups/rg1/providers/Microsoft.Network/firewallPolicies/firewallPolicy/IntrusionDetectionSignaturesOverrides/default", | ||
| "name": "default", | ||
| "type": "Microsoft.Network/firewallPolicies/intrusionDetectionSignaturesOverrides", | ||
| "properties": { | ||
| "signatures": { | ||
| "2000105": "Off", | ||
| "2000106": "Deny" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this type name does not match the spec
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The resource type name is "signatureOverrides" in the swagger spec, not "IntrusionDetectionSignaturesOverrides". It needs to be fixed in all examples that use the wrong name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry for the confusion, I fixed the issues.