Skip to content

initial PR to the new release branch #15842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lirenhe merged 8 commits into from
Oct 15, 2021
Merged

initial PR to the new release branch #15842

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
08c3ad9
initial PR to the new release branch
amosarbiv-work Aug 29, 2021
b15be0d
moved body to end of request parameters, changed api version number i…
amosarbiv-work Aug 30, 2021
93ab1ea
Added action name for the list idps filter values
amosarbiv-work Sep 29, 2021
6d697a0
changed to match camel casing for the action added
amosarbiv-work Sep 29, 2021
9d4c906
fixed CR issues
amosarbiv-work Oct 3, 2021
2e90567
fixing auto checks
amosarbiv-work Oct 3, 2021
9ebeb15
fixed ARM cr issues
amosarbiv-work Oct 12, 2021
e204172
fixing the resource type to match specification
amosarbiv-work Oct 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
68 changes: 68 additions & 0 deletions ...r/Microsoft.Network/stable/2021-05-01/examples/FirewallPolicyQuerySignatureOverrides.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,68 @@
{
"parameters": {
"api-version": "2021-02-01",
"subscriptionId": "e747cc13-97d4-4a79-b463-42d7f4e558f2",
"resourceGroupName": "rg1",
"firewallPolicyName": "firewallPolicy",
"parameters": {
"filters": [
{
"field": "Mode",
"values": [
"Deny"
]
}
],
"search": "",
"orderBy": {
"field": "severity",
"asc": true
},
"resultsPerPage": 20,
"skip": 0
}
},
"responses": {
"200": {
"body": {
"signatures": [
{
"signatureId": 2000015,
"mode": 2,
"severity": 1,
"direction": 2,
"group": "A Network Trojan was detected",
"description": "P2P Phatbot Control Connection",
"sourcePorts": [
"any"
],
"destinationPorts": [
"any"
],
"lastUpdated": "2010-07-30T00:00:00",
"inheritedFromParentPolicy": false,
"protocol": "tcp"
},
{
"signatureId": 2000106,
"mode": 2,
"severity": 1,
"direction": 1,
"group": "Attempted User Privilege Gain",
"description": "WEB_SERVER SQL sp_delete_alert attempt",
"sourcePorts": [
"any"
],
"destinationPorts": [
"any"
],
"lastUpdated": "2019-09-27T00:00:00",
"inheritedFromParentPolicy": false,
"protocol": "http"
}
],
"allRecords": 2
}
}
}
}
22 changes: 22 additions & 0 deletions ...Network/stable/2021-05-01/examples/FirewallPolicyQuerySignatureOverridesFilterValues.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
{
"parameters": {
"api-version": "2021-02-01",
"subscriptionId": "e747cc13-97d4-4a79-b463-42d7f4e558f2",
"resourceGroupName": "rg1",
"firewallPolicyName": "firewallPolicy",
"parameters": {
"filterName": "severity"
}
},
"responses": {
"200": {
"body": {
"filterValues": [
"low",
"medium",
"high"
]
}
}
}
}
24 changes: 24 additions & 0 deletions ...ger/Microsoft.Network/stable/2021-05-01/examples/FirewallPolicySignatureOverridesGet.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
{
"parameters": {
"api-version": "2021-02-01",
"subscriptionId": "e747cc13-97d4-4a79-b463-42d7f4e558f2",
"resourceGroupName": "rg1",
"firewallPolicyName": "firewallPolicy",
"parameters": {}
},
"responses": {
"200": {
"body": {
"id": "/subscriptions/e747cc13-97d4-4a79-b463-42d7f4e558f2/resourceGroups/rg1/providers/Microsoft.Network/firewallPolicies/firewallPolicy/IntrusionDetectionSignaturesOverrides/default",
Copy link
Contributor

@pilor pilor Oct 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IntrusionDetectionSignaturesOverrides

this type name does not match the spec

Copy link
Contributor Author

@amosarbiv-work amosarbiv-work Oct 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Copy link
Contributor

@pilor pilor Oct 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The resource type name is "signatureOverrides" in the swagger spec, not "IntrusionDetectionSignaturesOverrides". It needs to be fixed in all examples that use the wrong name

Copy link
Contributor Author

@amosarbiv-work amosarbiv-work Oct 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for the confusion, I fixed the issues.

"name": "default",
"type": "Microsoft.Network/firewallPolicies/intrusionDetectionSignaturesOverrides",
"properties": {
"signatures": {
"2000105": "Off",
"2000106": "Deny"
}
}
}
}
}
}
34 changes: 34 additions & 0 deletions ...r/Microsoft.Network/stable/2021-05-01/examples/FirewallPolicySignatureOverridesPatch.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
{
"parameters": {
"api-version": "2021-02-01",
"subscriptionId": "e747cc13-97d4-4a79-b463-42d7f4e558f2",
"resourceGroupName": "rg1",
"firewallPolicyName": "firewallPolicy",
"parameters": {
"id": "/subscriptions/e747cc13-97d4-4a79-b463-42d7f4e558f2/resourceGroups/rg1/providers/Microsoft.Network/firewallPolicies/firewallPolicy/IntrusionDetectionSignaturesOverrides/default",
"name": "default",
"type": "Microsoft.Network/firewallPolicies/intrusionDetectionSignaturesOverrides",
"properties": {
"signatures": {
"2000105": "Off",
"2000106": "Deny"
}
}
}
},
"responses": {
"200": {
"body": {
"id": "/subscriptions/e747cc13-97d4-4a79-b463-42d7f4e558f2/resourceGroups/rg1/providers/Microsoft.Network/firewallPolicies/firewallPolicy/IntrusionDetectionSignaturesOverrides/default",
"name": "default",
"type": "Microsoft.Network/firewallPolicies/intrusionDetectionSignaturesOverrides",
"properties": {
"signatures": {
"2000105": "Off",
"2000106": "Deny"
}
}
}
}
}
}
34 changes: 34 additions & 0 deletions ...ger/Microsoft.Network/stable/2021-05-01/examples/FirewallPolicySignatureOverridesPut.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
{
"parameters": {
"api-version": "2021-02-01",
"subscriptionId": "e747cc13-97d4-4a79-b463-42d7f4e558f2",
"resourceGroupName": "rg1",
"firewallPolicyName": "firewallPolicy",
"parameters": {
"id": "/subscriptions/e747cc13-97d4-4a79-b463-42d7f4e558f2/resourceGroups/rg1/providers/Microsoft.Network/firewallPolicies/firewallPolicy/IntrusionDetectionSignaturesOverrides/default",
"name": "default",
"type": "Microsoft.Network/firewallPolicies/intrusionDetectionSignaturesOverrides",
"properties": {
"signatures": {
"2000105": "Off",
"2000106": "Deny"
}
}
}
},
"responses": {
"200": {
"body": {
"id": "/subscriptions/e747cc13-97d4-4a79-b463-42d7f4e558f2/resourceGroups/rg1/providers/Microsoft.Network/firewallPolicies/firewallPolicy/IntrusionDetectionSignaturesOverrides/default",
"name": "default",
"type": "Microsoft.Network/firewallPolicies/intrusionDetectionSignaturesOverrides",
"properties": {
"signatures": {
"2000105": "Off",
"2000106": "Deny"
}
}
}
}
}
}
Loading