Service Fabric Managed Clusters - 2021 09 01 privatepreview by a-santamaria · Pull Request #15835 · Azure/azure-rest-api-specs

a-santamaria · 2021-08-27T19:54:32Z

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
If updating an existing version, please select the specific langauge SDKs and CLIs that must be refreshed after the swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No refresh required for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs

Adding new properties

All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

Check this box if any of the following apply to the PR so that label “WaitForARMFeedback” will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
- Adding a new service
- Adding new API(s)
- Adding a new API version
  -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

Removing API(s) in a stable version
Removing properties in a stable version
Removing API version(s) in a stable version
Updating API in a stable or public preview version with Breaking Change Validation errors
Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

openapi-workflow-bot · 2021-08-27T19:54:34Z

Hi, @a-santamaria Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

openapi-workflow-bot · 2021-08-27T19:54:35Z

[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

openapi-pipeline-app · 2021-08-27T19:54:37Z

Swagger Validation Report

️❌BreakingChange: 302 Errors, 0 Warnings failed [Detail]

Compared Swaggers (Based on Oad v0.9.0)
- current:Microsoft.ServiceFabricManagedClusters/preview/2021-01-01-preview compared with base:Microsoft.ServiceFabricManagedClusters/preview/2021-01-01-preview
- current:Microsoft.ServiceFabricManagedClusters/preview/2021-07-01-preview compared with base:Microsoft.ServiceFabricManagedClusters/preview/2021-07-01-preview
- current:Microsoft.ServiceFabricManagedClusters/stable/2021-05-01 compared with base:Microsoft.ServiceFabricManagedClusters/stable/2021-05-01

Only 22 items are listed, please refer to log for more details.

Rule	Message
`❌` 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ServiceFabric/managedclusters/{clusterName}/applicationTypes/{applicationTypeName}' removed or restructured? Old: Microsoft.ServiceFabricManagedClusters/preview/2021-01-01-preview/managedapplication.json#L37:5
`❌` 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ServiceFabric/managedclusters/{clusterName}/applicationTypes' removed or restructured? Old: Microsoft.ServiceFabricManagedClusters/preview/2021-01-01-preview/managedapplication.json#L241:5
`❌` 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ServiceFabric/managedclusters/{clusterName}/applicationTypes/{applicationTypeName}/versions/{version}' removed or restructured? Old: Microsoft.ServiceFabricManagedClusters/preview/2021-01-01-preview/managedapplication.json#L287:5
`❌` 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ServiceFabric/managedclusters/{clusterName}/applicationTypes/{applicationTypeName}/versions' removed or restructured? Old: Microsoft.ServiceFabricManagedClusters/preview/2021-01-01-preview/managedapplication.json#L513:5
`❌` 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ServiceFabric/managedclusters/{clusterName}/applications/{applicationName}' removed or restructured? Old: Microsoft.ServiceFabricManagedClusters/preview/2021-01-01-preview/managedapplication.json#L562:5
`❌` 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ServiceFabric/managedclusters/{clusterName}/applications' removed or restructured? Old: Microsoft.ServiceFabricManagedClusters/preview/2021-01-01-preview/managedapplication.json#L779:5
`❌` 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ServiceFabric/managedclusters/{clusterName}/applications/{applicationName}/services/{serviceName}' removed or restructured? Old: Microsoft.ServiceFabricManagedClusters/preview/2021-01-01-preview/managedapplication.json#L825:5
`❌` 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ServiceFabric/managedclusters/{clusterName}/applications/{applicationName}/services' removed or restructured? Old: Microsoft.ServiceFabricManagedClusters/preview/2021-01-01-preview/managedapplication.json#L1054:5
`❌` 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}/providers/Microsoft.ServiceFabric/managedClusters' removed or restructured? Old: Microsoft.ServiceFabricManagedClusters/preview/2021-01-01-preview/managedcluster.json#L37:5
`❌` 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.ServiceFabric/managedClusters' removed or restructured? Old: Microsoft.ServiceFabricManagedClusters/preview/2021-01-01-preview/managedcluster.json#L80:5
`❌` 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ServiceFabric/managedClusters/{clusterName}' removed or restructured? Old: Microsoft.ServiceFabricManagedClusters/preview/2021-01-01-preview/managedcluster.json#L120:5
`❌` 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/providers/Microsoft.ServiceFabric/operations' removed or restructured? Old: Microsoft.ServiceFabricManagedClusters/preview/2021-01-01-preview/managedcluster.json#L326:5
`❌` 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}/providers/Microsoft.ServiceFabric/managedClusters/{clusterName}/nodeTypes' removed or restructured? Old: Microsoft.ServiceFabricManagedClusters/preview/2021-01-01-preview/nodetype.json#L37:5
`❌` 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ServiceFabric/managedClusters/{clusterName}/nodeTypes/{nodeTypeName}/restart' removed or restructured? Old: Microsoft.ServiceFabricManagedClusters/preview/2021-01-01-preview/nodetype.json#L83:5
`❌` 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ServiceFabric/managedClusters/{clusterName}/nodeTypes/{nodeTypeName}/reimage' removed or restructured? Old: Microsoft.ServiceFabricManagedClusters/preview/2021-01-01-preview/nodetype.json#L143:5
`❌` 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ServiceFabric/managedClusters/{clusterName}/nodeTypes/{nodeTypeName}/deleteNode' removed or restructured? Old: Microsoft.ServiceFabricManagedClusters/preview/2021-01-01-preview/nodetype.json#L203:5
`❌` 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ServiceFabric/managedClusters/{clusterName}/nodeTypes/{nodeTypeName}' removed or restructured? Old: Microsoft.ServiceFabricManagedClusters/preview/2021-01-01-preview/nodetype.json#L263:5
`❌` 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ServiceFabric/managedclusters/{clusterName}/applicationTypes/{applicationTypeName}' removed or restructured? Old: Microsoft.ServiceFabricManagedClusters/preview/2021-07-01-preview/managedapplication.json#L37:5
`❌` 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ServiceFabric/managedclusters/{clusterName}/applicationTypes' removed or restructured? Old: Microsoft.ServiceFabricManagedClusters/preview/2021-07-01-preview/managedapplication.json#L241:5
`❌` 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ServiceFabric/managedclusters/{clusterName}/applicationTypes/{applicationTypeName}/versions/{version}' removed or restructured? Old: Microsoft.ServiceFabricManagedClusters/preview/2021-07-01-preview/managedapplication.json#L287:5
`❌` 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ServiceFabric/managedclusters/{clusterName}/applicationTypes/{applicationTypeName}/versions' removed or restructured? Old: Microsoft.ServiceFabricManagedClusters/preview/2021-07-01-preview/managedapplication.json#L513:5
`❌` 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ServiceFabric/managedclusters/{clusterName}/applications/{applicationName}' removed or restructured? Old: Microsoft.ServiceFabricManagedClusters/preview/2021-07-01-preview/managedapplication.json#L562:5

️⚠️LintDiff: 1 Warnings warning [Detail]

Linted configuring files (Based on source branch, openapi-validator v1.10.1 , classic-openapi-validator v1.1.10 )
Linted configuring files (Based on target branch, openapi-validator v1.10.1 , classic-openapi-validator v1.1.10 )

The following errors/warnings are introduced by current PR:

Rule	Message
⚠️ R2001 - AvoidNestedProperties	Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.ServiceFabric/preview/2021-09-01-privatepreview/managedcluster.json#L1118

The following errors/warnings exist before current PR submission:

Only 22 items are listed, please refer to log for more details.

Rule	Message
`❌` R4037 - MissingTypeObject	The schema 'AddRemoveIncrementalNamedPartitionScalingMechanism' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ServiceFabric/stable/2021-05-01/managedapplication.json#L1105
`❌` R4037 - MissingTypeObject	The schema 'ApplicationResource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ServiceFabric/stable/2021-05-01/managedapplication.json#L1174
`❌` R4037 - MissingTypeObject	The schema 'ApplicationResourceList' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ServiceFabric/stable/2021-05-01/managedapplication.json#L1191
`❌` R4037 - MissingTypeObject	The schema 'ApplicationResourceProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ServiceFabric/stable/2021-05-01/managedapplication.json#L1207
`❌` R4037 - MissingTypeObject	The schema 'ApplicationTypeResource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ServiceFabric/stable/2021-05-01/managedapplication.json#L1233
`❌` R4037 - MissingTypeObject	The schema 'ApplicationTypeResourceList' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ServiceFabric/stable/2021-05-01/managedapplication.json#L1247
`❌` R4037 - MissingTypeObject	The schema 'ApplicationTypeResourceProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ServiceFabric/stable/2021-05-01/managedapplication.json#L1263
`❌` R4037 - MissingTypeObject	The schema 'ApplicationTypeUpdateParameters' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ServiceFabric/stable/2021-05-01/managedapplication.json#L1273
`❌` R4037 - MissingTypeObject	The schema 'ApplicationTypeVersionResource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ServiceFabric/stable/2021-05-01/managedapplication.json#L1289
`❌` R4037 - MissingTypeObject	The schema 'ApplicationTypeVersionResourceList' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ServiceFabric/stable/2021-05-01/managedapplication.json#L1303
`❌` R4037 - MissingTypeObject	The schema 'ApplicationTypeVersionResourceProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ServiceFabric/stable/2021-05-01/managedapplication.json#L1319
`❌` R4037 - MissingTypeObject	The schema 'ApplicationTypeVersionUpdateParameters' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ServiceFabric/stable/2021-05-01/managedapplication.json#L1336
`❌` R4037 - MissingTypeObject	The schema 'ApplicationUpdateParameters' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ServiceFabric/stable/2021-05-01/managedapplication.json#L1348
`❌` R4037 - MissingTypeObject	The schema 'ApplicationUpgradePolicy' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ServiceFabric/stable/2021-05-01/managedapplication.json#L1360
`❌` R4037 - MissingTypeObject	The schema 'ApplicationUserAssignedIdentity' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ServiceFabric/stable/2021-05-01/managedapplication.json#L1391
`❌` R4037 - MissingTypeObject	The schema 'AveragePartitionLoadScalingTrigger' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ServiceFabric/stable/2021-05-01/managedapplication.json#L1407
`❌` R4037 - MissingTypeObject	The schema 'AverageServiceLoadScalingTrigger' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ServiceFabric/stable/2021-05-01/managedapplication.json#L1446
`❌` R4037 - MissingTypeObject	The schema 'ManagedIdentity' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ServiceFabric/stable/2021-05-01/managedapplication.json#L1514
`❌` R4037 - MissingTypeObject	The schema 'NamedPartitionScheme' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ServiceFabric/stable/2021-05-01/managedapplication.json#L1599
`❌` R4037 - MissingTypeObject	The schema 'PartitionInstanceCountScaleMechanism' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ServiceFabric/stable/2021-05-01/managedapplication.json#L1638
`❌` R4037 - MissingTypeObject	The schema 'ProxyResource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ServiceFabric/stable/2021-05-01/managedapplication.json#L1700
`❌` R4037 - MissingTypeObject	The schema 'RollingUpgradeMonitoringPolicy' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ServiceFabric/stable/2021-05-01/managedapplication.json#L1765

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️⚠️[Staging] SDK Track2 Validation: 11 Warnings warning [Detail]

The following tags are being changed in this PR

The following errors/warnings are introduced by current PR:

Rule	Message
⚠️ PreCheck/EmptyParentSchemaWarning	"readme":"servicefabricmanagedclusters/resource-manager/readme.md", "tag":"package-2021-09-privatepreview", "details":"Schema 'AddRemoveIncrementalNamedPartitionScalingMechanism' has an allOf list with an empty object schema as a parent, removing it."
⚠️ PreCheck/EmptyParentSchemaWarning	"readme":"servicefabricmanagedclusters/resource-manager/readme.md", "tag":"package-2021-09-privatepreview", "details":"Schema 'AveragePartitionLoadScalingTrigger' has an allOf list with an empty object schema as a parent, removing it."
⚠️ PreCheck/EmptyParentSchemaWarning	"readme":"servicefabricmanagedclusters/resource-manager/readme.md", "tag":"package-2021-09-privatepreview", "details":"Schema 'AverageServiceLoadScalingTrigger' has an allOf list with an empty object schema as a parent, removing it."
⚠️ PreCheck/EmptyParentSchemaWarning	"readme":"servicefabricmanagedclusters/resource-manager/readme.md", "tag":"package-2021-09-privatepreview", "details":"Schema 'NamedPartitionScheme' has an allOf list with an empty object schema as a parent, removing it."
⚠️ PreCheck/EmptyParentSchemaWarning	"readme":"servicefabricmanagedclusters/resource-manager/readme.md", "tag":"package-2021-09-privatepreview", "details":"Schema 'PartitionInstanceCountScaleMechanism' has an allOf list with an empty object schema as a parent, removing it."
⚠️ PreCheck/EmptyParentSchemaWarning	"readme":"servicefabricmanagedclusters/resource-manager/readme.md", "tag":"package-2021-09-privatepreview", "details":"Schema 'ServicePlacementInvalidDomainPolicy' has an allOf list with an empty object schema as a parent, removing it."
⚠️ PreCheck/EmptyParentSchemaWarning	"readme":"servicefabricmanagedclusters/resource-manager/readme.md", "tag":"package-2021-09-privatepreview", "details":"Schema 'ServicePlacementPreferPrimaryDomainPolicy' has an allOf list with an empty object schema as a parent, removing it."
⚠️ PreCheck/EmptyParentSchemaWarning	"readme":"servicefabricmanagedclusters/resource-manager/readme.md", "tag":"package-2021-09-privatepreview", "details":"Schema 'ServicePlacementRequiredDomainPolicy' has an allOf list with an empty object schema as a parent, removing it."
⚠️ PreCheck/EmptyParentSchemaWarning	"readme":"servicefabricmanagedclusters/resource-manager/readme.md", "tag":"package-2021-09-privatepreview", "details":"Schema 'ServicePlacementRequireDomainDistributionPolicy' has an allOf list with an empty object schema as a parent, removing it."
⚠️ PreCheck/EmptyParentSchemaWarning	"readme":"servicefabricmanagedclusters/resource-manager/readme.md", "tag":"package-2021-09-privatepreview", "details":"Schema 'UniformInt64RangePartitionScheme' has an allOf list with an empty object schema as a parent, removing it."
⚠️ PreCheck/EmptyParentSchemaWarning	"readme":"servicefabricmanagedclusters/resource-manager/readme.md", "tag":"package-2021-09-privatepreview", "details":"Schema 'ManagedCluster' has an allOf list with an empty object schema as a parent, removing it."
💬 AutorestCore/Exception	"readme":"servicefabricmanagedclusters/resource-manager/readme.md", "tag":"package-2021-07-preview", "details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)"
💬 AutorestCore/Exception	"readme":"servicefabricmanagedclusters/resource-manager/readme.md", "tag":"package-2021-07-preview", "details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"
💬 AutorestCore/Exception	"readme":"servicefabricmanagedclusters/resource-manager/readme.md", "tag":"package-2021-09-privatepreview", "details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"
💬 AutorestCore/Exception	"readme":"servicefabricmanagedclusters/resource-manager/readme.md", "tag":"package-2021-09-privatepreview", "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"

The following errors/warnings exist before current PR submission:

Only 22 items are listed, please refer to log for more details.

Rule	Message
⚠️ PreCheck/EmptyParentSchemaWarning	"readme":"servicefabricmanagedclusters/resource-manager/readme.md", "tag":"package-2021-07-preview", "details":"Schema 'AddRemoveIncrementalNamedPartitionScalingMechanism' has an allOf list with an empty object schema as a parent, removing it."
⚠️ PreCheck/EmptyParentSchemaWarning	"readme":"servicefabricmanagedclusters/resource-manager/readme.md", "tag":"package-2021-07-preview", "details":"Schema 'AveragePartitionLoadScalingTrigger' has an allOf list with an empty object schema as a parent, removing it."
⚠️ PreCheck/EmptyParentSchemaWarning	"readme":"servicefabricmanagedclusters/resource-manager/readme.md", "tag":"package-2021-07-preview", "details":"Schema 'AverageServiceLoadScalingTrigger' has an allOf list with an empty object schema as a parent, removing it."
⚠️ PreCheck/EmptyParentSchemaWarning	"readme":"servicefabricmanagedclusters/resource-manager/readme.md", "tag":"package-2021-07-preview", "details":"Schema 'NamedPartitionScheme' has an allOf list with an empty object schema as a parent, removing it."
⚠️ PreCheck/EmptyParentSchemaWarning	"readme":"servicefabricmanagedclusters/resource-manager/readme.md", "tag":"package-2021-07-preview", "details":"Schema 'PartitionInstanceCountScaleMechanism' has an allOf list with an empty object schema as a parent, removing it."
⚠️ PreCheck/EmptyParentSchemaWarning	"readme":"servicefabricmanagedclusters/resource-manager/readme.md", "tag":"package-2021-07-preview", "details":"Schema 'ServicePlacementInvalidDomainPolicy' has an allOf list with an empty object schema as a parent, removing it."
⚠️ PreCheck/EmptyParentSchemaWarning	"readme":"servicefabricmanagedclusters/resource-manager/readme.md", "tag":"package-2021-07-preview", "details":"Schema 'ServicePlacementPreferPrimaryDomainPolicy' has an allOf list with an empty object schema as a parent, removing it."
⚠️ PreCheck/EmptyParentSchemaWarning	"readme":"servicefabricmanagedclusters/resource-manager/readme.md", "tag":"package-2021-07-preview", "details":"Schema 'ServicePlacementRequiredDomainPolicy' has an allOf list with an empty object schema as a parent, removing it."
⚠️ PreCheck/EmptyParentSchemaWarning	"readme":"servicefabricmanagedclusters/resource-manager/readme.md", "tag":"package-2021-07-preview", "details":"Schema 'ServicePlacementRequireDomainDistributionPolicy' has an allOf list with an empty object schema as a parent, removing it."
⚠️ PreCheck/EmptyParentSchemaWarning	"readme":"servicefabricmanagedclusters/resource-manager/readme.md", "tag":"package-2021-07-preview", "details":"Schema 'UniformInt64RangePartitionScheme' has an allOf list with an empty object schema as a parent, removing it."
⚠️ PreCheck/EmptyParentSchemaWarning	"readme":"servicefabricmanagedclusters/resource-manager/readme.md", "tag":"package-2021-07-preview", "details":"Schema 'ManagedCluster' has an allOf list with an empty object schema as a parent, removing it."
⚠️ PreCheck/EmptyParentSchemaWarning	"readme":"servicefabricmanagedclusters/resource-manager/readme.md", "tag":"package-2021-05", "details":"Schema 'AddRemoveIncrementalNamedPartitionScalingMechanism' has an allOf list with an empty object schema as a parent, removing it."
⚠️ PreCheck/EmptyParentSchemaWarning	"readme":"servicefabricmanagedclusters/resource-manager/readme.md", "tag":"package-2021-05", "details":"Schema 'AveragePartitionLoadScalingTrigger' has an allOf list with an empty object schema as a parent, removing it."
⚠️ PreCheck/EmptyParentSchemaWarning	"readme":"servicefabricmanagedclusters/resource-manager/readme.md", "tag":"package-2021-05", "details":"Schema 'AverageServiceLoadScalingTrigger' has an allOf list with an empty object schema as a parent, removing it."
⚠️ PreCheck/EmptyParentSchemaWarning	"readme":"servicefabricmanagedclusters/resource-manager/readme.md", "tag":"package-2021-05", "details":"Schema 'NamedPartitionScheme' has an allOf list with an empty object schema as a parent, removing it."
⚠️ PreCheck/EmptyParentSchemaWarning	"readme":"servicefabricmanagedclusters/resource-manager/readme.md", "tag":"package-2021-05", "details":"Schema 'PartitionInstanceCountScaleMechanism' has an allOf list with an empty object schema as a parent, removing it."
⚠️ PreCheck/EmptyParentSchemaWarning	"readme":"servicefabricmanagedclusters/resource-manager/readme.md", "tag":"package-2021-05", "details":"Schema 'ServicePlacementInvalidDomainPolicy' has an allOf list with an empty object schema as a parent, removing it."
⚠️ PreCheck/EmptyParentSchemaWarning	"readme":"servicefabricmanagedclusters/resource-manager/readme.md", "tag":"package-2021-05", "details":"Schema 'ServicePlacementPreferPrimaryDomainPolicy' has an allOf list with an empty object schema as a parent, removing it."
⚠️ PreCheck/EmptyParentSchemaWarning	"readme":"servicefabricmanagedclusters/resource-manager/readme.md", "tag":"package-2021-05", "details":"Schema 'ServicePlacementRequiredDomainPolicy' has an allOf list with an empty object schema as a parent, removing it."
⚠️ PreCheck/EmptyParentSchemaWarning	"readme":"servicefabricmanagedclusters/resource-manager/readme.md", "tag":"package-2021-05", "details":"Schema 'ServicePlacementRequireDomainDistributionPolicy' has an allOf list with an empty object schema as a parent, removing it."
⚠️ PreCheck/EmptyParentSchemaWarning	"readme":"servicefabricmanagedclusters/resource-manager/readme.md", "tag":"package-2021-05", "details":"Schema 'UniformInt64RangePartitionScheme' has an allOf list with an empty object schema as a parent, removing it."
⚠️ PreCheck/EmptyParentSchemaWarning	"readme":"servicefabricmanagedclusters/resource-manager/readme.md", "tag":"package-2021-05", "details":"Schema 'ManagedCluster' has an allOf list with an empty object schema as a parent, removing it."

️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2021-08-27T19:54:37Z

Swagger Generation Artifacts

️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️️✔️[Staging] SDK Breaking Change Tracking succeeded [Detail] [Expand]

Breaking Changes Tracking

️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-servicefabricmanagedclusters - 1.0.0

️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from 29f316e6748f60a1cf9712370883e79f5f546f6c. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-5.0
command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/servicefabricmanagedclusters/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.ServiceFabricManagedClusters [View full logs] [Preview SDK Changes]
- Microsoft.Azure.Management.ServiceFabricManagedClusters.1.0.0.nupkg
- Microsoft.Azure.Management.ServiceFabricManagedClusters.1.0.0.symbols.nupkg

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs] Generate from 29f316e6748f60a1cf9712370883e79f5f546f6c. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json

️✔️track2_azure-mgmt-servicefabricmanagedclusters [View full logs] [Preview SDK Changes] Breaking Change Detected

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Model ManagedCluster has a new parameter subnet_id
info	[Changelog]   - Model ManagedCluster has a new parameter ip_tags
info	[Changelog]   - Model ManagedCluster has a new parameter enable_ipv6
info	[Changelog]   - Model NodeType has a new parameter frontend_configurations
info	[Changelog]   - Model NodeType has a new parameter sku
info	[Changelog]   - Model NodeType has a new parameter network_security_rules
info	[Changelog]   - Added operation group NodeTypeSkusOperations
info	[Changelog]
info	[Changelog] **Breaking changes**
info	[Changelog]
info	[Changelog]   - Model NodeTypeUpdateParameters has a new signature

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs] Generate from 29f316e6748f60a1cf9712370883e79f5f546f6c. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json

️✔️servicefabricmanagedclusters [View full logs] [Preview Schema Changes]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2021-08-27T19:56:41Z

Hi, @a-santamaria your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com).

openapi-workflow-bot · 2021-08-27T19:56:50Z

Hi @a-santamaria, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff.

Task	How to fix	Priority	Support (Microsoft alias)
Avocado	Fix-Avocado	High	ruowan
Semantic validation	Fix-SemanticValidation-Error	High	raychen, jianyxi
Model validation	Fix-ModelValidation-Error	High	raychen,jianyxi
LintDiff	Fix-LintDiff	high	jianyxi, ruoxuan

If you need further help, please feedback via swagger feedback."

openapi-workflow-bot · 2021-08-27T20:13:47Z

Hi @a-santamaria, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
If you want to know the production traffic statistic, please see ARM Traffic statistic.
If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.

a-santamaria · 2021-08-27T20:21:22Z

Initially, there was a lintDiff issue PathResourceProviderMatchNamespace To fix it I renamed the folder to be the same as the resource provider (Microsoft.ServiceFabric) all the breaking changes shown now are due to that folder name change

RamyasreeChakka · 2021-09-03T19:29:08Z

...source-manager/Microsoft.ServiceFabric/preview/2021-09-01-privatepreview/managedcluster.json

+        }
+      }
+    },
+    "/subscriptions/{subscriptionId}/providers/Microsoft.ServiceFabric/locations/{location}/managedUnsupportedVMSizes": {


@a-santamaria I diffed your 1st & 2nd iteration, I see this is the API that got added in new version. This API is GET collection API. You need to add GET individual resource too.
Any resource type MUST implement GET for collection and single resource regardless if it's a singleton or not.
For example GET /subscriptions/{subscriptionId}/providers/Microsoft.ServiceFabric/locations/{location}/managedUnsupportedVMSizes/{vmSize}

Please refer best practice 'Inconsistent or incomplete CRUD' here https://armwiki.azurewebsites.net/rp_onboarding/process/api_review_best_practices.html

@RamyasreeChakka added the new path. Please take a look again

@a-santamaria - Signed off from ARM side. Please work with your PR assignee to merge the PR.

RamyasreeChakka

a-santamaria · 2021-09-07T19:55:54Z

@ruowan the pr is signed off by arm can you merge it please?

a-santamaria · 2021-09-22T16:34:19Z

merged here #16049

Alfredo Santamaria Gomez added 4 commits August 27, 2021 12:42

first commit 2021-09-01-privatepreview copied from 2021-07-01-preview

ebd567f

update models

41f41ec

update samples

fe5116c

add api to readme

9a777e2

openapi-assignment-bot bot assigned ruowan Aug 27, 2021

openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 27, 2021

openapi-pipeline-app bot added the CI-FixRequiredOnFailure label Aug 27, 2021

openapi-sdkautomation bot mentioned this pull request Aug 27, 2021

[AutoPR track2_azure-mgmt-servicefabricmanagedclusters] Service Fabric Managed Clusters - 2021 09 01 privatepreview AzureSDKAutomation/azure-sdk-for-python#7137

Draft

openapi-pipeline-app bot added the CI-BreakingChange-Python-Track2 label Aug 27, 2021

openapi-sdkautomation bot mentioned this pull request Aug 27, 2021

[AutoPR Microsoft.Azure.Management.ServiceFabricManagedClusters] Service Fabric Managed Clusters - 2021 09 01 privatepreview AzureSDKAutomation/azure-sdk-for-net#5723

Draft

rename folder to match resource provider name Microsoft.ServiceFabric

0f607a5

openapi-pipeline-app bot added the BreakingChangeReviewRequired label Aug 27, 2021

openapi-pipeline-app bot removed the CI-FixRequiredOnFailure label Aug 27, 2021

openapi-sdkautomation bot mentioned this pull request Aug 27, 2021

[AutoPR servicefabricmanagedclusters] Service Fabric Managed Clusters - 2021 09 01 privatepreview AzureSDKAutomation/azure-resource-manager-schemas#4588

Draft

RamyasreeChakka reviewed Sep 3, 2021

View reviewed changes

RamyasreeChakka added the ARMChangesRequested label Sep 3, 2021

vmsize list get

4545ba6

RamyasreeChakka approved these changes Sep 7, 2021

View reviewed changes

RamyasreeChakka added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Sep 7, 2021

ruowan added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Sep 10, 2021

a-santamaria closed this Sep 22, 2021

Conversation

a-santamaria commented Aug 27, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

Uh oh!

openapi-workflow-bot bot commented Aug 27, 2021

Uh oh!

openapi-workflow-bot bot commented Aug 27, 2021

Uh oh!

openapi-pipeline-app bot commented Aug 27, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Swagger Validation Report

Uh oh!

openapi-pipeline-app bot commented Aug 27, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Swagger Generation Artifacts

Breaking Changes Tracking

Uh oh!

openapi-workflow-bot bot commented Aug 27, 2021

Uh oh!

openapi-workflow-bot bot commented Aug 27, 2021

Uh oh!

openapi-workflow-bot bot commented Aug 27, 2021

Uh oh!

a-santamaria commented Aug 27, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

RamyasreeChakka Sep 3, 2021

Choose a reason for hiding this comment

Uh oh!

a-santamaria Sep 7, 2021

Choose a reason for hiding this comment

Uh oh!

RamyasreeChakka Sep 7, 2021

Choose a reason for hiding this comment

Uh oh!

RamyasreeChakka left a comment

Choose a reason for hiding this comment

Uh oh!

a-santamaria commented Sep 7, 2021

Uh oh!

a-santamaria commented Sep 22, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Comments

a-santamaria commented Aug 27, 2021 •

edited

Loading

openapi-pipeline-app bot commented Aug 27, 2021 •

edited

Loading

openapi-pipeline-app bot commented Aug 27, 2021 •

edited

Loading

a-santamaria commented Aug 27, 2021 •

edited

Loading