Skip to content
Merged
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -307,6 +307,51 @@
}
}
},
"/subscriptions/{subscriptionId}/providers/Microsoft.Web/verifyHostingEnvironmentVnet": {
"post": {
"summary": "Verifies if this VNET is compatible with an App Service Environment.",
"description": "Verifies if this VNET is compatible with an App Service Environment.",
"operationId": "VerifyHostingEnvironmentVnet",
"consumes": [
"application/json",
"text/json",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does your service support all of these types? AFAIK, ARM recommends only "allpication/json".

"application/xml",
"text/xml",
"application/x-www-form-urlencoded"
],
"produces": [
"application/json",
"text/json",
"application/xml",
"text/xml"
],

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hforeste still the same question, does your service support all of the content types (text/json, application/xml)? If supported content type are the same, could you place them to the top level of the swagger?
@ravbhatnagar are you ok with these content types?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sergey-shandar , our tooling automatically adds these content types. We're planning to fix this here in the near future.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hforeste Excellent! Do you have a ticket for this issue so we can track it?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll have to check with @naveedaz, not sure where this work item might be tracked. Navy, do you have a work item tracked for this?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hforeste - ARM does not support content types other than application/json. So, please remove them. Even though these are generated by a tool, will it be a problem if you manually fix these?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it should not be a problem. Thanks!

"parameters": [
{
"name": "parameters",
"in": "body",
"description": "VNET information",
"required": true,
"schema": {
"$ref": "#/definitions/VnetParameters"
}
},
{
"$ref": "#/parameters/subscriptionIdParameter"
},
{
"$ref": "#/parameters/apiVersionParameter"
}
],
"responses": {
"200": {
"description": "OK",
"schema": {
"$ref": "#/definitions/VnetValidationFailureDetails"
}
}
}
}
},
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/moveResources": {
"post": {
"summary": "Move resources between resource groups.",
Expand Down Expand Up @@ -967,6 +1012,84 @@
"type": "string"
}
}
},
"VnetParameters": {
"description": "The required set of inputs to validate a VNET",
"type": "object",
"allOf": [
{
"$ref": "#/definitions/ProxyOnlyResource"
}
],
"properties": {
"properties": {
"description": "VnetParameters resource specific properties",
"properties": {
"vnetResourceGroup": {
"description": "The Resource Group of the VNET to be validated",
"type": "string"
},
"vnetName": {
"description": "The name of the VNET to be validated",
"type": "string"
},
"vnetSubnetName": {
"description": "The subnet name to be validated",
"type": "string"
}
},
"x-ms-client-flatten": true
}
}
},
"VnetValidationFailureDetails": {
"description": "A class that describes the reason for a validation failure.",
"type": "object",
"allOf": [
{
"$ref": "#/definitions/ProxyOnlyResource"
}
],
"properties": {
"properties": {
"description": "VnetValidationFailureDetails resource specific properties",
"properties": {
"failed": {

@sergey-shandar sergey-shandar Aug 24, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Could you add description to the property?

"type": "boolean"
},
"failedTests": {
"type": "array",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here: description

"items": {
"$ref": "#/definitions/VnetValidationTestFailure"
}
}
},
"x-ms-client-flatten": true
}
}
},
"VnetValidationTestFailure": {
"description": "A class that describes a test that failed during NSG and UDR validation.",
"type": "object",
"allOf": [
{
"$ref": "#/definitions/ProxyOnlyResource"
}
],
"properties": {
"properties": {
"description": "VnetValidationTestFailure resource specific properties",
"properties": {
"testName": {
"type": "string"
},
"details": {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here, 'description'

"type": "string"
}
},
"x-ms-client-flatten": true
}
}
}
},
"parameters": {
Expand Down Expand Up @@ -1014,4 +1137,4 @@
]
}
]
}
}