Skip to content

[Travis CI] Bug Fix when linter runs on json file without being included in tag #1560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vishrutshah merged 1 commit into from
Aug 18, 2017
Merged

[Travis CI] Bug Fix when linter runs on json file without being included in tag #1560

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions test/linter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,10 +109,10 @@ describe('AutoRest Linter validation:', function () {
// but in the same directory tree as the config file
const filesChangedInPR = utils.getFilesChangedInPR();
const configDir = path.dirname(config);
filesChangedInPR.filter(prfile => {
filesChangedInPR.filter(prFile => {
// set any type to string
prFile += '';
return prFile.startsWith(configDir) && prfile.indexOf('examples') === -1 && prFile.endsWith('.json');
return prFile.startsWith(configDir) && prFile.indexOf('examples') === -1 && prFile.endsWith('.json');
Copy link
Copy Markdown
Contributor

@dsgouda dsgouda Aug 18, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This made me sad 😞

Copy link
Copy Markdown
Contributor Author

@vishrutshah vishrutshah Aug 18, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries... we fixed it :)

}).forEach(prFileInConfigFile => {
console.warn(`Configuration file not found for file: ${prFileInConfigFile}, running validation rules against it in individual context.`);
execLinterCommand(`--input-file=${prFileInConfigFile}`);
Expand Down