Expose new API to download pre-generated vpn profile package URL by ritwikbasu · Pull Request #1557 · Azure/azure-rest-api-specs

ritwikbasu · 2017-08-17T19:06:25Z

Expose new API to download pre-generated vpn profile package URL

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

Expose new API to download pre-generated vpn profile package URL

azuresdkciprbot · 2017-08-17T19:19:20Z

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/network/resource-manager/readme.md
Before the PR: Warning(s): 151 Error(s): 84
After the PR: Warning(s): 151 Error(s): 84

AutoRest Linter Guidelines | AutoRest Linter Issues

Send feedback and make AutoRest Linter Azure Bot smarter day by day!

Thanks for your co-operation.

olydis · 2017-08-21T15:28:39Z

@ravbhatnagar New operation.

ritwikbasu · 2017-08-21T19:25:36Z

@ravbhatnagar - Can you please approve this PR or let me know if you have any concerns? This is one of our Ignite deliverables and we need this change to go in before proceeding with SDK/PS coding.

ravbhatnagar · 2017-08-22T08:06:52Z

@ritwikbasu - this API wont work. Please schedule a 15 min sync with me on Wednesday to go over why.

Incorporate review comments

azuresdkciprbot · 2017-08-23T23:21:55Z

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/network/resource-manager/readme.md
Before the PR: Warning(s): 151 Error(s): 84
After the PR: Warning(s): 151 Error(s): 84

AutoRest Linter Guidelines | AutoRest Linter Issues

Send feedback and make AutoRest Linter Azure Bot smarter day by day!

Thanks for your co-operation.

ravbhatnagar · 2017-08-25T18:36:13Z

specification/network/resource-manager/Microsoft.Network/2017-08-01/virtualNetworkGateway.json

+            "$ref": "#/parameters/SubscriptionIdParameter"
+          }
+        ],
+        "responses": {


Please define the model for the response instead of just marking it as string. Since the change has already gone in on the service side, please consider it in the next api version rev. Not blocking on it for now.

ravbhatnagar

Just the one note that i added which NRP will consider fixing in the next api-version rev.

ravbhatnagar · 2017-08-25T18:37:05Z

@olydis - ARM signed off.

AutorestCI · 2017-08-25T18:42:02Z

No modification for AutorestCI/azure-sdk-for-node

AutorestCI · 2017-08-25T18:42:56Z

Azure/azure-sdk-for-ruby#926

AutorestCI · 2017-08-25T18:45:12Z

Azure/azure-sdk-for-python#1394

* Update Datadog swagger * Add liftr resource * Remove some description

Expose new API to download pre-generated vpn profile package URL

3a67e02

Expose new API to download pre-generated vpn profile package URL

msftclas added the cla-not-required label Aug 17, 2017

azuresdkci assigned fearthecowboy Aug 17, 2017

salameer added the Reassign label Aug 18, 2017

salameer unassigned fearthecowboy Aug 18, 2017

azuresdkci removed the Reassign label Aug 18, 2017

azuresdkci assigned olydis Aug 18, 2017

olydis added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 21, 2017

Incorporate review comments

8be102e

Incorporate review comments

ravbhatnagar reviewed Aug 25, 2017

View reviewed changes

ravbhatnagar approved these changes Aug 25, 2017

View reviewed changes

ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Aug 25, 2017

olydis approved these changes Aug 25, 2017

View reviewed changes

olydis merged commit 4c93570 into Azure:current Aug 25, 2017

AutorestCI mentioned this pull request Aug 25, 2017

Automatic PR from RestAPI-PR1557 Azure/azure-sdk-for-ruby#926

Merged

AutorestCI mentioned this pull request Aug 25, 2017

Automatic PR from RestAPI-PR1557 Azure/azure-sdk-for-python#1394

Closed

ritwikbasu mentioned this pull request Sep 6, 2017

Expose new api to generate Vpn profiles for external radius based aut… Azure/azure-sdk-for-net#3662

Merged

8 tasks

lmazuel mentioned this pull request Sep 7, 2017

Typo in Network: VirtualNetworkGateways_GetVpnProfilePacakgeUrl #1644

Closed

mccleanp pushed a commit that referenced this pull request Mar 23, 2022

Update Datadog swagger (#1557)

84600e3

* Update Datadog swagger * Add liftr resource * Remove some description

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Expose new API to download pre-generated vpn profile package URL#1557

Expose new API to download pre-generated vpn profile package URL#1557
olydis merged 2 commits intoAzure:currentfrom
ritwikbasu:current

ritwikbasu commented Aug 17, 2017 •

edited by azuresdkci

Loading

Uh oh!

azuresdkciprbot commented Aug 17, 2017

Uh oh!

olydis commented Aug 21, 2017

Uh oh!

ritwikbasu commented Aug 21, 2017

Uh oh!

ravbhatnagar commented Aug 22, 2017

Uh oh!

azuresdkciprbot commented Aug 23, 2017

Uh oh!

ravbhatnagar Aug 25, 2017

Uh oh!

ravbhatnagar left a comment

Uh oh!

ravbhatnagar commented Aug 25, 2017

Uh oh!

AutorestCI commented Aug 25, 2017

Uh oh!

AutorestCI commented Aug 25, 2017

Uh oh!

AutorestCI commented Aug 25, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

Conversation

ritwikbasu commented Aug 17, 2017 • edited by azuresdkci Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR information

Quality of Swagger

Uh oh!

azuresdkciprbot commented Aug 17, 2017

Uh oh!

olydis commented Aug 21, 2017

Uh oh!

ritwikbasu commented Aug 21, 2017

Uh oh!

ravbhatnagar commented Aug 22, 2017

Uh oh!

azuresdkciprbot commented Aug 23, 2017

Uh oh!

ravbhatnagar Aug 25, 2017

Choose a reason for hiding this comment

Uh oh!

ravbhatnagar left a comment

Choose a reason for hiding this comment

Uh oh!

ravbhatnagar commented Aug 25, 2017

Uh oh!

AutorestCI commented Aug 25, 2017

Uh oh!

AutorestCI commented Aug 25, 2017

Uh oh!

AutorestCI commented Aug 25, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

ritwikbasu commented Aug 17, 2017 •

edited by azuresdkci

Loading