Skip to content

Updated new Property for SparkConfig Properties in Spark Compute #15474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ruowan merged 2 commits into from
Aug 6, 2021
Merged

Updated new Property for SparkConfig Properties in Spark Compute #15474

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ecb4663
Updated new Property for SparkConfig Properties in Spark Compute
Bharath550-ms Aug 2, 2021
1ec3c39
Updated property name
Bharath550-ms Aug 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 34 additions & 1 deletion ...on/synapse/resource-manager/Microsoft.Synapse/preview/2021-06-01-preview/bigDataPool.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -450,7 +450,7 @@
}
},
"sparkConfigProperties": {
"$ref": "#/definitions/LibraryRequirements",
"$ref": "#/definitions/SparkConfigProperties",
"description": "Spark configuration file to specify additional properties"
},
"sparkVersion": {
Expand Down Expand Up @@ -606,6 +606,39 @@
"description": "The filename of the library requirements file."
}
}
},
"SparkConfigProperties": {
"type": "object",
"description": "SparkConfig Properties for a Big Data pool powered by Apache Spark",
"title": "Spark pool Config Properties",
"properties": {
"time": {
"type": "string",
"format": "date-time",
"readOnly": true,
"description": "The last update time of the spark config properties file."
},
"content": {
"type": "string",
"description": "The spark config properties."
},
"filename": {
"type": "string",
"description": "The filename of the spark config properties file."
},
"type": {
"enum": [
"File",
"Artifact"
],
"type": "string",
"description": "The type of the spark config properties file.",
"x-ms-enum": {
"name": "type",
Copy link
Contributor

@idear1203 idear1203 Aug 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. If this is really an enum, please list all possible values here.
  2. We cannot use "type" as enum name, can we use something like "SparkConfigPropertyFileType" instead?

Copy link
Contributor Author

@Bharath550-ms Bharath550-ms Aug 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the property name as suggested

"modelAsString": true
}
}
}
}
}
}