Skip to content

Update Analysis Services Autorest config (ReadMe.md) to include version 2017-08-01-beta#1542

Closed
michael-falk wants to merge 1 commit intoAzure:currentfrom
michael-falk:patch-1
Closed

Update Analysis Services Autorest config (ReadMe.md) to include version 2017-08-01-beta#1542
michael-falk wants to merge 1 commit intoAzure:currentfrom
michael-falk:patch-1

Conversation

@michael-falk
Copy link
Copy Markdown

@michael-falk michael-falk commented Aug 14, 2017

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@msftclas
Copy link
Copy Markdown

@michael-falk,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@michael-falk
Copy link
Copy Markdown
Author

The CI build fails for a file I did not change...

@msftclas
Copy link
Copy Markdown

@michael-falk,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@azuresdkciprbot
Copy link
Copy Markdown

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/analysisservices/resource-manager/readme.md
Before the PR: Warning(s): 3 Error(s): 9
After the PR: Warning(s): 3 Error(s): 9

AutoRest Linter Guidelines | AutoRest Linter Issues

Send feedback and make AutoRest Linter Azure Bot smarter day by day!

Thanks for your co-operation.

@taiwu
Copy link
Copy Markdown
Contributor

taiwu commented Aug 15, 2017

covered #1526

@azuresdkciprbot
Copy link
Copy Markdown

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/analysisservices/resource-manager/readme.md
Before the PR: Warning(s): 3 Error(s): 9
After the PR: Warning(s): 3 Error(s): 9

AutoRest Linter Guidelines | AutoRest Linter Issues

Send feedback and make AutoRest Linter Azure Bot smarter day by day!

Thanks for your co-operation.

Copy link
Copy Markdown
Contributor

@veronicagg veronicagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one question, which once confirmed, I can approve and merge.
Sorry it took me a while, I had to fix CI (per the unrelated error you were seeing).
Thanks!

``` yaml
openapi-type: arm
tag: package-2016-05
tag: package-2017-08
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michael-falk is the beta spec expected to be your new default package? Just asking since I saw this update.

@veronicagg
Copy link
Copy Markdown
Contributor

Closing per conversation with @taiwu , who indicated this change is included in the linked PR. thanks!

@veronicagg veronicagg closed this Aug 16, 2017
@michael-falk michael-falk deleted the patch-1 branch August 16, 2017 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants