Skip to content

support track2 js codegen#15149

Merged
akning-ms merged 3 commits intomasterfrom
dw/support-track2-js-codegen
Jul 13, 2021
Merged

support track2 js codegen#15149
akning-ms merged 3 commits intomasterfrom
dw/support-track2-js-codegen

Conversation

@dw511214992
Copy link
Member

@dw511214992 dw511214992 commented Jul 12, 2021

I will cancel the sdkAutomation pipelines because this PR changes readme.md of all RPs.

Also, the azure-sdk-for-python-track2 pipeline fails in some RP because the track2 JS sdk codegen is still in preview. We will discuss about whether enable track2 js codegen for all RPs now.

@openapi-workflow-bot
Copy link

Hi, @dw511214992 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    This was referenced Jul 12, 2021
    @dw511214992
    Copy link
    Member Author

    After discussion, we will not enable track2 js codegen for all RPs now. So this PR only includes the change of specificationRepositoryConfiguration.json.

    @PhoenixHe-msft could you please help merge this PR? I don't have the permission to merge it. thanks.

    @PhoenixHe-NV PhoenixHe-NV added Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 and removed Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 labels Jul 12, 2021
    @akning-ms akning-ms merged commit 67a9b5c into master Jul 13, 2021
    @JackTn JackTn deleted the dw/support-track2-js-codegen branch June 16, 2022 00:49
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    3 participants