Skip to content

Conversation

@dw511214992
Copy link
Member

We will release track1 JS sdk in branch feature/v4.

@openapi-workflow-bot
Copy link

Hi, @dw511214992 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jul 1, 2021

    Swagger Validation Report

    ️❌BreakingChange: 1 Errors, 0 Warnings failed [Detail]
    Rule Message
    Runtime Exception "new":"https://github.com/Azure/azure-rest-api-specs/blob/4166d1ada38a739e0f3bee4124e121a82f92439c/specificationRepositoryConfiguration.json",
    "old":"https://github.com/Azure/azure-rest-api-specs/blob/master/specificationRepositoryConfiguration.json",
    "details":"Command failed: node /home/vsts/work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/@azure/[email protected]/node_modules/autorest/dist/app.js --input-file=/home/vsts/work/1/c93b354fd9c14905bb574a8834c4d69b/specificationRepositoryConfiguration.json --output-artifact=swagger-document.json --output-artifact=swagger-document.map --output-file=old --output-folder=/tmp\nFATAL: swagger-document/loader - FAILED\nFATAL: Error: File 'file:///home/vsts/work/1/c93b354fd9c14905bb574a8834c4d69b/specificationRepositoryConfiguration.json' is not a valid OpenAPI 2.0 definition (expected 'swagger: 2.0')\n Error: File 'file:///home/vsts/work/1/c93b354fd9c14905bb574a8834c4d69b/specificationRepositoryConfiguration.json' is not a valid OpenAPI 2.0 definition (expected 'swagger: 2.0')\n"
    ️️✔️LintDiff succeeded [Detail] [Expand]
    Validation passes for LintDiff.
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand]
    Validation passes for SDKTrack2Validation
    ️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jul 1, 2021

    Swagger pipeline restarted successfully, please wait for status update in this comment.

    @PhoenixHe-NV PhoenixHe-NV added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Jul 2, 2021
    @PhoenixHe-NV PhoenixHe-NV merged commit 14ce29c into master Jul 2, 2021
    @JackTn JackTn deleted the dw/change-target-branch-in-js-pipeline branch June 16, 2022 00:49
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    4 participants