Catching up with missing commits (not moved to the new branch), Fixing issue #1475: incorrect example in LogProfiles API documentation for CreateOrUpdate, fixing incorrect logProfiles example names. by gucalder · Pull Request #1481 · Azure/azure-rest-api-specs

gucalder · 2017-07-27T20:11:29Z

Catching up with missing commits (not moved to the new branch), Fixing issue #1475: incorrect example in LogProfiles API documentation for CreateOrUpdate, fixing incorrect logProfiles example names.

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

…ng issue Azure#1475: incorrect example in LogProfiles API documentation for CreateOrUpdate, fixing incorrect logProfiles example names.

gucalder · 2017-07-27T20:12:27Z

Retry of closed PR #1476.

vishrutshah

@gucalder Change looks good but I noticed that there was already existing error in of the swagger. It'd great if we can address it in this PR itself. Thanks!

vishrutshah · 2017-07-28T22:59:48Z

specification/monitor/resource-manager/microsoft.insights/2016-03-01/logProfiles_API.json

        },
        "x-ms-examples": {
-            "List alert rules": { "$ref": "./examples/deleteLogProfile.json" }
+            "Delete log profile": { "$ref": "./examples/deleteLogProfile.json" }


seems like this example contains an additional response code that has not been modeled in swagger. Could you please verify?

https://travis-ci.org/Azure/azure-rest-api-specs/jobs/258292847#L657

vishrutshah · 2017-08-02T20:57:02Z

@gucalder ping! Could you please see whether we can fix this as part of this PR. Thanks!

…PI call

… into current

vishrutshah · 2017-08-03T16:26:16Z

@gucalder Thanks for fixing the example. I see that there is still one more invalid example/swagger model for operation LogProfiles_CreateOrUpdate. Could you please have a look?

https://travis-ci.org/Azure/azure-rest-api-specs/jobs/260424100#L663

gucalder · 2017-08-04T00:04:57Z

I do not know how to fix this error reported by Linter: "code": "DefinitionsPropertiesNamesCamelCase",
"message": "Property named: 'odata.type', for definition: 'RuleCondition' must follow camelCase style. Example:
'odata.type'.",

gucalder · 2017-08-04T00:05:47Z

Those are 6 of the 10 errors.

vishrutshah · 2017-08-04T16:19:14Z

@gucalder Looks like the rule should not have triggered when there is a odata int eh property name.

Would you please open an issue at https://github.com/Azure/azure-openapi-validator/issues and link to Azure/autorest#2064 so that we can get it taken care. Thanks!

Secondly, Please also have a look at the build MODE:model PR_ONLY=true here. That build ensures that provided examples are matching the swagger models. Let me know if you need any help. Thanks!

… into current

gucalder · 2017-08-07T16:41:44Z

Issues with the MODE:model PR_ONLY=true fixed. Waiting for the result of the validations.

azuresdkciprbot · 2017-08-07T19:14:34Z

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/monitor/resource-manager/readme.md
Before the PR: Warning(s): 38 Error(s): 10
After the PR: Warning(s): 23 Error(s): 10

AutoRest Linter Guidelines | AutoRest Linter Issues

Send feedback and make AutoRest Linter Azure Bot smarter day by day!

Thanks for your co-operation.

vishrutshah

Thanks for fixing the errors. I left one question for you. Let me know what you think.

vishrutshah · 2017-08-08T18:40:31Z

...n/monitor/resource-manager/microsoft.insights/2016-09-01/serviceDiagnosticsSettings_API.json

            },
            {
-                "name": "serviceDiagnosticSettingsResource",
+                "name": "parameters",


@gucalder May I ask the reason for this change i.e renaming the parameter. Seems like generating new SDK from this swagger would not be backward compatible as parameter name has changed. Can you please provide your thoughts.

That is because I changed the wrong file... I need to change the example file, not the spec file.
I am on this.

…e file.

… into current

azuresdkciprbot · 2017-08-08T20:30:40Z

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/monitor/resource-manager/readme.md
Before the PR: Warning(s): 38 Error(s): 10
After the PR: Warning(s): 23 Error(s): 10

AutoRest Linter Guidelines | AutoRest Linter Issues

Send feedback and make AutoRest Linter Azure Bot smarter day by day!

Thanks for your co-operation.

vishrutshah · 2017-08-08T21:17:50Z

Thanks @gucalder for incorporating the feedback.

AutorestCI · 2017-08-08T21:22:00Z

No modification for AutorestCI/azure-sdk-for-node

AutorestCI · 2017-08-08T21:22:12Z

Azure/azure-sdk-for-ruby#878

AutorestCI · 2017-08-08T21:22:17Z

Azure/azure-sdk-for-python#1353

AutorestCI · 2017-08-08T22:19:13Z

No modification for AutorestCI/azure-sdk-for-ruby

AutorestCI · 2017-08-08T22:19:21Z

No modification for AutorestCI/azure-sdk-for-node

Catching up with missing commits (not moved to the new branch), fFixi…

dae5cba

…ng issue Azure#1475: incorrect example in LogProfiles API documentation for CreateOrUpdate, fixing incorrect logProfiles example names.

msftclas added the cla-not-required label Jul 27, 2017

azuresdkci assigned vishrutshah Jul 27, 2017

gucalder mentioned this pull request Jul 27, 2017

Adding ActivityLogAlerts and ActionGroups API calls, PATCH operations, and the corresponding unit tests Azure/azure-sdk-for-net#3520

Merged

8 tasks

vishrutshah suggested changes Jul 28, 2017

View reviewed changes

gucalder added 2 commits August 2, 2017 17:08

Removing success response code from example for log profiles delete A…

8a339ef

…PI call

Merge branch 'current' of https://github.com/Azure/azure-rest-api-specs…

764f130

… into current

Fixing some warnings and one example

d04983f

gucalder added 2 commits August 7, 2017 09:39

Fixing issues with the examples validation.

ca4db34

Merge branch 'current' of https://github.com/Azure/azure-rest-api-specs…

d596398

… into current

gucalder added 2 commits August 7, 2017 11:32

Fixing one example.

b1bda80

Adding tags and location in the proper place for two examples.

6c48a91

vishrutshah suggested changes Aug 8, 2017

View reviewed changes

gucalder added 2 commits August 8, 2017 12:24

Fixing name change in the body parameter and the corresponding exampl…

3449ce9

…e file.

Merge branch 'current' of https://github.com/Azure/azure-rest-api-specs…

c266d97

… into current

vishrutshah approved these changes Aug 8, 2017

View reviewed changes

vishrutshah added the Monitor Monitor, Monitor Ingestion, Monitor Query label Aug 8, 2017

vishrutshah merged commit d95a4ce into Azure:current Aug 8, 2017

AutorestCI mentioned this pull request Aug 8, 2017

Automatic PR from RestAPI-PR1481 Azure/azure-sdk-for-ruby#878

Closed

AutorestCI mentioned this pull request Aug 8, 2017

[MonitorMgmt] Status code fixes Azure/azure-sdk-for-python#1353

Merged

Conversation

gucalder commented Jul 27, 2017 • edited by azuresdkci Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR information

Quality of Swagger

Uh oh!

gucalder commented Jul 27, 2017

Uh oh!

vishrutshah left a comment

Choose a reason for hiding this comment

Uh oh!

vishrutshah Jul 28, 2017

Choose a reason for hiding this comment

Uh oh!

gucalder Aug 3, 2017

Choose a reason for hiding this comment

Uh oh!

vishrutshah commented Aug 2, 2017

Uh oh!

vishrutshah commented Aug 3, 2017

Uh oh!

gucalder commented Aug 4, 2017

Uh oh!

gucalder commented Aug 4, 2017

Uh oh!

vishrutshah commented Aug 4, 2017

Uh oh!

gucalder commented Aug 7, 2017

Uh oh!

azuresdkciprbot commented Aug 7, 2017

Uh oh!

vishrutshah left a comment

Choose a reason for hiding this comment

Uh oh!

vishrutshah Aug 8, 2017

Choose a reason for hiding this comment

Uh oh!

gucalder Aug 8, 2017

Choose a reason for hiding this comment

Uh oh!

azuresdkciprbot commented Aug 8, 2017

Uh oh!

vishrutshah commented Aug 8, 2017

Uh oh!

AutorestCI commented Aug 8, 2017

Uh oh!

AutorestCI commented Aug 8, 2017

Uh oh!

AutorestCI commented Aug 8, 2017

Uh oh!

AutorestCI commented Aug 8, 2017

Uh oh!

AutorestCI commented Aug 8, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

gucalder commented Jul 27, 2017 •

edited by azuresdkci

Loading