[Network] Added missing paths to LoadBalancer, NetworkInterface and VirtualNetworkGateway by anton-evseev · Pull Request #1468 · Azure/azure-rest-api-specs

anton-evseev · 2017-07-26T12:51:49Z

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

msftclas · 2017-07-26T12:51:54Z

@number213,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

dsgouda

Partial review, will add more comments

dsgouda · 2017-07-27T22:30:55Z

specification/network/resource-manager/Microsoft.Network/2017-06-01/loadBalancer.json

Please mark all nextLink properties as readOnly

dsgouda · 2017-07-27T22:47:42Z

specification/network/resource-manager/Microsoft.Network/2017-06-01/virtualNetworkGateway.json

Is this x-ms-pageable

Yes, updated

dsgouda · 2017-07-27T22:50:08Z

specification/network/resource-manager/Microsoft.Network/2017-06-01/networkInterface.json

nit: is this x-ms-pageable?

Yes, updated

Added missing paths to NetworkInterface Added missing path to VirtualNetworkGateway

…rk's LoadBalancer, NetworkInterface, VirtualNetworkGateway

azuresdkciprbot · 2017-07-28T07:58:14Z

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/network/resource-manager/readme.md
Before the PR: Warning(s): 151 Error(s): 84
After the PR: Warning(s): 148 Error(s): 83

AutoRest Linter Guidelines | AutoRest Linter Issues

Send feedback and make AutoRest Linter Azure Bot smarter day by day!

Thanks for your co-operation.

dsgouda · 2017-07-28T18:16:47Z

specification/network/resource-manager/Microsoft.Network/2017-06-01/virtualNetworkGateway.json

+      "properties": {
+        "id": {
+          "type": "string",
+          "description": "Resource ID."


nit: Resource usually refers to a top level ARM resource, please provide a more detailed description.

dsgouda

Other than the one comment, LGTM
Also, after adding nextLink did you have to regenerate the examples?

anton-evseev · 2017-07-28T19:44:54Z

after adding nextLink did you have to regenerate the examples?

No, I didn't.

azuresdkciprbot · 2017-07-28T19:46:43Z

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/network/resource-manager/readme.md
Before the PR: Warning(s): 151 Error(s): 84
After the PR: Warning(s): 148 Error(s): 83

AutoRest Linter Guidelines | AutoRest Linter Issues

Send feedback and make AutoRest Linter Azure Bot smarter day by day!

Thanks for your co-operation.

dsgouda · 2017-07-28T21:37:12Z

after adding nextLink did you have to regenerate the examples?

No, I didn't.

Might be a good idea but I won't block on this

AutorestCI · 2017-07-28T22:01:37Z

Azure/azure-sdk-for-ruby#868

AutorestCI · 2017-07-28T22:02:42Z

Azure/azure-sdk-for-python#1333

AutorestCI · 2017-07-28T22:03:02Z

No modification for AutorestCI/azure-sdk-for-node

AutorestCI · 2017-07-31T19:19:36Z

Azure/azure-sdk-for-python#1338

msftclas added the cla-already-signed label Jul 26, 2017

azuresdkci assigned dsgouda Jul 26, 2017

anton-evseev force-pushed the lb-update branch from 52f9505 to 91638b9 Compare July 27, 2017 07:39

dsgouda suggested changes Jul 27, 2017

View reviewed changes

Added missing paths to LoadBalancer

d8e1192

Added missing paths to NetworkInterface Added missing path to VirtualNetworkGateway

anton-evseev force-pushed the lb-update branch from 93fca7b to d7f265e Compare July 28, 2017 07:32

Added missing x-ms-pageables and made all nextLinks readOnly in Netwo…

c91064f

…rk's LoadBalancer, NetworkInterface, VirtualNetworkGateway

anton-evseev force-pushed the lb-update branch from d7f265e to c91064f Compare July 28, 2017 07:51

dsgouda reviewed Jul 28, 2017

View reviewed changes

dsgouda suggested changes Jul 28, 2017

View reviewed changes

Addressed PR feedback

7df8e65

dsgouda approved these changes Jul 28, 2017

View reviewed changes

dsgouda merged commit 77075b3 into Azure:current Jul 28, 2017

AutorestCI mentioned this pull request Jul 28, 2017

Automatic PR from RestAPI-PR1468 Azure/azure-sdk-for-ruby#868

Closed

AutorestCI mentioned this pull request Jul 28, 2017

Automatic PR from RestAPI-PR1468 Azure/azure-sdk-for-python#1333

Closed

anton-evseev mentioned this pull request Jul 31, 2017

[Do not merge] Re-generated Azure Network SDK using the latest Swagger Azure/azure-sdk-for-node#2238

Closed

AutorestCI mentioned this pull request Jul 31, 2017

[Network] Added missing paths to LoadBalancer, NetworkInterface and VirtualNetworkGateway Azure/azure-sdk-for-python#1338

Closed

anton-evseev mentioned this pull request Aug 1, 2017

[Network] Reverted gateway references in VPN Gateway Connection #1493

Merged

10 tasks

shahabhijeet mentioned this pull request Aug 1, 2017

Run dotnet generation and test at CI level #1497

Closed

anton-evseev deleted the lb-update branch August 3, 2017 11:15

lmazuel mentioned this pull request Aug 14, 2017

Python extension should support both LRO and Paging extension in the same operation Azure/autorest#2523

Closed

lmazuel mentioned this pull request Aug 14, 2017

[Network] Somes operations defines both LRO and Paging #1539

Closed

Conversation

anton-evseev commented Jul 26, 2017 • edited by azuresdkci Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR information

Quality of Swagger

Uh oh!

msftclas commented Jul 26, 2017

Uh oh!

dsgouda left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

azuresdkciprbot commented Jul 28, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dsgouda left a comment

Choose a reason for hiding this comment

Uh oh!

anton-evseev commented Jul 28, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

azuresdkciprbot commented Jul 28, 2017

Uh oh!

dsgouda commented Jul 28, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AutorestCI commented Jul 28, 2017

Uh oh!

AutorestCI commented Jul 28, 2017

Uh oh!

AutorestCI commented Jul 28, 2017

Uh oh!

AutorestCI commented Jul 31, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

anton-evseev commented Jul 26, 2017 •

edited by azuresdkci

Loading

anton-evseev commented Jul 28, 2017 •

edited

Loading

dsgouda commented Jul 28, 2017 •

edited

Loading