Skip to content

Fix wrong definition for share ACL and update policy id description #14477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 26, 2021
Merged

Fix wrong definition for share ACL and update policy id description #14477

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ...age/resource-manager/Microsoft.Storage/stable/2021-04-01/examples/FileShareAclsPatch.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@
{
"id": "MTIzNDU2Nzg5MDEyMzQ1Njc4OTAxMjM0NTY3ODkwMTI",
"accessPolicy": {
"start": "2021-04-01T08:49:37.0000000Z",
"expiry": "2021-05-01T08:49:37.0000000Z",
"startTime": "2021-04-01T08:49:37.0000000Z",
"expiryTime": "2021-05-01T08:49:37.0000000Z",
"permission": "rwd"
}
}
Expand All @@ -32,8 +32,8 @@
{
"id": "MTIzNDU2Nzg5MDEyMzQ1Njc4OTAxMjM0NTY3ODkwMTI",
"accessPolicy": {
"start": "2021-04-01T08:49:37.0000000Z",
"expiry": "2021-05-01T08:49:37.0000000Z",
"startTime": "2021-04-01T08:49:37.0000000Z",
"expiryTime": "2021-05-01T08:49:37.0000000Z",
"permission": "rwd"
}
}
Expand Down
4 changes: 2 additions & 2 deletions specification/storage/resource-manager/Microsoft.Storage/stable/2021-04-01/file.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -981,12 +981,12 @@
},
"AccessPolicy": {
"properties": {
"start": {
"startTime": {
Copy link
Member

@blueww blueww May 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The property name change is breaking, and we have already released SDK for the API version.
Please check with ARM review team if we need a new API version to add the change?

"type": "string",
"format": "date-time",
"description": "Start time of the access policy"
},
"expiry": {
"expiryTime": {
"type": "string",
"format": "date-time",
"description": "Expiry time of the access policy"
Expand Down
2 changes: 1 addition & 1 deletion specification/storage/resource-manager/Microsoft.Storage/stable/2021-04-01/storage.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4505,7 +4505,7 @@
"in": "path",
"required": true,
"type": "string",
"description": "The ID of object replication policy or 'default' if the policy ID is unknown.",
"description": "For the destination account, provide the value 'default'. Configure the policy on the destination account first. For the source account, provide the value of the policy ID that is returned when you download the policy that was defined on the destination account. The policy is downloaded as a JSON file.",
"minLength": 1,
"x-ms-parameter-location": "method"
},
Expand Down