Skip to content

[test]Update readme.python.md(do not merge)#14377

Closed
msyyc wants to merge 1 commit intomasterfrom
test-2021-05-12
Closed

[test]Update readme.python.md(do not merge)#14377
msyyc wants to merge 1 commit intomasterfrom
test-2021-05-12

Conversation

@msyyc
Copy link
Copy Markdown
Member

@msyyc msyyc commented May 12, 2021

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
  3. When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
  4. If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No, no need to refresh for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently.
    • Adding a new service
  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@msyyc msyyc requested review from 00Kai0, RAY-316 and jsntcy as code owners May 12, 2021 08:11
@msyyc msyyc self-assigned this May 12, 2021
@msyyc msyyc requested a review from zhangyan133 as a code owner May 12, 2021 08:11
@openapi-workflow-bot
Copy link
Copy Markdown

Hi, @msyyc Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-pipeline-app
    Copy link
    Copy Markdown

    openapi-pipeline-app bot commented May 12, 2021

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️LintDiff succeeded [Detail] [Expand]
    Validation passes for LintDiff.
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand]
    Validation passes for SDKTrack2Validation
    ️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link
    Copy Markdown

    openapi-pipeline-app bot commented May 12, 2021

    Swagger Generation Artifacts

    ️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]
    ️️✔️[Staging] SDK Breaking Change Tracking succeeded [Detail] [Expand]

    Breaking Changes Tracking

    ️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from 2f4a6ac1ca78e0944945f91cbddc07cbe7484773. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	sudo apt-get install -y dotnet-sdk-5.0
      command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/datadog/resource-manager/readme.md
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
    • ️✔️Microsoft.Azure.Management.Datadog [View full logs]  [Preview SDK Changes]
    ️❌ azure-sdk-for-python-track2 failed [Detail]
    • Failed [Logs] Generate from 2f4a6ac1ca78e0944945f91cbddc07cbe7484773. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmdout	[automation_generate.sh] [Autorest]/home/vsts/work/1/s/azure-sdk-for-python_tmp/venv-sdk/auto_temp.json does not exist!!!Error happened during codegen
      error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-python]: sh scripts/automation_generate.sh
      warn	Skip package processing as generation is failed
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs] Generate from 2f4a6ac1ca78e0944945f91cbddc07cbe7484773. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
      cmderr	[generate.py] 2021-05-12 08:17:54 INFO [VERSION][Found] current version "com.azure.resourcemanager:azure-resourcemanager-datadog;1.0.0-beta.2;1.0.0-beta.3"
      cmderr	[generate.py] 2021-05-12 08:17:54 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.3"
      cmderr	[generate.py] 2021-05-12 08:17:54 INFO autorest --version=3.1.3 --use=@autorest/java@4.0.27 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/datadog/azure-resourcemanager-datadog --java.namespace=com.azure.resourcemanager.datadog   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/datadog/resource-manager/readme.md
      cmderr	[generate.py] 2021-05-12 08:18:26 INFO [CI][Skip] ci.yml already has module azure-resourcemanager-datadog
      cmderr	[generate.py] 2021-05-12 08:18:26 INFO [POM][Process] dealing with pom.xml
      cmderr	[generate.py] 2021-05-12 08:18:26 INFO [POM][Skip] pom already has module azure-resourcemanager-datadog
      cmderr	[generate.py] 2021-05-12 08:18:26 INFO [POM][Success] Write to pom.xml
      cmderr	[generate.py] 2021-05-12 08:18:26 INFO [POM][Process] dealing with root pom
      cmderr	[generate.py] 2021-05-12 08:18:26 INFO [POM][Skip] pom already has module sdk/datadog
      cmderr	[generate.py] 2021-05-12 08:18:26 INFO [POM][Success] Write to root pom
    • ️✔️azure-resourcemanager-datadog [View full logs]  [Preview SDK Changes]
      cmderr	[Inst] 2021-05-12 08:21:57 DEBUG Got artifact_id: azure-resourcemanager-datadog
      cmderr	[Inst] 2021-05-12 08:21:57 DEBUG Got artifact: pom.xml
      cmderr	[Inst] 2021-05-12 08:21:57 DEBUG Got artifact: azure-resourcemanager-datadog-1.0.0-beta.3-sources.jar
      cmderr	[Inst] 2021-05-12 08:21:57 DEBUG Got artifact: azure-resourcemanager-datadog-1.0.0-beta.3-javadoc.jar
      cmderr	[Inst] 2021-05-12 08:21:57 DEBUG Got artifact: azure-resourcemanager-datadog-1.0.0-beta.3.jar
      cmderr	[Inst] 2021-05-12 08:21:57 DEBUG Match jar package: azure-resourcemanager-datadog-1.0.0-beta.3.jar
      cmderr	[Inst] 2021-05-12 08:21:57 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/14377/azure-sdk-for-java/azure-resourcemanager-datadog/azure-resourcemanager-datadog-1.0.0-beta.3.jar\" -o azure-resourcemanager-datadog-1.0.0-beta.3.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-datadog -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-datadog-1.0.0-beta.3.jar -Dpackaging=jar -DgeneratePom=true
      ```"}
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from 2f4a6ac1ca78e0944945f91cbddc07cbe7484773. SDK Automation 14.0.0
      command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️datadog/mgmt/2021-03-01/datadog [View full logs]  [Preview SDK Changes]
      info	[Changelog] No exported changes
    • ️✔️preview/datadog/mgmt/2020-02-01-preview/datadog [View full logs]  [Preview SDK Changes]
      info	[Changelog] No exported changes
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from 2f4a6ac1ca78e0944945f91cbddc07cbe7484773. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.4.4 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/datadog/resource-manager/readme.md
    • ️✔️@azure/arm-datadog [View full logs]  [Preview SDK Changes]
      cmderr	[npmPack] loaded rollup.config.js with warnings
      cmderr	[npmPack] (!) Unused external imports
      cmderr	[npmPack] default imported from external module 'rollup' but never used
      cmderr	[npmPack] ./esm/microsoftDatadogClient.js → ./dist/arm-datadog.js...
      cmderr	[npmPack] created ./dist/arm-datadog.js in 278ms
    ️️✔️ azure-cli-extensions succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from 2f4a6ac1ca78e0944945f91cbddc07cbe7484773. Azure CLI Automation 14.0.0
      warn	Skip initScript due to not configured
      command	npx n 12
      command	python3 -m venv venv
      command	pip install --upgrade setuptools wheel pip
      command	pip install pathlib jinja2 msrestazure
      command	autorest --az --use=@autorest/az@latest --version=3.0.6271 --clear-output-folder=true --azure-cli-extension-folder=/home/vsts/work/1/s/azure-cli-extensions ../azure-rest-api-specs/specification/datadog/resource-manager/readme.md
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'ErrorDetail' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'ErrorResponse' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'ErrorAdditionalInfo' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      cmdout	[Autorest] WARNING (PreCheck/CheckDuplicateSchemas): Checking for duplicate schemas, this could take a (long) while.  Run with --verbose for more detail.
      cmdout	[Autorest] WARNING (): cli.auto-parameter-hidden is not true, skip visibility cleaner
      cmderr	[Autorest] BELOW TEST SCENARIO SECTION CAN BE USED IN readme.cli.md
      cmderr	[Autorest] --------------------------------------------------------
      cmderr	[Autorest]   test-scenario:
      cmderr	[Autorest]     - name: /MarketplaceAgreements/put/MarketplaceAgreements_CreateOrUpdate
      cmderr	[Autorest]     - name: /MarketplaceAgreements/get/MarketplaceAgreements_List
      cmderr	[Autorest]     - name: /Monitors/put/Monitors_Create
      cmderr	[Autorest]     - name: /Monitors/get/Monitors_Get
      cmderr	[Autorest]     - name: /Monitors/get/Monitors_List
      cmderr	[Autorest]     - name: /Monitors/get/Monitors_ListByResourceGroup
      cmderr	[Autorest]     - name: /Monitors/patch/Monitors_Update
      cmderr	[Autorest]     - name: /Monitors/post/Monitors_GetDefaultKey
      cmderr	[Autorest]     - name: /Monitors/post/Monitors_ListApiKeys
      cmderr	[Autorest]     - name: /Monitors/post/Monitors_ListHosts
      cmderr	[Autorest]     - name: /Monitors/post/Monitors_ListLinkedResources
      cmderr	[Autorest]     - name: /Monitors/post/Monitors_ListMonitoredResources
      cmderr	[Autorest]     - name: /Monitors/post/Monitors_RefreshSetPasswordLink
      cmderr	[Autorest]     - name: /Monitors/post/Monitors_SetDefaultKey
      cmderr	[Autorest]     - name: /SingleSignOnConfigurations/put/SingleSignOnConfigurations_CreateOrUpdate
      cmderr	[Autorest]     - name: /SingleSignOnConfigurations/get/SingleSignOnConfigurations_Get
      cmderr	[Autorest]     - name: /SingleSignOnConfigurations/get/SingleSignOnConfigurations_List
      cmderr	[Autorest]     - name: /TagRules/put/TagRules_CreateOrUpdate
      cmderr	[Autorest]     - name: /TagRules/get/TagRules_Get
      cmderr	[Autorest]     - name: /TagRules/get/TagRules_List
      cmderr	[Autorest]     - name: /Monitors/delete/Monitors_Delete
      cmderr	[Autorest] --------------------------------------------------------
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs] Generate from 2f4a6ac1ca78e0944945f91cbddc07cbe7484773. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
      cmderr	[generateScript.sh] (node:2515) UnhandledPromiseRejectionWarning: Error: ENOENT: no such file or directory, unlink '/home/vsts/work/1/s/azure-resource-manager-schemas/schemas/2021-03-01/Microsoft.Datadog.json'
      cmderr	[generateScript.sh] (Use `node --trace-warnings ...` to show where the warning was created)
      cmderr	[generateScript.sh] (node:2515) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)
      cmderr	[generateScript.sh] (node:2515) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
      warn	No file changes detected after generation
    • ️✔️datadog [View full logs]  [Preview Schema Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link
    Copy Markdown

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @JackTn
    Copy link
    Copy Markdown
    Member

    JackTn commented Jun 16, 2022

    Hi, @msyyc. The PR has be closed for a long time and it's related branch still exist. Please tell me if you still need this branch or i will delete it in 14 days.

    2 similar comments
    @JackTn
    Copy link
    Copy Markdown
    Member

    JackTn commented Jun 16, 2022

    Hi, @msyyc. The PR has be closed for a long time and it's related branch still exist. Please tell me if you still need this branch or i will delete it in 14 days.

    @JackTn
    Copy link
    Copy Markdown
    Member

    JackTn commented Jun 16, 2022

    Hi, @msyyc. The PR has be closed for a long time and it's related branch still exist. Please tell me if you still need this branch or i will delete it in 14 days.

    @JackTn JackTn deleted the test-2021-05-12 branch July 5, 2022 01:23
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    None yet

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    2 participants