You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Adding new API(s)
Adding a new API version
Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.
Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable or public preview version with Breaking Change Validation errors
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?
Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com
❌Failed [Logs] Generate from 2f4a6ac1ca78e0944945f91cbddc07cbe7484773. SDK Automation 14.0.0
command sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr [automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmdout [automation_generate.sh] [Autorest]/home/vsts/work/1/s/azure-sdk-for-python_tmp/venv-sdk/auto_temp.json does not exist!!!Error happened during codegen
error Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-python]: sh scripts/automation_generate.sh
warn Skip package processing as generation is failed
️✔️Succeeded [Logs] Generate from 2f4a6ac1ca78e0944945f91cbddc07cbe7484773. SDK Automation 14.0.0
command sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
️✔️Succeeded [Logs] Generate from 2f4a6ac1ca78e0944945f91cbddc07cbe7484773. SDK Automation 14.0.0
warn Skip initScript due to not configured
command autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.4.4 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/datadog/resource-manager/readme.md
cmderr [npmPack] loaded rollup.config.js with warnings
cmderr [npmPack] (!) Unused external imports
cmderr [npmPack] default imported from external module 'rollup' but never used
cmderr [npmPack] ./esm/microsoftDatadogClient.js → ./dist/arm-datadog.js...
cmderr [npmPack] created ./dist/arm-datadog.js in 278ms
️✔️Succeeded [Logs] Generate from 2f4a6ac1ca78e0944945f91cbddc07cbe7484773. Azure CLI Automation 14.0.0
warn Skip initScript due to not configured
command npx n 12
command python3 -m venv venv
command pip install --upgrade setuptools wheel pip
command pip install pathlib jinja2 msrestazure
command autorest --az --use=@autorest/az@latest --version=3.0.6271 --clear-output-folder=true --azure-cli-extension-folder=/home/vsts/work/1/s/azure-cli-extensions ../azure-rest-api-specs/specification/datadog/resource-manager/readme.md
cmdout [Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'ErrorDetail' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout [Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'ErrorResponse' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout [Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'ErrorAdditionalInfo' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout [Autorest] WARNING (PreCheck/CheckDuplicateSchemas): Checking for duplicate schemas, this could take a (long) while. Run with --verbose for more detail.
cmdout [Autorest] WARNING (): cli.auto-parameter-hidden is not true, skip visibility cleaner
cmderr [Autorest] BELOW TEST SCENARIO SECTION CAN BE USED IN readme.cli.md
cmderr [Autorest] --------------------------------------------------------
cmderr [Autorest] test-scenario:
cmderr [Autorest] - name: /MarketplaceAgreements/put/MarketplaceAgreements_CreateOrUpdate
cmderr [Autorest] - name: /MarketplaceAgreements/get/MarketplaceAgreements_List
cmderr [Autorest] - name: /Monitors/put/Monitors_Create
cmderr [Autorest] - name: /Monitors/get/Monitors_Get
cmderr [Autorest] - name: /Monitors/get/Monitors_List
cmderr [Autorest] - name: /Monitors/get/Monitors_ListByResourceGroup
cmderr [Autorest] - name: /Monitors/patch/Monitors_Update
cmderr [Autorest] - name: /Monitors/post/Monitors_GetDefaultKey
cmderr [Autorest] - name: /Monitors/post/Monitors_ListApiKeys
cmderr [Autorest] - name: /Monitors/post/Monitors_ListHosts
cmderr [Autorest] - name: /Monitors/post/Monitors_ListLinkedResources
cmderr [Autorest] - name: /Monitors/post/Monitors_ListMonitoredResources
cmderr [Autorest] - name: /Monitors/post/Monitors_RefreshSetPasswordLink
cmderr [Autorest] - name: /Monitors/post/Monitors_SetDefaultKey
cmderr [Autorest] - name: /SingleSignOnConfigurations/put/SingleSignOnConfigurations_CreateOrUpdate
cmderr [Autorest] - name: /SingleSignOnConfigurations/get/SingleSignOnConfigurations_Get
cmderr [Autorest] - name: /SingleSignOnConfigurations/get/SingleSignOnConfigurations_List
cmderr [Autorest] - name: /TagRules/put/TagRules_CreateOrUpdate
cmderr [Autorest] - name: /TagRules/get/TagRules_Get
cmderr [Autorest] - name: /TagRules/get/TagRules_List
cmderr [Autorest] - name: /Monitors/delete/Monitors_Delete
cmderr [Autorest] --------------------------------------------------------
⚠️Warning [Logs] Generate from 2f4a6ac1ca78e0944945f91cbddc07cbe7484773. Schema Automation 14.0.0
command .sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
warn File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command .sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
cmderr [generateScript.sh] (node:2515) UnhandledPromiseRejectionWarning: Error: ENOENT: no such file or directory, unlink '/home/vsts/work/1/s/azure-resource-manager-schemas/schemas/2021-03-01/Microsoft.Datadog.json'
cmderr [generateScript.sh] (Use `node --trace-warnings ...` to show where the warning was created)
cmderr [generateScript.sh] (node:2515) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)
cmderr [generateScript.sh] (node:2515) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
warn No file changes detected after generation
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.
Hi, @msyyc. The PR has be closed for a long time and it's related branch still exist. Please tell me if you still need this branch or i will delete it in 14 days.
Hi, @msyyc. The PR has be closed for a long time and it's related branch still exist. Please tell me if you still need this branch or i will delete it in 14 days.
Hi, @msyyc. The PR has be closed for a long time and it's related branch still exist. Please tell me if you still need this branch or i will delete it in 14 days.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.