[Hub Generated] Review request for Microsoft.TestBase to add version preview/2021-05-10-preview by muaw1yah · Pull Request #14352 · Azure/azure-rest-api-specs

muaw1yah · 2021-05-11T09:37:10Z

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No, no need to refresh for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
- Adding a new API version
- Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently.
- Adding a new service
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable or public preview version with Breaking Change Validation errors
Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

…2-16-preview to version 2021-05-10-preview

akning-ms · 2021-05-14T01:27:17Z

/azp run

openapi-pipeline-app · 2021-05-14T01:27:18Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️⚠️LintDiff: 0 Warnings warning [Detail]

Linted configuring files (Based on source branch, openapi-validator v1.9.2 , classic-openapi-validator v1.1.6 )
- testbase/resource-manager/readme.md tag:package-preview-2021-05
Linted configuring files (Based on target branch, openapi-validator v1.9.2 , classic-openapi-validator v1.1.6 )
- testbase/resource-manager/readme.md tag:default

The following errors/warnings exist before current PR submission:

Only 10 items are listed, please refer to log for more details.

Rule	Message
⚠️ R3010 - TrackedResourceListByImmediateParent	The child tracked resource, 'availableOSs' with immediate parent 'TestBaseAccountResource', must have a list by immediate parent operation. Location: Microsoft.TestBase/preview/2021-05-10-preview/testbase.json#L2066
⚠️ R3010 - TrackedResourceListByImmediateParent	The child tracked resource, 'flightingRings' with immediate parent 'TestBaseAccountResource', must have a list by immediate parent operation. Location: Microsoft.TestBase/preview/2021-05-10-preview/testbase.json#L2066
⚠️ R3010 - TrackedResourceListByImmediateParent	The child tracked resource, 'testTypes' with immediate parent 'TestBaseAccountResource', must have a list by immediate parent operation. Location: Microsoft.TestBase/preview/2021-05-10-preview/testbase.json#L2066
⚠️ R3010 - TrackedResourceListByImmediateParent	The child tracked resource, 'packages' with immediate parent 'TestBaseAccountResource', must have a list by immediate parent operation. Location: Microsoft.TestBase/preview/2021-05-10-preview/testbase.json#L2066
⚠️ R3010 - TrackedResourceListByImmediateParent	The child tracked resource, 'testSummaries' with immediate parent 'TestBaseAccountResource', must have a list by immediate parent operation. Location: Microsoft.TestBase/preview/2021-05-10-preview/testbase.json#L2066
⚠️ R3010 - TrackedResourceListByImmediateParent	The child tracked resource, 'testResults' with immediate parent 'PackageResource', must have a list by immediate parent operation. Location: Microsoft.TestBase/preview/2021-05-10-preview/testbase.json#L2066
⚠️ R3010 - TrackedResourceListByImmediateParent	The child tracked resource, 'osUpdates' with immediate parent 'PackageResource', must have a list by immediate parent operation. Location: Microsoft.TestBase/preview/2021-05-10-preview/testbase.json#L2066
⚠️ R3010 - TrackedResourceListByImmediateParent	The child tracked resource, 'favoriteProcesses' with immediate parent 'PackageResource', must have a list by immediate parent operation. Location: Microsoft.TestBase/preview/2021-05-10-preview/testbase.json#L2066
⚠️ R3010 - TrackedResourceListByImmediateParent	The child tracked resource, 'analysisResults' with immediate parent 'TestResultResource', must have a list by immediate parent operation. Location: Microsoft.TestBase/preview/2021-05-10-preview/testbase.json#L2066
⚠️ R3018 - EnumInsteadOfBoolean	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: nameAvailable Location: Microsoft.TestBase/preview/2021-05-10-preview/testbase.json#L2665

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️❌ModelValidation: 3 Errors, 0 Warnings failed [Detail]

Rule	Message
`❌` SECRET_PROPERTY	Secret property `"downloadUrl"`, cannot be sent in the response. Url: Microsoft.TestBase/preview/2021-05-10-preview/testbase.json#L3033 JsonUrl: preview/2021-05-10-preview/examples/PackageGetDownloadURL.json#L12
`❌` SECRET_PROPERTY	Secret property `"downloadUrl"`, cannot be sent in the response. Url: Microsoft.TestBase/preview/2021-05-10-preview/testbase.json#L3033 JsonUrl: preview/2021-05-10-preview/examples/TestResultGetDownloadURL.json#L13
`❌` SECRET_PROPERTY	Secret property `"downloadUrl"`, cannot be sent in the response. Url: Microsoft.TestBase/preview/2021-05-10-preview/testbase.json#L3033 JsonUrl: preview/2021-05-10-preview/examples/TestResultGetVideoDownloadURL.json#L13

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]

There are no breaking changes.

Compared Swaggers (Based on Oad v0.8.9)
- current:preview/2021-05-10-preview/testbase.json compared with base:preview/2020-12-16-preview/testbase.json

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand]

Validation passes for SDKTrack2Validation

The following tags are being changed in this PR

testbase/resource-manager/readme.md#package-preview-2021-05

The following errors/warnings are introduced by current PR:

|:speech_balloon: AutorestCore/Exception|"readme":"testbase/resource-manager/readme.md",
"tag":"package-preview-2021-05",
"details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"testbase/resource-manager/readme.md",
"tag":"package-preview-2021-05",
"details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"testbase/resource-manager/readme.md",
"tag":"package-preview-2021-05",
"details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|

️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️❌[Staging] Lint(RPaaS): 8 Errors, 0 Warnings failed [Detail]

Rule	Message
`❌` R4031 - Rpaas_ResourceProvisioningState	[RPaaS] The resource AvailableOSResource is defined without 'provisioningState' in properties bag, consider adding the provisioningState for it. Location: Microsoft.TestBase/preview/2021-05-10-preview/testbase.json#L2498
`❌` R4031 - Rpaas_ResourceProvisioningState	[RPaaS] The resource FlightingRingResource is defined without 'provisioningState' in properties bag, consider adding the provisioningState for it. Location: Microsoft.TestBase/preview/2021-05-10-preview/testbase.json#L2563
`❌` R4031 - Rpaas_ResourceProvisioningState	[RPaaS] The resource TestTypeResource is defined without 'provisioningState' in properties bag, consider adding the provisioningState for it. Location: Microsoft.TestBase/preview/2021-05-10-preview/testbase.json#L2608
`❌` R4031 - Rpaas_ResourceProvisioningState	[RPaaS] The resource TestSummaryResource is defined without 'provisioningState' in properties bag, consider adding the provisioningState for it. Location: Microsoft.TestBase/preview/2021-05-10-preview/testbase.json#L3064
`❌` R4031 - Rpaas_ResourceProvisioningState	[RPaaS] The resource TestResultResource is defined without 'provisioningState' in properties bag, consider adding the provisioningState for it. Location: Microsoft.TestBase/preview/2021-05-10-preview/testbase.json#L3243
`❌` R4031 - Rpaas_ResourceProvisioningState	[RPaaS] The resource OSUpdateResource is defined without 'provisioningState' in properties bag, consider adding the provisioningState for it. Location: Microsoft.TestBase/preview/2021-05-10-preview/testbase.json#L3394
`❌` R4031 - Rpaas_ResourceProvisioningState	[RPaaS] The resource FavoriteProcessResource is defined without 'provisioningState' in properties bag, consider adding the provisioningState for it. Location: Microsoft.TestBase/preview/2021-05-10-preview/testbase.json#L3472
`❌` R4031 - Rpaas_ResourceProvisioningState	[RPaaS] The resource AnalysisResultSingletonResource is defined without 'provisioningState' in properties bag, consider adding the provisioningState for it. Location: Microsoft.TestBase/preview/2021-05-10-preview/testbase.json#L3520

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2021-05-14T01:27:19Z

Swagger Generation Artifacts

️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️️✔️[Staging] SDK Breaking Change Tracking succeeded [Detail] [Expand]

Breaking Changes Tracking

️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-testbase - first release

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs] Generate from 766f184d79ce05c82c4743224ea3f33b4cb088b2. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json

️✔️track2_azure-mgmt-testbase [View full logs] [Preview SDK Changes]
- azure-mgmt-testbase-1.0.0b1.zip
- azure_mgmt_testbase-1.0.0b1-py2.py3-none-any.whl
```
info	[Changelog]   - Initial Release
```

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs] Generate from 766f184d79ce05c82c4743224ea3f33b4cb088b2. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] 2021-05-17 06:49:39 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-testbase"
cmderr	[generate.py] 2021-05-17 06:49:39 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
cmderr	[generate.py] 2021-05-17 06:49:39 INFO autorest --version=3.1.3 --use=@autorest/java@4.0.28 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/testbase/azure-resourcemanager-testbase --java.namespace=com.azure.resourcemanager.testbase   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/testbase/resource-manager/readme.md
cmderr	[generate.py] 2021-05-17 06:50:18 INFO [CI][Success] Write to ci.yml
cmderr	[generate.py] 2021-05-17 06:50:18 INFO [POM][Process] dealing with pom.xml
cmderr	[generate.py] 2021-05-17 06:50:18 INFO [POM][Skip] pom already has module azure-resourcemanager-testbase
cmderr	[generate.py] 2021-05-17 06:50:18 INFO [POM][Success] Write to pom.xml
cmderr	[generate.py] 2021-05-17 06:50:18 INFO [POM][Process] dealing with root pom
cmderr	[generate.py] 2021-05-17 06:50:18 INFO [POM][Success] Write to root pom

️✔️azure-resourcemanager-testbase [View full logs] [Preview SDK Changes]

cmderr	[Inst] 2021-05-17 06:54:15 DEBUG Got artifact_id: azure-resourcemanager-testbase
cmderr	[Inst] 2021-05-17 06:54:15 DEBUG Got artifact: pom.xml
cmderr	[Inst] 2021-05-17 06:54:15 DEBUG Got artifact: azure-resourcemanager-testbase-1.0.0-beta.1-javadoc.jar
cmderr	[Inst] 2021-05-17 06:54:15 DEBUG Got artifact: azure-resourcemanager-testbase-1.0.0-beta.1-sources.jar
cmderr	[Inst] 2021-05-17 06:54:15 DEBUG Got artifact: azure-resourcemanager-testbase-1.0.0-beta.1.jar
cmderr	[Inst] 2021-05-17 06:54:15 DEBUG Match jar package: azure-resourcemanager-testbase-1.0.0-beta.1.jar
cmderr	[Inst] 2021-05-17 06:54:15 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/14352/azure-sdk-for-java/azure-resourcemanager-testbase/azure-resourcemanager-testbase-1.0.0-beta.1.jar\" -o azure-resourcemanager-testbase-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-testbase -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-testbase-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true
```"}

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from 766f184d79ce05c82c4743224ea3f33b4cb088b2. SDK Automation 14.0.0

command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️preview/testbase/mgmt/2020-12-16-preview/testbase [View full logs] [Preview SDK Changes]
```
info	[Changelog] This is a new package
```

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from 766f184d79ce05c82c4743224ea3f33b4cb088b2. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.4.4 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/testbase/resource-manager/readme.md

️✔️@azure/arm-testbase [View full logs] [Preview SDK Changes]

azure-arm-testbase-1.0.0.tgz

cmderr	[npmPack] loaded rollup.config.js with warnings
cmderr	[npmPack] (!) Unused external imports
cmderr	[npmPack] default imported from external module 'rollup' but never used
cmderr	[npmPack] ./esm/rESTAPIforTestBase.js → ./dist/arm-testbase.js...
cmderr	[npmPack] created ./dist/arm-testbase.js in 586ms

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs] Generate from 766f184d79ce05c82c4743224ea3f33b4cb088b2. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
warn	No file changes detected after generation
warn	Skip detect changed packages

_{Posted by Swagger Pipeline | How to fix these errors?}

azure-pipelines · 2021-05-14T01:27:28Z

Azure Pipelines successfully started running 1 pipeline(s).

PhoenixHe-NV · 2021-05-17T05:14:18Z

@jianyexi to help on the lint rpsass exception?

jianyexi · 2021-05-17T06:43:47Z

/azp run

azure-pipelines · 2021-05-17T06:43:59Z

Azure Pipelines successfully started running 1 pipeline(s).

jianyexi · 2021-05-17T07:19:41Z

@jianyexi Jianye Xi FTE to help on the lint rpsass exception?

Fixed by rerun it

ghost · 2021-06-06T16:00:44Z

Hi, @muaw1yah. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

ghost · 2021-06-21T05:00:13Z

Hi, @muaw1yah. The PR will be closed since the PR has no update for 28 days. If you still need the PR review to proceed, please reopen it and @ mention PR assignee.

muaw1yah added 3 commits May 11, 2021 09:49

Adds base for updating Microsoft.TestBase from version preview/2020-1…

172ac14

…2-16-preview to version 2021-05-10-preview

Updates readme

a8565f3

Updates API version in new specs and examples

8b99f01

muaw1yah marked this pull request as ready for review May 11, 2021 09:38

openapi-assignment-bot bot assigned PhoenixHe-NV May 11, 2021

PhoenixHe-NV added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label May 17, 2021

ghost added the no-recent-activity label Jun 6, 2021

ghost closed this Jun 21, 2021

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Hub Generated] Review request for Microsoft.TestBase to add version preview/2021-05-10-preview#14352

[Hub Generated] Review request for Microsoft.TestBase to add version preview/2021-05-10-preview#14352
muaw1yah wants to merge 3 commits intomasterfrom
dev-testbase-Microsoft.TestBase-2021-05-10-preview

muaw1yah commented May 11, 2021

Uh oh!

akning-ms commented May 14, 2021

Uh oh!

openapi-pipeline-app bot commented May 14, 2021 •

edited

Loading

Uh oh!

openapi-pipeline-app bot commented May 14, 2021 •

edited

Loading

Breaking Changes Tracking

Uh oh!

azure-pipelines bot commented May 14, 2021

Uh oh!

PhoenixHe-NV commented May 17, 2021

Uh oh!

jianyexi commented May 17, 2021

Uh oh!

azure-pipelines bot commented May 17, 2021

Uh oh!

jianyexi commented May 17, 2021

Uh oh!

ghost commented Jun 6, 2021

Uh oh!

ghost commented Jun 21, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

muaw1yah commented May 11, 2021

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

Uh oh!

akning-ms commented May 14, 2021

Uh oh!

openapi-pipeline-app bot commented May 14, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Swagger Validation Report

Uh oh!

openapi-pipeline-app bot commented May 14, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Swagger Generation Artifacts

Breaking Changes Tracking

Uh oh!

azure-pipelines bot commented May 14, 2021

Uh oh!

PhoenixHe-NV commented May 17, 2021

Uh oh!

jianyexi commented May 17, 2021

Uh oh!

azure-pipelines bot commented May 17, 2021

Uh oh!

jianyexi commented May 17, 2021

Uh oh!

ghost commented Jun 6, 2021

Uh oh!

ghost commented Jun 21, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

openapi-pipeline-app bot commented May 14, 2021 •

edited

Loading

openapi-pipeline-app bot commented May 14, 2021 •

edited

Loading