Skip to content

Per Sarangan: remove x-ms-azure-resource for subs#1427

Merged
sarangan12 merged 1 commit intoAzure:currentfrom
begoldsm:current
Jul 17, 2017
Merged

Per Sarangan: remove x-ms-azure-resource for subs#1427
sarangan12 merged 1 commit intoAzure:currentfrom
begoldsm:current

Conversation

@begoldsm
Copy link
Contributor

Sub resources that do not explicitly conform to the azure resource model
should not have the tag. Sarangan is opening an issue in the validator
to remove the "error" that it isn't tagged.

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

Sub resources that do not explicitly conform to the azure resource model
should not have the tag. Sarangan is opening an issue in the validator
to remove the "error" that it isn't tagged.
@sarangan12 sarangan12 self-assigned this Jul 17, 2017
@sarangan12 sarangan12 self-requested a review July 17, 2017 17:37
@sarangan12 sarangan12 merged commit 1288b39 into Azure:current Jul 17, 2017
@azuresdkci
Copy link
Contributor

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/datalake-analytics/resource-manager/readme.md
Before the PR: Warning(s): 22 Error(s): 6
After the PR: Warning(s): 22 Error(s): 5

File: specification/datalake-store/resource-manager/readme.md
Before the PR: Warning(s): 8 Error(s): 3
After the PR: Warning(s): 8 Error(s): 5

Know more about AutoRest Linter Guidelines.

Send feedback and make AutoRest Linter Azure Bot smarter day by day!

Thanks for your co-operation.

@AutorestCI
Copy link

No modification for AutorestCI/azure-sdk-for-node

@AutorestCI
Copy link

@AutorestCI
Copy link

No modification for AutorestCI/azure-sdk-for-ruby

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants