Compute 2021-03 release, correct commit format#14220
Closed
Compute 2021-03 release, correct commit format#14220
Conversation
ghost
added
the
Swagger Validation Report
|
| Rule | Message |
|---|---|
|
"readme":"compute/resource-manager/readme.md", "tag":"package-2021-03-01", "details":"Syntax Error Encountered: Unexpected string in JSON" |
|
"readme":"compute/resource-manager/readme.md", "tag":"package-2021-03-01", "details":"Syntax error: missed comma between flow collection entries" |
|
"readme":"compute/resource-manager/readme.md", "tag":"package-2021-03-01", "details":"Syntax error: unexpected end of the stream within a flow collection" |
|
"readme":"compute/resource-manager/readme.md", "tag":"package-2021-03-01", "details":"swagger-document/loader - FAILED" |
|
"readme":"compute/resource-manager/readme.md", "tag":"package-2021-03-01", "details":"Error: Syntax errors encountered." |
️❌Avocado: 57 Errors, 1 Warnings failed [Detail]
Only 10 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
The file is not a valid JSON file. json: [Microsoft.Compute/stable/2021-03-01/compute.json"}]({"kind":"structure","code":"unexpected token","position":{"line":11745,"column":11},"token":""VirtualMachineScaleSetUpdateVMProfile\": {VirtualMachineScaleSetOSDisk\""","message":"unexpected token, token: "VirtualMachineScaleSetUpdateVMProfile\": {VirtualMachineScaleSetOSDisk\"", line: 11745, column: 11","url":"/home/vsts/work/1/c93b354fd9c14905bb574a8834c4d69b/specification/compute/resource-manager/Microsoft.Compute/stable/2021-03-01/compute.json"}) |
|
The file is not a valid JSON file. json: [Microsoft.Compute/stable/2021-03-01/compute.json"}]({"kind":"structure","code":"unexpected token","position":{"line":11746,"column":11},"token":",","message":"unexpected token, token: ,, line: 11746, column: 11","url":"/home/vsts/work/1/c93b354fd9c14905bb574a8834c4d69b/specification/compute/resource-manager/Microsoft.Compute/stable/2021-03-01/compute.json"}) |
|
The file is not a valid JSON file. json: [Microsoft.Compute/stable/2021-03-01/compute.json"}]({"kind":"structure","code":"unexpected end of file","position":{"line":1,"column":1},"token":"}","message":"unexpected end of file, token: }, line: 1, column: 1","url":"/home/vsts/work/1/c93b354fd9c14905bb574a8834c4d69b/specification/compute/resource-manager/Microsoft.Compute/stable/2021-03-01/compute.json"}) |
|
The JSON file is not found but it is referenced from the readme file. readme: specification/compute/resource-manager/readme.md json: stable/2021-03-01/examples/CreateAWindowsVmWithPatchSettingModeOfAutomaticByOS.json |
|
The example JSON file is not referenced from the swagger file. readme: specification/compute/resource-manager/readme.md json: stable/2021-03-01/examples/ApprovePrivateEndpointConnection.json |
|
The example JSON file is not referenced from the swagger file. readme: specification/compute/resource-manager/readme.md json: stable/2021-03-01/examples/CreateADiskAccess.json |
|
The example JSON file is not referenced from the swagger file. readme: specification/compute/resource-manager/readme.md json: stable/2021-03-01/examples/CreateADiskEncryptionSet.json |
|
The example JSON file is not referenced from the swagger file. readme: specification/compute/resource-manager/readme.md json: stable/2021-03-01/examples/CreateADiskEncryptionSetWithKeyVaultFromADifferentSubscription.json |
|
The example JSON file is not referenced from the swagger file. readme: specification/compute/resource-manager/readme.md json: stable/2021-03-01/examples/CreateAManagedDiskByCopyingASnapshot.json |
|
The example JSON file is not referenced from the swagger file. readme: specification/compute/resource-manager/readme.md json: stable/2021-03-01/examples/CreateAManagedDiskByImportingAnUnmanagedBlobFromADifferentSubscription.json |
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]
There are no breaking changes.
- Compared Swaggers (Based on Oad v0.8.9)
- original: stable/2020-12-01/runCommands.json <---> new: stable/2021-03-01/runCommands.json
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️🔄[Staging] SDK Track2 Validation inProgress [Detail]
️❌[Staging] PrettierCheck: 4 Errors, 0 Warnings failed [Detail]
| Rule | Message |
|---|---|
|
Code style issues found path: Microsoft.Compute/stable/2021-03-01/compute.json |
|
Code style issues found path: stable/2021-03-01/examples/CreateAVmWithNetworkInterfaceConfiguration.json |
|
Code style issues found path: stable/2021-03-01/examples/CreateAVmWithScheduledEventsProfile.json |
|
Code style issues found path: stable/2021-03-01/examples/CreateAWindowsVmWithPatchSettingModesOfAutomaticByPlatform.json |
️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
Swagger Generation Artifacts
|
|
Hi @Sandido, Your PR has some issues. Please fix the CI sequentially by following the order of
|
This was referenced May 3, 2021
openapi-pipeline-app
bot
added
CI-BreakingChange-Go
CI-FixRequiredOnFailure
CI-BreakingChange-Python-Track2
and removed
CI-FixRequiredOnFailure
labels
openapi-pipeline-app
bot
added
CI-FixRequiredOnFailure
and removed
CI-FixRequiredOnFailure
labels
openapi-pipeline-app
bot
added
CI-FixRequiredOnFailure
and removed
CI-BreakingChange-Go
labels
openapi-pipeline-app
bot
added
CI-FixRequiredOnFailure
and removed
CI-FixRequiredOnFailure
labels
openapi-pipeline-app
bot
added
CI-FixRequiredOnFailure
and removed
CI-FixRequiredOnFailure
labels
openapi-pipeline-app
bot
added
CI-FixRequiredOnFailure
and removed
CI-FixRequiredOnFailure
labels
openapi-pipeline-app
bot
added
CI-FixRequiredOnFailure
and removed
CI-FixRequiredOnFailure
labels
openapi-pipeline-app
bot
added
CI-FixRequiredOnFailure
and removed
CI-FixRequiredOnFailure
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.