[Hub Generated] Review request for Microsoft.MarketplaceNotifications to add version stable/2021-03-03 by habenefr · Pull Request #14115 · Azure/azure-rest-api-specs

habenefr · 2021-04-25T08:59:16Z

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No, no need to refresh for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
- Adding a new API version
- Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently.
- Adding a new service
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable or public preview version with Breaking Change Validation errors
Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

openapi-workflow-bot · 2021-04-25T08:59:18Z

Hi, @habenefr Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

openapi-workflow-bot · 2021-04-25T08:59:19Z

[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

openapi-pipeline-app · 2021-04-25T08:59:21Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️⚠️LintDiff: 1 Warnings warning [Detail]

Linted configuring files (Based on source branch, openapi-validator v1.9.2 , classic-openapi-validator v1.1.6 )
- marketplacenotifications/resource-manager/readme.md tag:package-2021-03-03
Linted configuring files (Based on target branch, openapi-validator v1.9.2 , classic-openapi-validator v1.1.6 )
- marketplacenotifications/resource-manager/readme.md tag:default

The following errors/warnings are introduced by current PR:

Rule	Message
⚠️ R4006 - DeprecatedXmsCodeGenerationSetting	The x-ms-code-generation-setting extension is being deprecated. Please remove it and move settings to readme file for code generation. Location: Microsoft.MarketplaceNotifications/stable/2021-03-03/marketplacenotifications.json#L7

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand]

Validation passes for SDKTrack2Validation

The following tags are being changed in this PR

marketplacenotifications/resource-manager/readme.md#package-2021-03-03

The following errors/warnings are introduced by current PR:

|:speech_balloon: AutorestCore/Exception|"readme":"marketplacenotifications/resource-manager/readme.md",
"tag":"package-2021-03-03",
"details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"marketplacenotifications/resource-manager/readme.md",
"tag":"package-2021-03-03",
"details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"marketplacenotifications/resource-manager/readme.md",
"tag":"package-2021-03-03",
"details":"> Installing AutoRest extension '@autorest/modelerfour' (4.15.456)"|
|:speech_balloon: AutorestCore/Exception|"readme":"marketplacenotifications/resource-manager/readme.md",
"tag":"package-2021-03-03",
"details":"> Installed AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|

️❌[Staging] PrettierCheck: 1 Errors, 0 Warnings failed [Detail]

Rule	Message
`❌` HowToFix	Code style issues found path: Microsoft.MarketplaceNotifications/stable/2021-03-03/marketplacenotifications.json

️❌[Staging] SpellCheck: 2 Errors, 0 Warnings failed [Detail]

Rule	Message
`❌` HowToFix	Unknown word (marketplacenotifications), please fix the error or add words to ./custom-words.txt path: Microsoft.MarketplaceNotifications/stable/2021-03-03/marketplacenotifications.json#L5:15
`❌` HowToFix	Unknown word (marketplacenotifications), please fix the error or add words to ./custom-words.txt path: Microsoft.MarketplaceNotifications/stable/2021-03-03/marketplacenotifications.json#L8:16

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2021-04-25T08:59:21Z

Swagger Generation Artifacts

️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️️✔️ azure-cli-extensions succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from abb7a1423506d470029a0739f8efe506a97e86b5. Azure CLI Automation 14.0.0

warn	Skip initScript due to not configured
command	npx n 12
command	python3 -m venv venv
command	pip install --upgrade setuptools wheel pip
command	pip install pathlib jinja2 msrestazure
command	autorest --az --use=@autorest/az@latest --version=3.0.6271 --clear-output-folder=true --azure-cli-extension-folder=/home/vsts/work/1/s/azure-cli-extensions ../azure-rest-api-specs/specification/marketplacenotifications/resource-manager/readme.md
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'Result' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'ErrorResponse' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/SchemaMissingType): The schema 'ErrorDefinition' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
cmdout	[Autorest] WARNING (PreCheck/CheckDuplicateSchemas): Checking for duplicate schemas, this could take a (long) while.  Run with --verbose for more detail.
cmdout	[Autorest] WARNING (): cli.auto-parameter-hidden is not true, skip visibility cleaner
cmderr	[Autorest] BELOW TEST SCENARIO SECTION CAN BE USED IN readme.cli.md
cmderr	[Autorest] --------------------------------------------------------
cmderr	[Autorest]   test-scenario:
cmderr	[Autorest]     - name: /OperationGroup/get/BatchAccountDelete
cmderr	[Autorest] --------------------------------------------------------

️✔️marketplacenotifications [View full logs] [Preview Azure CLI Changes]
- marketplacenotifications-0.1.0-py3-none-any.whl
- marketplacenotifications-0.1.0.zip

️❌ azure-sdk-for-go failed [Detail]

❌Failed [Logs] Generate from abb7a1423506d470029a0739f8efe506a97e86b5. SDK Automation 14.0.0

command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
cmderr	[main.go] [AUTOREST] Failure during batch task - {"tag":"package-2021-03-03[[-ReleaseState]]"} -- Error: [Exception] No input files provided.
cmderr	[main.go] [AUTOREST]
cmderr	[main.go] [AUTOREST] Use --help to get help information..
cmderr	[main.go] [ERROR] total 1 error(s):
cmderr	[main.go] [ERROR] cannot generate readme 'specification/marketplacenotifications/resource-manager/readme.md': autorest error with arguments '--use=@microsoft.azure/autorest.go@2.1.180, --go, --verbose, --go-sdk-folder=., --multiapi, --use-onever, --version=V2, --go.license-header=MICROSOFT_MIT_NO_VERSION, ../../../../../azure-rest-api-specs/specification/marketplacenotifications/resource-manager/readme.md, --metadata-output-folder=../../../../../azure-rest-api-specs/specification/marketplacenotifications/resource-manager':
cmderr	[main.go] [ERROR] exit status 1
error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go]: go run ./tools/generator/main.go
warn	Skip package processing as generation is failed

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs] Generate from abb7a1423506d470029a0739f8efe506a97e86b5. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json

️✔️track2_azure-mgmt-marketplacenotifications [View full logs] [Preview SDK Changes]
- azure-mgmt-marketplacenotifications-1.0.0b1.zip
- azure_mgmt_marketplacenotifications-1.0.0b1-py2.py3-none-any.whl
```
info	[Changelog]   - Initial Release
```

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs] Generate from abb7a1423506d470029a0739f8efe506a97e86b5. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] WARN read-shrinkwrap This version of npm is compatible with lockfileVersion@1, but package-lock.json was generated for lockfileVersion@2. I'll try to do my best with it!
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
warn	No file changes detected after generation
warn	Skip detect changed packages

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from abb7a1423506d470029a0739f8efe506a97e86b5. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.4.4 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/marketplacenotifications/resource-manager/readme.md

️✔️@azure/arm-marketplacenotifications [View full logs] [Preview SDK Changes]

azure-arm-marketplacenotifications-1.0.0.tgz

cmderr	[npmPack] loaded rollup.config.js with warnings
cmderr	[npmPack] (!) Unused external imports
cmderr	[npmPack] default imported from external module 'rollup' but never used
cmderr	[npmPack] ./esm/marketplacenotificationsClient.js → ./dist/arm-marketplacenotifications.js...
cmderr	[npmPack] created ./dist/arm-marketplacenotifications.js in 123ms

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs] Generate from abb7a1423506d470029a0739f8efe506a97e86b5. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] 2021-04-25 10:37:56 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-marketplacenotifications"
cmderr	[generate.py] 2021-04-25 10:37:56 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
cmderr	[generate.py] 2021-04-25 10:37:56 INFO autorest --version=3.1.3 --use=@autorest/java@4.0.24 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/marketplacenotifications/azure-resourcemanager-marketplacenotifications --java.namespace=com.azure.resourcemanager.marketplacenotifications   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/marketplacenotifications/resource-manager/readme.md
cmderr	[generate.py] 2021-04-25 10:38:26 INFO [CI][Success] Write to ci.yml
cmderr	[generate.py] 2021-04-25 10:38:26 INFO [POM][Process] dealing with pom.xml
cmderr	[generate.py] 2021-04-25 10:38:26 INFO [POM][Skip] pom already has module azure-resourcemanager-marketplacenotifications
cmderr	[generate.py] 2021-04-25 10:38:26 INFO [POM][Success] Write to pom.xml
cmderr	[generate.py] 2021-04-25 10:38:26 INFO [POM][Process] dealing with root pom
cmderr	[generate.py] 2021-04-25 10:38:26 INFO [POM][Success] Write to root pom

️✔️azure-resourcemanager-marketplacenotifications [View full logs] [Preview SDK Changes]

cmderr	[Inst] 2021-04-25 10:41:46 DEBUG Got artifact_id: azure-resourcemanager-marketplacenotifications
cmderr	[Inst] 2021-04-25 10:41:46 DEBUG Got artifact: pom.xml
cmderr	[Inst] 2021-04-25 10:41:46 DEBUG Got artifact: azure-resourcemanager-marketplacenotifications-1.0.0-beta.1-sources.jar
cmderr	[Inst] 2021-04-25 10:41:46 DEBUG Got artifact: azure-resourcemanager-marketplacenotifications-1.0.0-beta.1-javadoc.jar
cmderr	[Inst] 2021-04-25 10:41:46 DEBUG Got artifact: azure-resourcemanager-marketplacenotifications-1.0.0-beta.1.jar
cmderr	[Inst] 2021-04-25 10:41:46 DEBUG Match jar package: azure-resourcemanager-marketplacenotifications-1.0.0-beta.1.jar
cmderr	[Inst] 2021-04-25 10:41:46 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/14115/azure-sdk-for-java/azure-resourcemanager-marketplacenotifications/azure-resourcemanager-marketplacenotifications-1.0.0-beta.1.jar\" -o azure-resourcemanager-marketplacenotifications-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-marketplacenotifications -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-marketplacenotifications-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true
```"}

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2021-04-25T09:15:01Z

Hi, @habenefr your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). cc @qianwens

habenefr · 2021-04-25T09:46:36Z

/azp run unifiedPipeline

azure-pipelines · 2021-04-25T09:46:41Z

No pipelines are associated with this pull request.

habenefr · 2021-04-25T10:32:00Z

/azp run unifiedPipeline

azure-pipelines · 2021-04-25T10:32:05Z

No pipelines are associated with this pull request.

habenefr added 10 commits April 21, 2021 16:17

New Swagger Spec File

538b7dd

New Swagger Example Spec File

f8e8189

New Readme Config File

1557adb

New Azure AZ Readme Config File

bc99365

New Azure CLI Readme Config File

c512aa7

New Go Language Readme Config File

8ee29a7

New Python Language Readme Config File

5bcdad3

New AzureResourceSchema Readme Config File

dc73960

New Typescript Language Readme Config File

b29e207

New C# Language Readme Config File

02ef3d3

habenefr marked this pull request as ready for review April 25, 2021 09:09

habenefr requested review from 00Kai0, ArcturusZhang, RAY-316, jsntcy, msyyc, qiaozha and zhangyan133 as code owners April 25, 2021 09:09

openapi-assignment-bot Bot assigned qianwens Apr 25, 2021

openapi-sdkautomation Bot mentioned this pull request Apr 25, 2021

[AutoPR azure-resourcemanager-marketplacenotifications] [Hub Generated] Review request for Microsoft.MarketplaceNotifications to add version stable/2021-03-03 AzureSDKAutomation/azure-sdk-for-java#8399

Draft

openapi-workflow-bot Bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Apr 25, 2021

habenefr closed this Apr 25, 2021

habenefr deleted the dev-marketplacenotifications-Microsoft.MarketplaceNotifications-2021-03-03 branch April 25, 2021 12:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Hub Generated] Review request for Microsoft.MarketplaceNotifications to add version stable/2021-03-03#14115

[Hub Generated] Review request for Microsoft.MarketplaceNotifications to add version stable/2021-03-03#14115
habenefr wants to merge 10 commits intoAzure:masterfrom
habenefr:dev-marketplacenotifications-Microsoft.MarketplaceNotifications-2021-03-03

habenefr commented Apr 25, 2021 •

edited

Loading

Uh oh!

openapi-workflow-bot Bot commented Apr 25, 2021

Uh oh!

openapi-workflow-bot Bot commented Apr 25, 2021

Uh oh!

openapi-pipeline-app Bot commented Apr 25, 2021 •

edited

Loading

Uh oh!

openapi-pipeline-app Bot commented Apr 25, 2021 •

edited

Loading

Uh oh!

openapi-workflow-bot Bot commented Apr 25, 2021

Uh oh!

habenefr commented Apr 25, 2021

Uh oh!

azure-pipelines Bot commented Apr 25, 2021

Uh oh!

habenefr commented Apr 25, 2021

Uh oh!

azure-pipelines Bot commented Apr 25, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

habenefr commented Apr 25, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

Uh oh!

openapi-workflow-bot Bot commented Apr 25, 2021

Uh oh!

openapi-workflow-bot Bot commented Apr 25, 2021

Uh oh!

openapi-pipeline-app Bot commented Apr 25, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Swagger Validation Report

Uh oh!

openapi-pipeline-app Bot commented Apr 25, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Swagger Generation Artifacts

Uh oh!

openapi-workflow-bot Bot commented Apr 25, 2021

Uh oh!

habenefr commented Apr 25, 2021

Uh oh!

azure-pipelines Bot commented Apr 25, 2021

Uh oh!

habenefr commented Apr 25, 2021

Uh oh!

azure-pipelines Bot commented Apr 25, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

habenefr commented Apr 25, 2021 •

edited

Loading

openapi-pipeline-app Bot commented Apr 25, 2021 •

edited

Loading

openapi-pipeline-app Bot commented Apr 25, 2021 •

edited

Loading