StorageSync new api version 2020-09-01 #14005
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankushbindlish2
requested review from
00Kai0,
ArcturusZhang,
RAY-316,
jsntcy,
msyyc and
zhangyan133
as code owners
|
Hi, @ankushbindlish2 Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
Swagger Validation Report
|
| Rule | Message |
|---|---|
|
The response of operation:'StorageSyncServices_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.StorageSync/stable/2020-09-01/storagesync.json#L199 |
|
The response of operation:'PrivateEndpointConnections_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.StorageSync/stable/2020-09-01/storagesync.json#L560 |
|
The response of operation:'SyncGroups_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.StorageSync/stable/2020-09-01/storagesync.json#L940 |
|
The response of operation:'CloudEndpoints_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.StorageSync/stable/2020-09-01/storagesync.json#L1167 |
|
The response of operation:'ServerEndpoints_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.StorageSync/stable/2020-09-01/storagesync.json#L2124 |
|
The response of operation:'RegisteredServers_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.StorageSync/stable/2020-09-01/storagesync.json#L2501 |
|
The response of operation:'Workflows_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.StorageSync/stable/2020-09-01/storagesync.json#L2882 |
|
The response of operation:'StorageSyncServices_Create' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.StorageSync/stable/2020-09-01/storagesync.json#L120 |
|
The response of operation:'PrivateEndpointConnections_Create' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.StorageSync/stable/2020-09-01/storagesync.json#L603 |
|
The response of operation:'SyncGroups_Create' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.StorageSync/stable/2020-09-01/storagesync.json#L870 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️❌Cross Version BreakingChange (Base on preview version): 110 Errors, 32 Warnings failed [Detail]
- Compared Swaggers (Based on Oad v0.8.9)
- original: preview/2017-06-05-preview/storagesync.json <---> new: stable/2020-09-01/storagesync.json
Only 10 items are listed, please refer to log for more details.
️❌Cross Version BreakingChange (Base on stable version): 1 Errors, 0 Warnings failed [Detail]
- Compared Swaggers (Based on Oad v0.8.9)
- original: stable/2020-03-01/storagesync.json <---> new: stable/2020-09-01/storagesync.json
| Rule | Message |
|---|---|
|
The new version has a different default value than the previous one. New: Microsoft.StorageSync/stable/2020-09-01/storagesync.json#L3415:9 Old: Microsoft.StorageSync/stable/2020-03-01/storagesync.json#L3369:9 |
️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation
- The following tags are being changed in this PR
|:speech_balloon: AutorestCore/Exception|"readme":"storagesync/resource-manager/readme.md",
"tag":"package-2020-09-01",
"details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"storagesync/resource-manager/readme.md",
"tag":"package-2020-09-01",
"details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"storagesync/resource-manager/readme.md",
"tag":"package-2020-09-01",
"details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
Swagger Generation Artifacts
|
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
26 tasks
Member
Author
|
copied from #13792 |
|
Hi @ankushbindlish2, Your PR has some issues. Please fix the CI sequentially by following the order of
|
This was referenced Apr 19, 2021
njuCZ
added
the
WaitForARMFeedback
|
Hi @ankushbindlish2, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
Contributor
|
Hi @ankushbindlish2 pls check Cross Version BreakingChange (Base on stable version): 25 Errors result in #14005 (comment) you need go through breaking change review process, pls refer to #14005 (comment) |
|
Hi, @ankushbindlish2 your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]). cc @zhenglaizhang |
anpint
reviewed
Apr 28, 2021
...cation/storagesync/resource-manager/Microsoft.StorageSync/stable/2020-09-01/storagesync.json
Outdated
Show resolved
Hide resolved
Contributor
|
Changes looks ok from ARM perspective marking it ARMSignedoff please resolve other warning/errors and follow the process given @ https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/212/Swagger-PR-Review |
chiragg4u
added
ARMSignedOff
JeffreyRichter
approved these changes
May 10, 2021
JeffreyRichter
added
the
Approved-BreakingChange
Member
|
@zhenglaizhang I believe we've taken care of all the outstanding issues with this PR. |
zhenglaizhang
merged commit f80cc95
into
Azure:dev-storagesync-Microsoft.StorageSync-2020-09-01
This was referenced May 13, 2021
PhoenixHe-NV
pushed a commit
that referenced
this pull request
Jun 10, 2021
* DONOT COMMIT: Microsoft.StorageSync : Update Api Version 2020-09-01 (preview) for InitialUploadPolicy feature. (#11392) * update initialuploadpolicy * Update test for InitialUploadPolicy setting Co-authored-by: Manish Duggal <[email protected]> * [Microsoft.StorageSync] change enumeration protocol changes for 2020-09-01 (#12793) * change eumeration protocol changes * fix unexpected changes * StorageSync new api version 2020-09-01 (#14005) * change * del * revert * Remove systemData changes (postponed to future API version) * run prettier * Address breaking changes and S360 item for default values * run prettier Co-authored-by: Andre Pinto <[email protected]> Co-authored-by: Manishd79 <[email protected]> Co-authored-by: Manish Duggal <[email protected]> Co-authored-by: ankushbindlish2 <[email protected]>
asager
pushed a commit
to asager/azure-rest-api-specs
that referenced
this pull request
Jun 24, 2021
* DONOT COMMIT: Microsoft.StorageSync : Update Api Version 2020-09-01 (preview) for InitialUploadPolicy feature. (Azure#11392) * update initialuploadpolicy * Update test for InitialUploadPolicy setting Co-authored-by: Manish Duggal <[email protected]> * [Microsoft.StorageSync] change enumeration protocol changes for 2020-09-01 (Azure#12793) * change eumeration protocol changes * fix unexpected changes * StorageSync new api version 2020-09-01 (Azure#14005) * change * del * revert * Remove systemData changes (postponed to future API version) * run prettier * Address breaking changes and S360 item for default values * run prettier Co-authored-by: Andre Pinto <[email protected]> Co-authored-by: Manishd79 <[email protected]> Co-authored-by: Manish Duggal <[email protected]> Co-authored-by: ankushbindlish2 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.