Skip to content

Conversation

@RAY-316
Copy link
Contributor

@RAY-316 RAY-316 commented Apr 14, 2021

dns t2 readme config

@RAY-316 RAY-316 requested review from 00Kai0 and msyyc April 14, 2021 05:48
@openapi-workflow-bot
Copy link

Hi, @RAY-316 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Apr 14, 2021

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️LintDiff succeeded [Detail] [Expand]
    Validation passes for LintDiff.
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand]
    Validation passes for SDKTrack2Validation
    ️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Apr 14, 2021

    Swagger Generation Artifacts

    ️⚠️ azure-sdk-for-python warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 6fa6101. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
      cmderr	[automation_init.sh] azure-mgmt-core 1.2.2 requires azure-core<2.0.0,>=1.9.0, but you have azure-core 1.6.0 which is incompatible.
      cmderr	[automation_init.sh] ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
      cmderr	[automation_init.sh] azure-mgmt-core 1.2.2 requires azure-core<2.0.0,>=1.9.0, but you have azure-core 1.6.0 which is incompatible.
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️track2_azure-mgmt-dns [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Model RecordSet has a new parameter arecords
      info	[Changelog]   - Added operation ZonesOperations.delete
      info	[Changelog]
      info	[Changelog] **Breaking changes**
      info	[Changelog]
      info	[Changelog]   - Operation ZonesOperations.update has a new signature
      info	[Changelog]   - Operation ZonesOperations.update has a new signature
      info	[Changelog]   - Operation ZonesOperations.list_by_resource_group has a new signature
      info	[Changelog]   - Operation ZonesOperations.list has a new signature
      info	[Changelog]   - Operation ZonesOperations.get has a new signature
      info	[Changelog]   - Operation ZonesOperations.create_or_update has a new signature
      info	[Changelog]   - Operation RecordSetsOperations.update has a new signature
      info	[Changelog]   - Operation RecordSetsOperations.list_by_type has a new signature
      info	[Changelog]   - Operation RecordSetsOperations.list_by_dns_zone has a new signature
      info	[Changelog]   - Operation RecordSetsOperations.list_all_by_dns_zone has a new signature
      info	[Changelog]   - Operation RecordSetsOperations.get has a new signature
      info	[Changelog]   - Operation RecordSetsOperations.delete has a new signature
      info	[Changelog]   - Operation RecordSetsOperations.create_or_update has a new signature
      info	[Changelog]   - Model RecordSet no longer has parameter a_records
      info	[Changelog]   - Operation DnsResourceReferenceOperations.get_by_target_resources has a new signature
      info	[Changelog]   - Removed operation ZonesOperations.begin_delete
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 6fa6101. SDK Automation 14.0.0
      command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️dns/mgmt/2018-05-01/dns [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    • ️✔️dns/mgmt/2017-10-01/dns [View full logs]  [Release SDK Changes]
      info	[Changelog] ### New Content
      info	[Changelog]
      info	[Changelog] - New const `Public`
      info	[Changelog] - New const `Private`
      info	[Changelog] - New function `ZoneProperties.MarshalJSON() ([]byte, error)`
      info	[Changelog] - New function `PossibleZoneTypeValues() []ZoneType`
      info	[Changelog] - New field `ZoneType` in struct `ZoneProperties`
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 5 additive change(s).
      info	[Changelog]
    • ️✔️dns/mgmt/2017-09-01/dns [View full logs]  [Release SDK Changes]
      info	[Changelog] ### New Content
      info	[Changelog]
      info	[Changelog] - New const `Private`
      info	[Changelog] - New const `Public`
      info	[Changelog] - New function `ZoneProperties.MarshalJSON() ([]byte, error)`
      info	[Changelog] - New function `PossibleZoneTypeValues() []ZoneType`
      info	[Changelog] - New field `ZoneType` in struct `ZoneProperties`
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 5 additive change(s).
      info	[Changelog]
    • ️✔️dns/mgmt/2016-04-01/dns [View full logs]  [Release SDK Changes]
      info	[Changelog] ### New Content
      info	[Changelog]
      info	[Changelog] - New const `Private`
      info	[Changelog] - New const `Public`
      info	[Changelog] - New function `PossibleZoneTypeValues() []ZoneType`
      info	[Changelog] - New field `ZoneType` in struct `ZoneProperties`
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 4 additive change(s).
      info	[Changelog]
    • ️✔️preview/dns/mgmt/2018-03-01-preview/dns [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    • ️✔️preview/dns/mgmt/2015-05-04-preview/dns [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog] - Field `Properties` of struct `RecordSet` has been removed
      info	[Changelog] - Field `Tags` of struct `RecordSet` has been removed
      info	[Changelog] - Field `Location` of struct `RecordSet` has been removed
      info	[Changelog]
      info	[Changelog] ### New Content
      info	[Changelog]
      info	[Changelog] - New function `RecordSetProperties.MarshalJSON() ([]byte, error)`
      info	[Changelog] - New function `*RecordSet.UnmarshalJSON([]byte) error`
      info	[Changelog] - New function `ZoneProperties.MarshalJSON() ([]byte, error)`
      info	[Changelog] - New struct `CloudError`
      info	[Changelog] - New struct `CloudErrorBody`
      info	[Changelog] - New field `Fqdn` in struct `RecordSetProperties`
      info	[Changelog] - New anonymous field `*RecordSetProperties` in struct `RecordSet`
      info	[Changelog] - New field `MaxNumberOfRecordsPerRecordSet` in struct `ZoneProperties`
      info	[Changelog]
      info	[Changelog] Total 1 breaking change(s), 10 additive change(s).
      info	[Changelog]
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 6fa6101. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️track2_azure-mgmt-dns [View full logs]  [Release SDK Changes]
      info	[Changelog]
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 6fa6101. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
      cmderr	[generate.py] 2021-04-14 07:06:00 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-dns-generated"
      cmderr	[generate.py] 2021-04-14 07:06:00 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
      cmderr	[generate.py] 2021-04-14 07:06:00 INFO autorest --version=3.1.3 --use=@autorest/[email protected] --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/dns/azure-resourcemanager-dns-generated --java.namespace=com.azure.resourcemanager.dns.generated   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/dns/resource-manager/readme.md
      cmderr	[generate.py] 2021-04-14 07:06:22 INFO [CI][Success] Write to ci.yml
      cmderr	[generate.py] 2021-04-14 07:06:22 INFO [POM][Process] dealing with pom.xml
      cmderr	[generate.py] 2021-04-14 07:06:22 INFO [POM][Skip] pom already has module azure-resourcemanager-dns-generated
      cmderr	[generate.py] 2021-04-14 07:06:22 INFO [POM][Success] Write to pom.xml
      cmderr	[generate.py] 2021-04-14 07:06:22 INFO [POM][Process] dealing with root pom
      cmderr	[generate.py] 2021-04-14 07:06:22 INFO [POM][Success] Write to root pom
    • ️✔️azure-resourcemanager-dns-generated [View full logs]  [Release SDK Changes]
      cmderr	[Inst] 2021-04-14 07:08:24 DEBUG Got artifact_id: azure-resourcemanager-dns-generated
      cmderr	[Inst] 2021-04-14 07:08:24 DEBUG Got artifact: pom.xml
      cmderr	[Inst] 2021-04-14 07:08:24 DEBUG Got artifact: azure-resourcemanager-dns-generated-1.0.0-beta.1-sources.jar
      cmderr	[Inst] 2021-04-14 07:08:24 DEBUG Got artifact: azure-resourcemanager-dns-generated-1.0.0-beta.1.jar
      cmderr	[Inst] 2021-04-14 07:08:24 DEBUG Match jar package: azure-resourcemanager-dns-generated-1.0.0-beta.1.jar
      cmderr	[Inst] 2021-04-14 07:08:24 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/13923/azure-sdk-for-java/azure-resourcemanager-dns-generated/azure-resourcemanager-dns-generated-1.0.0-beta.1.jar\" -o azure-resourcemanager-dns-generated-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-dns-generated -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-dns-generated-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true
      ```"}
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 6fa6101. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/dns/resource-manager/readme.md
    • ️✔️@azure/arm-dns [View full logs]  [Release SDK Changes]
      cmderr	[npmPack] loaded rollup.config.js with warnings
      cmderr	[npmPack] (!) Unused external imports
      cmderr	[npmPack] default imported from external module 'rollup' but never used
      cmderr	[npmPack] ./esm/dnsManagementClient.js → ./dist/arm-dns.js...
      cmderr	[npmPack] created ./dist/arm-dns.js in 318ms
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 6fa6101. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh]  read-shrinkwrap This version of npm is compatible with lockfileVersion@1, but package-lock.json was generated for lockfileVersion@2. I'll try to do my best with it!
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
      warn	No file changes detected after generation
      warn	Skip detect changed packages
    ️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    3 participants