Skip to content

[Hub Generated] Review request for Microsoft.Consumption to add version stable/2019-05-01#13800

Merged
akning-ms merged 2 commits intoAzure:masterfrom
omrodrig:dev-consumption-Microsoft.Consumption-2019-05-01
Apr 8, 2021
Merged

[Hub Generated] Review request for Microsoft.Consumption to add version stable/2019-05-01#13800
akning-ms merged 2 commits intoAzure:masterfrom
omrodrig:dev-consumption-Microsoft.Consumption-2019-05-01

Conversation

@omrodrig
Copy link
Contributor

@omrodrig omrodrig commented Apr 6, 2021

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
  3. When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
  4. If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No, no need to refresh for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently.
    • Adding a new service
  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@omrodrig omrodrig requested a review from kjeur as a code owner April 6, 2021 21:17
@openapi-workflow-bot
Copy link

Hi, @omrodrig Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Apr 6, 2021

    Swagger Validation Report

    ️❌BreakingChange: 7 Errors, 0 Warnings failed [Detail]
    Rule Message
    1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'Filters' removed or renamed?
    New: Microsoft.Consumption/stable/2019-05-01/consumption.json#L1326:3
    Old: Microsoft.Consumption/stable/2019-05-01/consumption.json#L1326:3
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'filters' renamed or removed?
    New: Microsoft.Consumption/stable/2019-05-01/consumption.json#L2325:7
    Old: Microsoft.Consumption/stable/2019-05-01/consumption.json#L2325:7
    1036 - ConstraintChanged The new version has a different 'minItems' value than the previous one.
    New: Microsoft.Consumption/stable/2019-05-01/consumption.json#L2494:9
    Old: Microsoft.Consumption/stable/2019-05-01/consumption.json#L2494:9
    1037 - ConstraintIsWeaker The new version has a less constraining 'minItems' value than the previous one.
    New: Microsoft.Consumption/stable/2019-05-01/consumption.json#L2494:9
    Old: Microsoft.Consumption/stable/2019-05-01/consumption.json#L2494:9
    1041 - AddedPropertyInResponse The new version has a new property 'thresholdType' in response that was not found in the old version.
    New: Microsoft.Consumption/stable/2019-05-01/consumption.json#L2471:7
    Old: Microsoft.Consumption/stable/2019-05-01/consumption.json#L2471:7
    1041 - AddedPropertyInResponse The new version has a new property 'filter' in response that was not found in the old version.
    New: Microsoft.Consumption/stable/2019-05-01/consumption.json#L2325:7
    Old: Microsoft.Consumption/stable/2019-05-01/consumption.json#L2325:7
    1045 - AddedOptionalProperty The new version has a new optional property 'filter' that was not found in the old version.
    New: Microsoft.Consumption/stable/2019-05-01/consumption.json#L2325:7
    Old: Microsoft.Consumption/stable/2019-05-01/consumption.json#L2325:7
    ️⚠️LintDiff: 0 Warnings warning [Detail]
    The following errors/warnings exist before current PR submission:

    Only 10 items are listed, please refer to log for more details.

    Rule Message
    R3020 - PathResourceProviderNamePascalCase Resource provider naming must follow the pascal case. Path: '/providers/Microsoft.Billing/billingAccounts/{billingAccountId}/providers/microsoft.consumption/ReservationRecommendations'
    Location: azure-rest-api-specs/blob/e2c7eac5a02ba0efed543b84fc4bfafe4d798e24/undefined#Lundefined
    R3021 - PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/providers/Microsoft.Billing/billingAccounts/{billingAccountId}/providers/microsoft.consumption/ReservationRecommendations'
    Location: azure-rest-api-specs/blob/e2c7eac5a02ba0efed543b84fc4bfafe4d798e24/undefined#Lundefined
    R3021 - PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/providers/Microsoft.Management/managementGroups/{managementGroupId}/providers/Microsoft.Billing/billingPeriods/{billingPeriodName}/Microsoft.Consumption/aggregatedcost'
    Location: azure-rest-api-specs/blob/e2c7eac5a02ba0efed543b84fc4bfafe4d798e24/undefined#Lundefined
    R3030 - PathResourceProviderMatchNamespace The last resource provider 'Microsoft.Consumption, microsoft.consumption, Microsoft.Billing' doesn't match the namespace.
    Location: azure-rest-api-specs/blob/e2c7eac5a02ba0efed543b84fc4bfafe4d798e24/undefined#Lundefined
    R4011 - DeleteOperationResponses The delete operation is defined without a 200 or 204 error response implementation,please add it.'
    Location: azure-rest-api-specs/blob/e2c7eac5a02ba0efed543b84fc4bfafe4d798e24/undefined#Lundefined
    R4013 - IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: azure-rest-api-specs/blob/e2c7eac5a02ba0efed543b84fc4bfafe4d798e24/undefined#Lundefined
    R4013 - IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: azure-rest-api-specs/blob/e2c7eac5a02ba0efed543b84fc4bfafe4d798e24/undefined#Lundefined
    R4013 - IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: azure-rest-api-specs/blob/e2c7eac5a02ba0efed543b84fc4bfafe4d798e24/undefined#Lundefined
    R4013 - IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: azure-rest-api-specs/blob/e2c7eac5a02ba0efed543b84fc4bfafe4d798e24/undefined#Lundefined
    R4013 - IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: azure-rest-api-specs/blob/e2c7eac5a02ba0efed543b84fc4bfafe4d798e24/undefined#Lundefined
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand]
    Validation passes for SDKTrack2Validation

    ️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Apr 6, 2021

    Swagger Generation Artifacts

    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from e564455. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️track2_azure-mgmt-consumption [View full logs]  [Release SDK Changes]
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Model LegacyChargeSummary has a new parameter etag
      info	[Changelog]   - Model ReservationRecommendationDetailsModel has a new parameter etag
      info	[Changelog]   - Model PriceSheetResult has a new parameter download
      info	[Changelog]   - Model PriceSheetResult has a new parameter etag
      info	[Changelog]   - Model CreditSummary has a new parameter etag
      info	[Changelog]   - Model Operation has a new parameter id
      info	[Changelog]   - Model OperationDisplay has a new parameter description
      info	[Changelog]   - Model TagsResult has a new parameter next_link
      info	[Changelog]   - Model TagsResult has a new parameter previous_link
      info	[Changelog]   - Model ModernChargeSummary has a new parameter etag
      info	[Changelog]   - Model ReservationDetail has a new parameter etag
      info	[Changelog]   - Model ReservationRecommendation has a new parameter etag
      info	[Changelog]   - Model ModernUsageDetail has a new parameter pay_g_price
      info	[Changelog]   - Model ModernUsageDetail has a new parameter etag
      info	[Changelog]   - Model Tag has a new parameter value
      info	[Changelog]   - Model Balance has a new parameter etag
      info	[Changelog]   - Model ModernReservationRecommendation has a new parameter sku_name
      info	[Changelog]   - Model ModernReservationRecommendation has a new parameter location_properties_location
      info	[Changelog]   - Model ModernReservationRecommendation has a new parameter etag
      info	[Changelog]   - Model LotSummary has a new parameter etag
      info	[Changelog]   - Model LegacyUsageDetail has a new parameter etag
      info	[Changelog]   - Model ReservationRecommendationsListResult has a new parameter previous_link
      info	[Changelog]   - Model ManagementGroupAggregatedCostResult has a new parameter etag
      info	[Changelog]   - Model UsageDetail has a new parameter etag
      info	[Changelog]   - Model ReservationSummary has a new parameter etag
      info	[Changelog]   - Model Resource has a new parameter etag
      info	[Changelog]   - Model Forecast has a new parameter etag
      info	[Changelog]   - Model EventSummary has a new parameter etag
      info	[Changelog]   - Model Marketplace has a new parameter additional_info
      info	[Changelog]   - Model Marketplace has a new parameter etag
      info	[Changelog]   - Model LegacyReservationRecommendation has a new parameter resource_type
      info	[Changelog]   - Model LegacyReservationRecommendation has a new parameter etag
      info	[Changelog]   - Model Budget has a new parameter forecast_spend
      info	[Changelog]   - Model ChargeSummary has a new parameter etag
      info	[Changelog]   - Added operation ReservationRecommendationDetailsOperations.get
    ️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from e564455. Schema Automation 14.0.0
      warn	Skip initScript due to not configured
      command	npx n 12
      command	autorest --use=@autorest/azureresourceschema@3.0.92 --version=3.0.6374 --azureresourceschema --multiapi --title=none --pass-thru:subset-reducer --azureresourceschema-folder=/home/vsts/work/1/s/azure-resource-manager-schemas/azure-resource-manager-schemas ../../azure-rest-api-specs/specification/consumption/resource-manager/readme.md
    • ️✔️consumption [View full logs]  [Release Schema Changes]
      cmderr	[resource-manager] node-pre-gyp
      cmderr	[resource-manager] WARN Using request for node-pre-gyp https download
      cmderr	[resource-manager]  WARN template-schema-validation-tools@1.0.0 No repository field.
      cmderr	[resource-manager] optional SKIPPING OPTIONAL DEPENDENCY: fsevents@2.1.3 (node_modules/fsevents):
      cmderr	[resource-manager] npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@2.1.3: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from e564455. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.4.4 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/consumption/resource-manager/readme.md
    • ️✔️@azure/arm-consumption [View full logs]  [Release SDK Changes]
      cmderr	[npmPack] loaded rollup.config.js with warnings
      cmderr	[npmPack] (!) Unused external imports
      cmderr	[npmPack] default imported from external module 'rollup' but never used
      cmderr	[npmPack] ./esm/consumptionManagementClient.js → ./dist/arm-consumption.js...
      cmderr	[npmPack] created ./dist/arm-consumption.js in 568ms
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from e564455. SDK Automation 14.0.0
      command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️consumption/mgmt/2019-10-01/consumption [View full logs]  [Release SDK Changes] Breaking Change Detected
      Only show 11 items here, please refer to log for details.
      info	[Changelog] - New field `PreviousLink` in struct `ReservationRecommendationsListResult`
      info	[Changelog] - New field `Etag` in struct `ModernReservationRecommendation`
      info	[Changelog] - New field `Etag` in struct `Forecast`
      info	[Changelog] - New field `Etag` in struct `Resource`
      info	[Changelog] - New field `Etag` in struct `Balance`
      info	[Changelog] - New field `Etag` in struct `LegacyChargeSummary`
      info	[Changelog] - New field `NextLink` in struct `TagProperties`
      info	[Changelog] - New field `PreviousLink` in struct `TagProperties`
      info	[Changelog]
      info	[Changelog] Total 19 breaking change(s), 76 additive change(s).
      info	[Changelog]
    • ️✔️consumption/mgmt/2019-01-01/consumption [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    • ️✔️consumption/mgmt/2018-10-01/consumption [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    • ️✔️consumption/mgmt/2018-08-31/consumption [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    • ️✔️consumption/mgmt/2018-06-30/consumption [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    • ️✔️consumption/mgmt/2018-05-31/consumption [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    • ️✔️consumption/mgmt/2018-03-31/consumption [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    • ️✔️consumption/mgmt/2018-01-31/consumption [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    • ️✔️consumption/mgmt/2017-11-30/consumption [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    • ️✔️preview/consumption/mgmt/2017-12-30-preview/consumption [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    • ️✔️preview/consumption/mgmt/2017-04-24-preview/consumption [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    ️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from e564455. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	sudo apt-get install -y dotnet-sdk-5.0
      command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/consumption/resource-manager/readme.md
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
    • ️✔️Microsoft.Azure.Management.Consumption [View full logs]  [Release SDK Changes]
    ️⚠️ azure-sdk-for-python warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from e564455. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️azure-mgmt-consumption [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Model Notification has a new parameter threshold_type
      info	[Changelog]   - Model Forecast has a new parameter etag
      info	[Changelog]   - Model OperationDisplay has a new parameter description
      info	[Changelog]   - Model Tag has a new parameter value
      info	[Changelog]   - Model ReservationSummary has a new parameter used_quantity
      info	[Changelog]   - Model ReservationSummary has a new parameter utilized_percentage
      info	[Changelog]   - Model ReservationSummary has a new parameter total_reserved_quantity
      info	[Changelog]   - Model ReservationSummary has a new parameter kind
      info	[Changelog]   - Model ReservationSummary has a new parameter etag
      info	[Changelog]   - Model ReservationSummary has a new parameter purchased_quantity
      info	[Changelog]   - Model ReservationSummary has a new parameter remaining_quantity
      info	[Changelog]   - Model Balance has a new parameter etag
      info	[Changelog]   - Model TagsResult has a new parameter previous_link
      info	[Changelog]   - Model TagsResult has a new parameter next_link
      info	[Changelog]   - Model Budget has a new parameter filter
      info	[Changelog]   - Model Budget has a new parameter forecast_spend
      info	[Changelog]   - Model Operation has a new parameter id
      info	[Changelog]   - Model Resource has a new parameter etag
      info	[Changelog]   - Model ManagementGroupAggregatedCostResult has a new parameter etag
      info	[Changelog]   - Model PriceSheetResult has a new parameter download
      info	[Changelog]   - Model PriceSheetResult has a new parameter etag
      info	[Changelog]   - Model Marketplace has a new parameter additional_info
      info	[Changelog]   - Model Marketplace has a new parameter etag
      info	[Changelog]   - Model ReservationDetail has a new parameter instance_flexibility_group
      info	[Changelog]   - Model ReservationDetail has a new parameter kind
      info	[Changelog]   - Model ReservationDetail has a new parameter etag
      info	[Changelog]   - Model ReservationDetail has a new parameter instance_flexibility_ratio
      info	[Changelog]   - Added operation ReservationsDetailsOperations.list
      info	[Changelog]   - Added operation ReservationsSummariesOperations.list
      info	[Changelog]   - Added operation ReservationRecommendationsOperations.list
      info	[Changelog]   - Added operation ChargesOperations.list
      info	[Changelog]   - Added operation group ReservationTransactionsOperations
      info	[Changelog]   - Added operation group ReservationRecommendationDetailsOperations
      info	[Changelog]   - Added operation group CreditsOperations
      info	[Changelog]   - Added operation group EventsOperations
      info	[Changelog]   - Added operation group LotsOperations
      info	[Changelog]
      info	[Changelog] **Breaking changes**
      info	[Changelog]
      info	[Changelog]   - Model Budget no longer has parameter filters
      info	[Changelog]   - Model UsageDetail has a new signature
      info	[Changelog]   - Model ChargeSummary has a new signature
      info	[Changelog]   - Model ReservationRecommendation has a new signature
      info	[Changelog]   - Removed operation UsageDetailsOperations.download
      info	[Changelog]   - Removed operation ChargesOperations.list_by_scope
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from e564455. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
      cmderr	[generate.py] 2021-04-08 00:33:14 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-consumption"
      cmderr	[generate.py] 2021-04-08 00:33:14 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
      cmderr	[generate.py] 2021-04-08 00:33:14 INFO autorest --version=3.1.3 --use=@autorest/java@4.0.23 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/consumption/azure-resourcemanager-consumption --java.namespace=com.azure.resourcemanager.consumption   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/consumption/resource-manager/readme.md
      cmderr	[generate.py] 2021-04-08 00:33:50 INFO [CI][Success] Write to ci.yml
      cmderr	[generate.py] 2021-04-08 00:33:50 INFO [POM][Process] dealing with pom.xml
      cmderr	[generate.py] 2021-04-08 00:33:50 INFO [POM][Skip] pom already has module azure-resourcemanager-consumption
      cmderr	[generate.py] 2021-04-08 00:33:50 INFO [POM][Success] Write to pom.xml
      cmderr	[generate.py] 2021-04-08 00:33:50 INFO [POM][Process] dealing with root pom
      cmderr	[generate.py] 2021-04-08 00:33:50 INFO [POM][Success] Write to root pom
    • ️✔️azure-resourcemanager-consumption [View full logs]  [Release SDK Changes]
      cmderr	[Inst] 2021-04-08 00:36:46 DEBUG Got artifact_id: azure-resourcemanager-consumption
      cmderr	[Inst] 2021-04-08 00:36:46 DEBUG Got artifact: pom.xml
      cmderr	[Inst] 2021-04-08 00:36:46 DEBUG Got artifact: azure-resourcemanager-consumption-1.0.0-beta.1.jar
      cmderr	[Inst] 2021-04-08 00:36:46 DEBUG Match jar package: azure-resourcemanager-consumption-1.0.0-beta.1.jar
      cmderr	[Inst] 2021-04-08 00:36:46 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/13800/azure-sdk-for-java/azure-resourcemanager-consumption/azure-resourcemanager-consumption-1.0.0-beta.1.jar\" -o azure-resourcemanager-consumption-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-consumption -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-consumption-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true
      ```"}
    ️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    Hi @omrodrig, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.

    @openapi-workflow-bot
    Copy link

    NewApiVersionRequired reason:

    A service’s API is a contract with customers and is represented by using the api-version query parameter. Changes such as adding an optional property to a request/response or introducing a new operation is a change to the service’s contract and therefore requires a new api-version value. This is critically important for documentation, client libraries, and customer support.

    EXAMPLE: if a customer calls a service in the public cloud using api-version=2020-07-27, the new property or operation may exist but if they call the service in a government cloud, air-gapped cloud, or Azure Stack Hub cloud using the same api-version, the property or operation may not exist. Because there is no clear relationship between the service api-version and the new property/operation, customers can’t trust the documentation and Azure customer have difficulty helping customers diagnose issues. In addition, each client library version documents the service version it supports. When an optional property or new operation is added to a service and its Swagger, new client libraries must be produced to expose this functionality to customers. Without updating the api-version, it is unclear to customers which version of a client library supports these new features.

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 CI-BreakingChange-Go CI-BreakingChange-Python FixS360

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    3 participants