[Hub Generated] Review request for Microsoft.Consumption to add version stable/2019-05-01#13800
Conversation
|
Hi, @omrodrig Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Validation Report
|
| Rule | Message |
|---|---|
R3020 - PathResourceProviderNamePascalCase |
Resource provider naming must follow the pascal case. Path: '/providers/Microsoft.Billing/billingAccounts/{billingAccountId}/providers/microsoft.consumption/ReservationRecommendations' Location: azure-rest-api-specs/blob/e2c7eac5a02ba0efed543b84fc4bfafe4d798e24/undefined#Lundefined |
R3021 - PathResourceTypeNameCamelCase |
Resource type naming must follow camel case. Path: '/providers/Microsoft.Billing/billingAccounts/{billingAccountId}/providers/microsoft.consumption/ReservationRecommendations' Location: azure-rest-api-specs/blob/e2c7eac5a02ba0efed543b84fc4bfafe4d798e24/undefined#Lundefined |
R3021 - PathResourceTypeNameCamelCase |
Resource type naming must follow camel case. Path: '/providers/Microsoft.Management/managementGroups/{managementGroupId}/providers/Microsoft.Billing/billingPeriods/{billingPeriodName}/Microsoft.Consumption/aggregatedcost' Location: azure-rest-api-specs/blob/e2c7eac5a02ba0efed543b84fc4bfafe4d798e24/undefined#Lundefined |
R3030 - PathResourceProviderMatchNamespace |
The last resource provider 'Microsoft.Consumption, microsoft.consumption, Microsoft.Billing' doesn't match the namespace. Location: azure-rest-api-specs/blob/e2c7eac5a02ba0efed543b84fc4bfafe4d798e24/undefined#Lundefined |
R4011 - DeleteOperationResponses |
The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: azure-rest-api-specs/blob/e2c7eac5a02ba0efed543b84fc4bfafe4d798e24/undefined#Lundefined |
R4013 - IntegerTypeMustHaveFormat |
The integer type does not have a format, please add it. Location: azure-rest-api-specs/blob/e2c7eac5a02ba0efed543b84fc4bfafe4d798e24/undefined#Lundefined |
R4013 - IntegerTypeMustHaveFormat |
The integer type does not have a format, please add it. Location: azure-rest-api-specs/blob/e2c7eac5a02ba0efed543b84fc4bfafe4d798e24/undefined#Lundefined |
R4013 - IntegerTypeMustHaveFormat |
The integer type does not have a format, please add it. Location: azure-rest-api-specs/blob/e2c7eac5a02ba0efed543b84fc4bfafe4d798e24/undefined#Lundefined |
R4013 - IntegerTypeMustHaveFormat |
The integer type does not have a format, please add it. Location: azure-rest-api-specs/blob/e2c7eac5a02ba0efed543b84fc4bfafe4d798e24/undefined#Lundefined |
R4013 - IntegerTypeMustHaveFormat |
The integer type does not have a format, please add it. Location: azure-rest-api-specs/blob/e2c7eac5a02ba0efed543b84fc4bfafe4d798e24/undefined#Lundefined |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation
- The following tags are being changed in this PR
️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
Swagger Generation Artifacts
|
|
Hi @omrodrig, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
|
NewApiVersionRequired reason: |
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.