Closed
Conversation
|
Hi, @wwendyc Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Validation Report
|
| Rule | Message |
|---|---|
|
Please provide x-ms-examples describing minimum/maximum property set for response/request payloads for operations. Operation: 'ResourceLinks_Delete' Location: Microsoft.Resources/stable/2016-09-01/links.json#L63 |
|
Please provide x-ms-examples describing minimum/maximum property set for response/request payloads for operations. Operation: 'ResourceLinks_CreateOrUpdate' Location: Microsoft.Resources/stable/2016-09-01/links.json#L91 |
|
Please provide x-ms-examples describing minimum/maximum property set for response/request payloads for operations. Operation: 'ResourceLinks_Get' Location: Microsoft.Resources/stable/2016-09-01/links.json#L134 |
|
Please provide x-ms-examples describing minimum/maximum property set for response/request payloads for operations. Operation: 'ResourceLinks_ListAtSubscription' Location: Microsoft.Resources/stable/2016-09-01/links.json#L164 |
|
Please provide x-ms-examples describing minimum/maximum property set for response/request payloads for operations. Operation: 'ResourceLinks_ListAtSourceScope' Location: Microsoft.Resources/stable/2016-09-01/links.json#L200 |
|
Properties of a PATCH request body must not be required. PATCH operation: 'Applications_UpdateById' Model Definition: 'Application' Property: 'properties' Location: Microsoft.Solutions/stable/2018-06-01/managedapplications.json#L1021 |
|
Properties of a PATCH request body must not be required. PATCH operation: 'Applications_UpdateById' Model Definition: 'Application' Property: 'kind' Location: Microsoft.Solutions/stable/2018-06-01/managedapplications.json#L1021 |
|
Inline/anonymous models must not be used, instead define a schema with a model name in the 'definitions' section and refer to it. This allows operations to share the models. Location: Microsoft.Resources/stable/2021-01-01/resources.json#L5514 |
|
The last resource provider 'Microsoft.Resources, Microsoft.Management' doesn't match the namespace. Location: Microsoft.Resources/stable/2021-01-01/resources.json#L36 |
|
the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content. Location: Microsoft.Solutions/stable/2018-06-01/managedapplications.json#L116 |
️❌Avocado: 33 Errors, 0 Warnings failed [Detail]
Only 10 items are listed, please refer to log for more details.
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]
There are no breaking changes.
- Compared Swaggers (Based on Oad v0.8.9)
- original: stable/2021-01-01/resources.json <---> new: stable/2021-04-01/resources.json
- original: stable/2021-01-01/subscriptions.json <---> new: stable/2021-04-01/subscriptions.json
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️[Staging] SDK Track2 Validation: 2 Warnings warning [Detail]
- The following tags are being changed in this PR
| Rule | Message |
|---|---|
| "readme":"providerhub/resource-manager/readme.md", "tag":"package-2020-11-20", "details":"The schema 'ResourceType-metadata' has no type or format information whatsoever. Location:\n file:///home/vsts/work/1/azure-rest-api-specs/specification/providerhub/resource-manager/Microsoft.ProviderHub/stable/2020-11-20/providerhub.json#/components/schemas/ResourceType-metadata" |
|
| "readme":"providerhub/resource-manager/readme.md", "tag":"package-2020-11-20", "details":"The schema 'OperationsDefinition-properties' has no type or format information whatsoever. Location:\n file:///home/vsts/work/1/azure-rest-api-specs/specification/providerhub/resource-manager/Microsoft.ProviderHub/stable/2020-11-20/providerhub.json#/components/schemas/OperationsDefinition-properties" |
|
| 💬 AutorestCore/Exception | "readme":"providerhub/resource-manager/readme.md", "tag":"package-2020-11-20", "details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)" |
| 💬 AutorestCore/Exception | "readme":"providerhub/resource-manager/readme.md", "tag":"package-2020-11-20", "details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)" |
The following errors/warnings exist before current PR submission:
| Rule | Message |
|---|---|
|
"readme":"providerhub/resource-manager/readme.md", "tag":"package-2020-11-20", "details":"Error: Plugin pre-namer reported failure." |
| 💬 AutorestCore/Exception | "readme":"providerhub/resource-manager/readme.md", "tag":"package-2020-11-20", "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)" |
️❌[Staging] PrettierCheck: 1 Errors, 0 Warnings failed [Detail]
| Rule | Message |
|---|---|
|
Code style issues found path: stable/2021-04-01/examples/GetProviderPermissions.json |
️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
Swagger Generation Artifacts
|
| Rule | Message |
|---|---|
|
"logUrl":"https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=210617&view=logs&j=fd490c07-0b22-5182-fac9-6d67fe1e939b", "detail":"Run.ps1 failed with exit code 1 " |
️❌ azure-sdk-for-net failed [Detail]
❌Failed [Logs] Generate from dd70268630abc25a114d1d9b675d6fa08accd324. SDK Automation 14.0.0warn Skip initScript due to not configured command sudo apt-get install -y dotnet-sdk-5.0 command autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/providerhub/resource-manager/readme.md cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied command autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/resources/resource-manager/readme.md cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied
❌Microsoft.Azure.Management.ProviderHub [View full logs] [Preview SDK Changes]cmdout [msbuild] /home/vsts/work/1/s/azure-sdk-for-net/sdk/providerhub/Microsoft.Azure.Management.ProviderHub/tests/ScenarioTests/ProviderRegistrationTests.cs(28,54): error CS0246: The type or namespace name 'ProviderHubMetadataProviderAuthentication' could not be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/providerhub/Microsoft.Azure.Management.ProviderHub/tests/Microsoft.Azure.Management.ProviderHub.Tests.csproj] cmdout [msbuild] /home/vsts/work/1/s/azure-sdk-for-net/sdk/providerhub/Microsoft.Azure.Management.ProviderHub/tests/ScenarioTests/ProviderRegistrationTests.cs(28,54): error CS0246: The type or namespace name 'ProviderHubMetadataProviderAuthentication' could not be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/providerhub/Microsoft.Azure.Management.ProviderHub/tests/Microsoft.Azure.Management.ProviderHub.Tests.csproj] error Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-net]: dotnet
️✔️Microsoft.Azure.Management.ResourceManager [View full logs] [Preview SDK Changes]
️⚠️ azure-sdk-for-python-track2 warning [Detail]
⚠️Warning [Logs] Generate from dd70268630abc25a114d1d9b675d6fa08accd324. SDK Automation 14.0.0command sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json cmderr [automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed. warn specification/providerhub/resource-manager/readme.md skipped due to azure-sdk-for-python-track2 not found in swagger-to-sdk command sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
️✔️track2_azure-mgmt-resource [View full logs] [Preview SDK Changes] Breaking Change Detectedinfo [Changelog] **Features** info [Changelog] info [Changelog] - Model TemplateSpecVersion has a new parameter ui_form_definition info [Changelog] - Model TemplateSpecVersion has a new parameter metadata info [Changelog] - Model TemplateSpecVersion has a new parameter main_template info [Changelog] - Model TemplateSpecVersion has a new parameter linked_templates info [Changelog] - Model TemplateSpec has a new parameter metadata info [Changelog] info [Changelog] **Breaking changes** info [Changelog] info [Changelog] - Model TemplateSpecVersion no longer has parameter template info [Changelog] - Model TemplateSpecVersion no longer has parameter artifacts
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
️✔️Succeeded [Logs] Generate from dd70268630abc25a114d1d9b675d6fa08accd324. SDK Automation 14.0.0warn Skip initScript due to not configured command autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.4.4 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/providerhub/resource-manager/readme.md command autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.4.4 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/resources/resource-manager/readme.md
️✔️@azure/arm-features [View full logs] [Preview SDK Changes]cmderr [npmPack] loaded rollup.config.js with warnings cmderr [npmPack] (!) Unused external imports cmderr [npmPack] default imported from external module 'rollup' but never used cmderr [npmPack] ./esm/featureClient.js → ./dist/arm-features.js... cmderr [npmPack] created ./dist/arm-features.js in 151ms
️✔️@azure/arm-links [View full logs] [Preview SDK Changes]cmderr [npmPack] loaded rollup.config.js with warnings cmderr [npmPack] (!) Unused external imports cmderr [npmPack] default imported from external module 'rollup' but never used cmderr [npmPack] ./esm/managementLinkClient.js → ./dist/arm-links.js... cmderr [npmPack] created ./dist/arm-links.js in 159ms
️✔️@azure/arm-locks [View full logs] [Preview SDK Changes]cmderr [npmPack] loaded rollup.config.js with warnings cmderr [npmPack] (!) Unused external imports cmderr [npmPack] default imported from external module 'rollup' but never used cmderr [npmPack] ./esm/managementLockClient.js → ./dist/arm-locks.js... cmderr [npmPack] created ./dist/arm-locks.js in 216ms
️✔️@azure/arm-managedapplications [View full logs] [Preview SDK Changes]cmderr [npmPack] loaded rollup.config.js with warnings cmderr [npmPack] (!) Unused external imports cmderr [npmPack] default imported from external module 'rollup' but never used cmderr [npmPack] ./esm/applicationClient.js → ./dist/arm-managedapplications.js... cmderr [npmPack] created ./dist/arm-managedapplications.js in 291ms
️✔️@azure/arm-policy [View full logs] [Preview SDK Changes]cmderr [npmPack] loaded rollup.config.js with warnings cmderr [npmPack] (!) Unused external imports cmderr [npmPack] default imported from external module 'rollup' but never used cmderr [npmPack] ./esm/policyClient.js → ./dist/arm-policy.js... cmderr [npmPack] created ./dist/arm-policy.js in 362ms
️✔️@azure/arm-resources [View full logs] [Preview SDK Changes]cmderr [npmPack] loaded rollup.config.js with warnings cmderr [npmPack] (!) Unused external imports cmderr [npmPack] default imported from external module 'rollup' but never used cmderr [npmPack] ./esm/resourceManagementClient.js → ./dist/arm-resources.js... cmderr [npmPack] created ./dist/arm-resources.js in 566ms
️⚠️ azure-sdk-for-python warning [Detail]
⚠️Warning [Logs] Generate from dd70268630abc25a114d1d9b675d6fa08accd324. SDK Automation 14.0.0command sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json cmderr [automation_init.sh] ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts. cmderr [automation_init.sh] azure-mgmt-core 1.2.2 requires azure-core<2.0.0,>=1.9.0, but you have azure-core 1.6.0 which is incompatible. cmderr [automation_init.sh] ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts. cmderr [automation_init.sh] azure-mgmt-core 1.2.2 requires azure-core<2.0.0,>=1.9.0, but you have azure-core 1.6.0 which is incompatible. cmderr [automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed. warn specification/resources/resource-manager/readme.md skipped due to azure-sdk-for-python not found in swagger-to-sdk command sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json warn No package detected after generation
️⚠️ azure-sdk-for-java warning [Detail]
⚠️Warning [Logs] Generate from dd70268630abc25a114d1d9b675d6fa08accd324. SDK Automation 14.0.0command ./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json command ./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json cmderr [generate.py] 2021-04-23 23:31:21 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-providerhub" cmderr [generate.py] 2021-04-23 23:31:21 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1" cmderr [generate.py] 2021-04-23 23:31:21 INFO autorest --version=3.1.3 --use=@autorest/java@4.0.24 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/providerhub/azure-resourcemanager-providerhub --java.namespace=com.azure.resourcemanager.providerhub --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/providerhub/resource-manager/readme.md cmderr [generate.py] 2021-04-23 23:32:03 INFO [CI][Success] Write to ci.yml cmderr [generate.py] 2021-04-23 23:32:03 INFO [POM][Process] dealing with pom.xml cmderr [generate.py] 2021-04-23 23:32:03 INFO [POM][Skip] pom already has module azure-resourcemanager-providerhub cmderr [generate.py] 2021-04-23 23:32:03 INFO [POM][Success] Write to pom.xml cmderr [generate.py] 2021-04-23 23:32:03 INFO [POM][Process] dealing with root pom cmderr [generate.py] 2021-04-23 23:32:03 INFO [POM][Success] Write to root pom
️✔️azure-resourcemanager-providerhub [View full logs] [Preview SDK Changes]- pom.xml
- azure-resourcemanager-providerhub-1.0.0-beta.1.jar
- azure-resourcemanager-providerhub-1.0.0-beta.1-sources.jar
- azure-resourcemanager-providerhub-1.0.0-beta.1-javadoc.jar
cmderr [Inst] 2021-04-23 23:36:03 DEBUG Got artifact_id: azure-resourcemanager-providerhub cmderr [Inst] 2021-04-23 23:36:03 DEBUG Got artifact: pom.xml cmderr [Inst] 2021-04-23 23:36:03 DEBUG Got artifact: azure-resourcemanager-providerhub-1.0.0-beta.1.jar cmderr [Inst] 2021-04-23 23:36:03 DEBUG Match jar package: azure-resourcemanager-providerhub-1.0.0-beta.1.jar cmderr [Inst] 2021-04-23 23:36:03 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/13602/azure-sdk-for-java/azure-resourcemanager-providerhub/azure-resourcemanager-providerhub-1.0.0-beta.1.jar\" -o azure-resourcemanager-providerhub-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-providerhub -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-providerhub-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true ```"}️✔️azure-resourcemanager-resources-generated [View full logs] [Preview SDK Changes]- pom.xml
- azure-resourcemanager-resources-generated-1.0.0-beta.1.jar
- azure-resourcemanager-resources-generated-1.0.0-beta.1-javadoc.jar
- azure-resourcemanager-resources-generated-1.0.0-beta.1-sources.jar
cmderr [Inst] 2021-04-23 23:38:54 DEBUG Got artifact_id: azure-resourcemanager-resources-generated cmderr [Inst] 2021-04-23 23:38:54 DEBUG Got artifact: pom.xml cmderr [Inst] 2021-04-23 23:38:54 DEBUG Got artifact: azure-resourcemanager-resources-generated-1.0.0-beta.1.jar cmderr [Inst] 2021-04-23 23:38:54 DEBUG Match jar package: azure-resourcemanager-resources-generated-1.0.0-beta.1.jar cmderr [Inst] 2021-04-23 23:38:54 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/13602/azure-sdk-for-java/azure-resourcemanager-resources-generated/azure-resourcemanager-resources-generated-1.0.0-beta.1.jar\" -o azure-resourcemanager-resources-generated-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-resources-generated -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-resources-generated-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true ```"}
️⚠️ azure-resource-manager-schemas warning [Detail]
⚠️Warning [Logs] Generate from dd70268630abc25a114d1d9b675d6fa08accd324. Schema Automation 14.0.0command .sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json cmderr [initScript.sh] WARN read-shrinkwrap This version of npm is compatible with lockfileVersion@1, but package-lock.json was generated for lockfileVersion@2. I'll try to do my best with it! warn File azure-resource-manager-schemas_tmp/initOutput.json not found to read warn specification/providerhub/resource-manager/readme.md skipped due to azure-resource-manager-schemas not found in swagger-to-sdk command .sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json warn No file changes detected after generation warn Skip detect changed packages
️✔️resources [View full logs] [Preview Schema Changes]
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
️✔️Succeeded [Logs] Generate from dd70268630abc25a114d1d9b675d6fa08accd324. SDK Automation 14.0.0command sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json command go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
️✔️providerhub/mgmt/2020-11-20/providerhub [View full logs] [Preview SDK Changes]info [Changelog] This is a new package
️✔️resources/mgmt/2020-10-01/resources [View full logs] [Preview SDK Changes]info [Changelog] No exported changes
- Only show 4 items here, please refer to log for details.
️✔️resources/mgmt/2020-06-01/resources [View full logs] [Preview SDK Changes] Breaking Change Detectedinfo [Changelog] info [Changelog] info [Changelog] Total 2 breaking change(s), 0 additive change(s). info [Changelog]
️✔️resources/mgmt/2019-11-01/subscriptions [View full logs] [Preview SDK Changes]info [Changelog] No exported changes
️✔️resources/mgmt/2019-10-01/resources [View full logs] [Preview SDK Changes]info [Changelog] No exported changes
️✔️resources/mgmt/2019-09-01/policy [View full logs] [Preview SDK Changes]info [Changelog] No exported changes
️✔️resources/mgmt/2019-07-01/managedapplications [View full logs] [Preview SDK Changes]info [Changelog] No exported changes
️✔️resources/mgmt/2019-07-01/features [View full logs] [Preview SDK Changes]info [Changelog] No exported changes
️✔️resources/mgmt/2019-06-01/subscriptions [View full logs] [Preview SDK Changes]info [Changelog] No exported changes
️✔️resources/mgmt/2019-06-01/policy [View full logs] [Preview SDK Changes]info [Changelog] No exported changes
️✔️resources/mgmt/2019-05-01/resources [View full logs] [Preview SDK Changes]info [Changelog] No exported changes
️✔️resources/mgmt/2019-03-01/resources [View full logs] [Preview SDK Changes]info [Changelog] No exported changes
️✔️resources/mgmt/2019-01-01/policy [View full logs] [Preview SDK Changes]info [Changelog] No exported changes
️✔️resources/mgmt/2018-06-01/subscriptions [View full logs] [Preview SDK Changes]info [Changelog] No exported changes
️✔️resources/mgmt/2018-06-01/managedapplications [View full logs] [Preview SDK Changes]info [Changelog] No exported changes
️✔️resources/mgmt/2018-05-01/resources [View full logs] [Preview SDK Changes]info [Changelog] No exported changes
️✔️resources/mgmt/2018-05-01/policy [View full logs] [Preview SDK Changes]info [Changelog] No exported changes
️✔️resources/mgmt/2018-03-01/policy [View full logs] [Preview SDK Changes]info [Changelog] No exported changes
️✔️resources/mgmt/2018-02-01/resources [View full logs] [Preview SDK Changes]info [Changelog] No exported changes
️✔️resources/mgmt/2017-09-01/managedapplications [View full logs] [Preview SDK Changes]info [Changelog] No exported changes
️✔️resources/mgmt/2017-05-10/resources [View full logs] [Preview SDK Changes]info [Changelog] No exported changes
️✔️resources/mgmt/2016-12-01/policy [View full logs] [Preview SDK Changes]info [Changelog] No exported changes
️✔️resources/mgmt/2016-09-01/resources [View full logs] [Preview SDK Changes]info [Changelog] No exported changes
️✔️resources/mgmt/2016-09-01/locks [View full logs] [Preview SDK Changes]info [Changelog] No exported changes
️✔️resources/mgmt/2016-09-01/links [View full logs] [Preview SDK Changes]info [Changelog] No exported changes
️✔️resources/mgmt/2016-07-01/resources [View full logs] [Preview SDK Changes]info [Changelog] No exported changes
️✔️resources/mgmt/2016-06-01/subscriptions [View full logs] [Preview SDK Changes]info [Changelog] No exported changes
️✔️resources/mgmt/2016-04-01/policy [View full logs] [Preview SDK Changes]info [Changelog] No exported changes
️✔️resources/mgmt/2016-02-01/resources [View full logs] [Preview SDK Changes]info [Changelog] No exported changes
️✔️resources/mgmt/2015-12-01/features [View full logs] [Preview SDK Changes]info [Changelog] No exported changes
️✔️resources/mgmt/2015-11-01/subscriptions [View full logs] [Preview SDK Changes]info [Changelog] No exported changes
️✔️resources/mgmt/2015-11-01/resources [View full logs] [Preview SDK Changes]info [Changelog] No exported changes
️✔️resources/mgmt/2015-01-01/locks [View full logs] [Preview SDK Changes]info [Changelog] No exported changes
️✔️preview/resources/mgmt/2020-09-01-preview/policy [View full logs] [Preview SDK Changes]info [Changelog] This is a new package
- Only show 4 items here, please refer to log for details.
️✔️preview/resources/mgmt/2020-03-01-preview/policy [View full logs] [Preview SDK Changes] Breaking Change Detectedinfo [Changelog] - New field `SubscriptionID` in struct `BaseClient` info [Changelog] info [Changelog] Total 60 breaking change(s), 3 additive change(s). info [Changelog]
️✔️preview/resources/mgmt/2019-06-01-preview/templatespecs [View full logs] [Preview SDK Changes]info [Changelog] No exported changes
️✔️preview/resources/mgmt/2017-06-01-preview/policy [View full logs] [Preview SDK Changes]info [Changelog] No exported changes
️✔️preview/resources/mgmt/2016-09-01-preview/managedapplications [View full logs] [Preview SDK Changes]info [Changelog] No exported changes
️✔️preview/resources/mgmt/2015-10-01-preview/policy [View full logs] [Preview SDK Changes]info [Changelog] No exported changes
|
Hi @wwendyc, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
Contributor
|
@wwendyc please clarify the purpose of this update in PR description, and go through all the checks |
|
NewApiVersionRequired reason: |
Contributor
Author
|
@jianyexi This PR is to correct our Swagger for PS Cmdlets, not a breaking change. Please take a look. |
Contributor
But your change introduced some breaking changes , you should follow the below action:
|
added 6 commits
April 16, 2021 11:43
|
Hi @wwendyc, Your PR has some issues. Please fix the CI sequentially by following the order of
|
This was referenced Apr 23, 2021
Draft
Draft
[AutoPR @azure/arm-policy] [ProviderHub] Update definitions
AzureSDKAutomation/azure-sdk-for-js#4513
Draft
This was referenced Apr 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.