Skip to content

Added a new feature FlowTimeoutInMinutes under Virtual Network Proper… #13519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 23, 2021
Merged

Added a new feature FlowTimeoutInMinutes under Virtual Network Proper… #13519

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5507ee1
Added a new feature FlowTimeoutInMinutes under Virtual Network Proper…
Mar 19, 2021
b7c016d
Updated the type from string to integer, added a non-null example
Satya-anshu Mar 23, 2021
951c556
Added missing format for 'integer' type
Satya-anshu Mar 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ...k/resource-manager/Microsoft.Network/stable/2021-02-01/examples/VirtualNetworkCreate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
"10.0.0.0/16"
]
},
"flowTimeoutInMinutes": null,
Copy link
Contributor

@kairu-ms kairu-ms Mar 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use meaningful value instead of null in example.

"subnets": [],
"virtualNetworkPeerings": []
}
Expand All @@ -47,6 +48,7 @@
"10.0.0.0/16"
]
},
"flowTimeoutInMinutes": null,
"subnets": [],
"virtualNetworkPeerings": []
}
Expand Down
4 changes: 4 additions & 0 deletions ...fication/network/resource-manager/Microsoft.Network/stable/2021-02-01/virtualNetwork.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1702,6 +1702,10 @@
"$ref": "#/definitions/DhcpOptions",
"description": "The dhcpOptions that contains an array of DNS servers available to VMs deployed in the virtual network."
},
"flowTimeoutInMinutes": {
"type": "string",
Copy link
Contributor Author

@Satya-anshu Satya-anshu Mar 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the code, flowTimeoutInMinutes is defined as uint?

Copy link
Contributor Author

@Satya-anshu Satya-anshu Mar 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, we want to show the flowTimeoutInMinutes value at all times during a Get call.

Copy link
Contributor

@kairu-ms kairu-ms Mar 23, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why it's a string? I think it's better to use integer.

Copy link
Contributor Author

@Satya-anshu Satya-anshu Mar 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have updated it now.

"description": "The FlowTimeout value (in minutes) for the Virtual Network"
},
"subnets": {
"type": "array",
"items": {
Expand Down