-
Notifications
You must be signed in to change notification settings - Fork 5.6k
[Azure Customer Insight] Updated the 2017-01-01 version with the latest interaction API. Added 2017-04-26 version #1343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
57dd62a
updated to latest interaction api
xiaofma f948214
updating examples for the latest interaction api
xiaofma f32c863
new api version (2017-04-26) swagger and examples
xiaofma 4726d7f
fixing some json validation issue
xiaofma 2223295
fixing some model validation error
xiaofma ccaf5fb
minor fixes
xiaofma d0a23bc
fixed the description for source/target entity type
xiaofma 85fe7eb
removing "location" from required property
xiaofma bf37472
location should be required for hub
xiaofma 9a36dc2
Revert "location should be required for hub"
xiaofma File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
48 changes: 48 additions & 0 deletions
48
arm-customer-insights/2017-04-26/examples/AuthorizationPoliciesCreateOrUpdate.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| { | ||
| "parameters": { | ||
| "hubName": "azSdkTestHub", | ||
| "resourceGroupName": "TestHubRG", | ||
| "authorizationPolicyName": "testPolicy4222", | ||
| "api-version": "2016-01-01", | ||
| "subscriptionId": "subid", | ||
| "parameters": { | ||
| "properties": { | ||
| "permissions": ["Read", | ||
| "Write", | ||
| "Manage"] | ||
| } | ||
| } | ||
| }, | ||
| "responses": { | ||
| "201": { | ||
| "body": { | ||
| "id": "/subscriptions/subid/resourceGroups//TestHubRG/providers/Microsoft.CustomerInsights/hubs/azSdkTestHub/AuthorizationPolicies/testPolicy4222", | ||
| "name": "testPolicy4222", | ||
| "type": "Microsoft.CustomerInsights/hubs/AuthorizationPolicies", | ||
| "properties": { | ||
| "permissions": ["Read", | ||
| "Write", | ||
| "Manage"], | ||
| "policyName": "testPolicy4222", | ||
| "primaryKey": "cHJpbWFyeVRlc3RSZWFk", | ||
| "secondaryKey": "c2Vjb25kYXJ5VGVzdFJlYWQ=" | ||
| } | ||
| } | ||
| }, | ||
| "200": { | ||
| "body": { | ||
| "id": "/subscriptions/subid/resourceGroups//TestHubRG/providers/Microsoft.CustomerInsights/hubs/azSdkTestHub/AuthorizationPolicies/testPolicy4222", | ||
| "name": "testPolicy4222", | ||
| "type": "Microsoft.CustomerInsights/hubs/AuthorizationPolicies", | ||
| "properties": { | ||
| "permissions": ["Read", | ||
| "Write", | ||
| "Manage"], | ||
| "policyName": "testPolicy4222", | ||
| "primaryKey": "cHJpbWFyeVRlc3RSZWFk", | ||
| "secondaryKey": "c2Vjb25kYXJ5VGVzdFJlYWQ=" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } |
26 changes: 26 additions & 0 deletions
26
arm-customer-insights/2017-04-26/examples/AuthorizationPoliciesGet.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| { | ||
| "parameters": { | ||
| "hubName": "azSdkTestHub", | ||
| "resourceGroupName": "TestHubRG", | ||
| "authorizationPolicyName": "testPolicy4222", | ||
| "api-version": "2016-01-01", | ||
| "subscriptionId": "subid" | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "body": { | ||
| "id": "/subscriptions/c909e979-ef71-4def-a970-bc7c154db8c5/resourceGroups/TestHubRG/providers/Microsoft.CustomerInsights/hubs/azSdkTestHub/AuthorizationPolicies/testPolicy4222", | ||
| "name": "azSdkTestHub/testPolicy4222", | ||
| "properties": { | ||
| "permissions": ["Read", | ||
| "Write", | ||
| "Manage"], | ||
| "policyName": "testPolicy4222", | ||
| "primaryKey": "cHJpbWFyeVRlc3RSZWFk", | ||
| "secondaryKey": "c2Vjb25kYXJ5VGVzdFJlYWQ=" | ||
| }, | ||
| "type": "Microsoft.CustomerInsights/hubs/AuthorizationPolicies" | ||
| } | ||
| } | ||
| } | ||
| } |
40 changes: 40 additions & 0 deletions
40
arm-customer-insights/2017-04-26/examples/AuthorizationPoliciesListByHub.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| { | ||
| "parameters": { | ||
| "hubName": "azSdkTestHub", | ||
| "resourceGroupName": "TestHubRG", | ||
| "api-version": "2016-01-01", | ||
| "subscriptionId": "subid" | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "body": { | ||
| "value": [{ | ||
| "id": "/subscriptions/c909e979-ef71-4def-a970-bc7c154db8c5/resourceGroups/TestHubRG/providers/Microsoft.CustomerInsights/hubs/azSdkTestHub/AuthorizationPolicies/RootManageSharedAccessKey", | ||
| "name": "azSdkTestHub/RootManageSharedAccessKey", | ||
| "properties": { | ||
| "permissions": ["Read", | ||
| "Write", | ||
| "Manage"], | ||
| "policyName": "RootManageSharedAccessKey", | ||
| "primaryKey": "KEvPnaBbDbEdSch27GhFx/D5Smu1bZC8bCmG33fHyi4=", | ||
| "secondaryKey": "wvOahlAtWZh9127MVr1yYX2pPgioqFWGEUtp1ADbfcQ=" | ||
| }, | ||
| "type": "Microsoft.CustomerInsights/hubs/AuthorizationPolicies" | ||
| }, | ||
| { | ||
| "id": "/subscriptions/c909e979-ef71-4def-a970-bc7c154db8c5/resourceGroups/TestHubRG/providers/Microsoft.CustomerInsights/hubs/azSdkTestHub/AuthorizationPolicies/testPolicy1125", | ||
| "name": "azSdkTestHub/testPolicy1125", | ||
| "properties": { | ||
| "permissions": ["Read", | ||
| "Write", | ||
| "Manage"], | ||
| "policyName": "testPolicy1125", | ||
| "primaryKey": "3Nk5Yce0eQXHY3S+KDuUPKFS5NkOWLqtzNYEadh1WeI=", | ||
| "secondaryKey": "c2Vjb25kYXJ5VGVzdFJlYWQ=" | ||
| }, | ||
| "type": "Microsoft.CustomerInsights/hubs/AuthorizationPolicies" | ||
| }] | ||
| } | ||
| } | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removing/renaming a property is a breaking change (has the service made a breaking change?) and may result in SDK breaking changes, is this intentional for this api-version?
similar comment applies to other changes made to this api-version, please provide additional context on the changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, this is intentional and it's OK because the 2017-01-01 version never get released before. Last time when we update this swagger, this part was a work-in-progress. Now that it's done and it should look like this (when you call this API with 2017-01-01 version, this is what the returned schema looks like)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the current spec does not match the wire, meaning that it was initially incorrect, then it may be ok corrected (though for anyone who shipped it avoiding a breaking change is best). Regarding your statement about "201-01-01 version never get released before", what do you mean by this?
Having the swagger spec in master of this repo, means anyone could generate an SDK, I see there's an SDK for Go at https://github.com/Azure/azure-sdk-for-go/tree/master/arm/customer-insights.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi sorry looks like it's released before. However this part was incomplete so I'm sure no one was using it. Anyway the version 2017-01-01 should look like this swagger now