new API version (2021-02-10) for site recovery service #13422
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changing readme and examples
…t-api-specs into newApiVersion/asr2021-02-10
|
Hi, @nilgupta6 Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
|
Swagger pipeline can not start as the pull request has merge conflicts. |
|
Thank you for your contribution nilgupta6! We will review the pull request and get back to you soon. |
|
|
|
Swagger pipeline can not start as the pull request has merge conflicts. |
1 similar comment
|
Swagger pipeline can not start as the pull request has merge conflicts. |
|
Swagger pipeline can not start as the pull request has merge conflicts. |
1 similar comment
|
Swagger pipeline can not start as the pull request has merge conflicts. |
updating azuremaster
…t-api-specs into newApiVersion/asr2021-02-10Generated1 # Conflicts: # custom-words.txt
Swagger Validation Report
|
| Rule | Message |
|---|---|
|
The response of operation:'ReplicationAlertSettings_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.RecoveryServices/stable/2021-02-10/service.json#L105 |
|
The response of operation:'ReplicationAlertSettings_Create' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.RecoveryServices/stable/2021-02-10/service.json#L150 |
|
The response of operation:'ReplicationEvents_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.RecoveryServices/stable/2021-02-10/service.json#L349 |
|
The response of operation:'ReplicationFabrics_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.RecoveryServices/stable/2021-02-10/service.json#L439 |
|
The response of operation:'ReplicationFabrics_Create' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.RecoveryServices/stable/2021-02-10/service.json#L492 |
|
The response of operation:'ReplicationLogicalNetworks_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.RecoveryServices/stable/2021-02-10/service.json#L915 |
|
The response of operation:'ReplicationNetworks_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.RecoveryServices/stable/2021-02-10/service.json#L1019 |
|
The response of operation:'ReplicationNetworkMappings_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.RecoveryServices/stable/2021-02-10/service.json#L1130 |
|
The response of operation:'ReplicationNetworkMappings_Create' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.RecoveryServices/stable/2021-02-10/service.json#L1189 |
|
The response of operation:'ReplicationNetworkMappings_Update' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.RecoveryServices/stable/2021-02-10/service.json#L1321 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]
There are no breaking changes.
️⚠️[Staging] Cross Version BreakingChange (Base on stable version): 213 Warnings warning [Detail]
Only 10 items are listed, please refer to log for more details.
- Compared Swaggers (Based on Oad v0.8.7)
- original: stable/2018-07-10/service.json <---> new: stable/2021-02-10/service.json
| Rule | Message |
|---|---|
| The new version is missing a path that was found in the old version. Was path '/Subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/operations' removed or restructured? Old: Microsoft.RecoveryServices/stable/2018-07-10/service.json#L21:5 |
|
| The new version is missing a path that was found in the old version. Was path '/Subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{resourceName}/replicationAlertSettings' removed or restructured? Old: Microsoft.RecoveryServices/stable/2018-07-10/service.json#L61:5 |
|
| The new version is missing a path that was found in the old version. Was path '/Subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{resourceName}/replicationAlertSettings/{alertSettingName}' removed or restructured? Old: Microsoft.RecoveryServices/stable/2018-07-10/service.json#L104:5 |
|
| The new version is missing a path that was found in the old version. Was path '/Subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Compute/virtualMachines/{virtualMachineName}/providers/Microsoft.RecoveryServices/replicationEligibilityResults' removed or restructured? Old: Microsoft.RecoveryServices/stable/2018-07-10/service.json#L208:5 |
|
| The new version is missing a path that was found in the old version. Was path '/Subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Compute/virtualMachines/{virtualMachineName}/providers/Microsoft.RecoveryServices/replicationEligibilityResults/default' removed or restructured? Old: Microsoft.RecoveryServices/stable/2018-07-10/service.json#L252:5 |
|
| The new version is missing a path that was found in the old version. Was path '/Subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{resourceName}/replicationEvents' removed or restructured? Old: Microsoft.RecoveryServices/stable/2018-07-10/service.json#L296:5 |
|
| The new version is missing a path that was found in the old version. Was path '/Subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{resourceName}/replicationEvents/{eventName}' removed or restructured? Old: Microsoft.RecoveryServices/stable/2018-07-10/service.json#L347:5 |
|
| The new version is missing a path that was found in the old version. Was path '/Subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{resourceName}/replicationFabrics' removed or restructured? Old: Microsoft.RecoveryServices/stable/2018-07-10/service.json#L394:5 |
|
| The new version is missing a path that was found in the old version. Was path '/Subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{resourceName}/replicationFabrics/{fabricName}' removed or restructured? Old: Microsoft.RecoveryServices/stable/2018-07-10/service.json#L437:5 |
|
| The new version is missing a path that was found in the old version. Was path '/Subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{resourceName}/replicationFabrics/{fabricName}/checkConsistency' removed or restructured? Old: Microsoft.RecoveryServices/stable/2018-07-10/service.json#L591:5 |
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️[Staging] SDK Track2 Validation: 2 Warnings warning [Detail]
- The following tags are being changed in this PR
| Rule | Message |
|---|---|
| "readme":"recoveryservicessiterecovery/resource-manager/readme.md", "tag":"package-2021-02", "details":"The schema 'Resource' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"recoveryservicessiterecovery/resource-manager/readme.md", "tag":"package-2021-02", "details":"Checking for duplicate schemas, this could take a (long) while. Run with --verbose for more detail." |
️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
Swagger Generation Artifacts
|
|
Hi @nilgupta6, Your PR has some issues. Please fix the CI sequentially by following the order of
|
This was referenced Mar 16, 2021
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
|
Hi, @nilgupta6 your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]). cc @ChenTanyi |
Contributor
Author
|
@ChenTanyi |
Contributor
@jianyexi Could you take a look at this CI error? |
Contributor
|
@nilgupta6 - please make first commit by copying the content of existing (old) api-version. And then the changes in the new api-version should be added in subsequent commits. It is very hard to review such PRs. Please fix. |
Contributor
Author
@ravbhatnagar : We are introducing new API version in our service for all our APIs. This is because ARM does not allow us to introduce breaking changes (adding/modifying fields in existing APIs request and response) in existing version. FYI: @vidyadharijami , @ayfathim |
ChenTanyi
removed
the
customer-reported
Contributor
Author
|
we are getting this error in lint diff
we already have a 204 implemented for these delete APIs. Can we just bypass them? Also there are 2 other errors present
Will I have to open suppression request for all 3 types of errors? FYI: @ayfathim / @vidyadharijami / @Arpitaji |
Contributor
Author
@ravbhatnagar : I have created new PR (#13525) as per your suggestion. |
26 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
What's the purpose of the update?
When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
-->march last week or april first week
When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
--> march last week or april first week
If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.