Add geobackupenabled option for Swagger#13405
Closed
aishrk123 wants to merge 6 commits intoAzure:masterfrom
Closed
Add geobackupenabled option for Swagger#13405aishrk123 wants to merge 6 commits intoAzure:masterfrom
aishrk123 wants to merge 6 commits intoAzure:masterfrom
Conversation
|
Hi, @aishrk123 Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
Swagger Validation Report
|
| Rule | Message |
|---|---|
| Since operation 'LocationBasedCapabilities_Execute' response has model definition 'x-ms-pageable', it should be of the form '_list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.DBforPostgreSQL/preview/2021-03-25-preview/postgresql.json#L849 |
|
| Since operation 'VirtualNetworkSubnetUsage_Execute' response has model definition 'array', it should be of the form '_list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.DBforPostgreSQL/preview/2021-03-25-preview/postgresql.json#L891 |
|
| 'GET' operation 'LocationBasedCapabilities_Execute' should use method name 'Get' or Method name start with 'List'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.DBforPostgreSQL/preview/2021-03-25-preview/postgresql.json#L849 |
|
| Based on the response model schema, operation 'Operations_List' might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.DBforPostgreSQL/preview/2021-03-25-preview/postgresql.json#L935 |
|
| OperationId should contain the verb: 'checknameavailability' in:'CheckNameAvailability_Execute'. Consider updating the operationId Location: Microsoft.DBforPostgreSQL/preview/2021-03-25-preview/postgresql.json#L804 |
|
| OperationId should contain the verb: 'checkvirtualnetworksubnetusage' in:'VirtualNetworkSubnetUsage_Execute'. Consider updating the operationId Location: Microsoft.DBforPostgreSQL/preview/2021-03-25-preview/postgresql.json#L891 |
|
| The child tracked resource, 'firewallRules' with immediate parent 'Server', must have a list by immediate parent operation. Location: Microsoft.DBforPostgreSQL/preview/2021-03-25-preview/postgresql.json#L968 |
|
| The child tracked resource, 'configurations' with immediate parent 'Server', must have a list by immediate parent operation. Location: Microsoft.DBforPostgreSQL/preview/2021-03-25-preview/postgresql.json#L968 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isDataAction Location: Microsoft.DBforPostgreSQL/preview/2021-03-25-preview/postgresql.json#L1671 |
|
| 'identity' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: common-types/resource-management/v1/types.json#L158 |
The following errors/warnings exist before current PR submission:
| Rule | Message |
|---|---|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: nameAvailable Location: azure-rest-api-specs/blob/17fd689329f5c1342c645b2e373908f067fd3237/undefined#Lundefined |
️⚠️Avocado: 1 Warnings warning [Detail]
| Rule | Message |
|---|---|
| The default tag contains multiple API versions swaggers. readme: specification/postgresql/resource-manager/readme.md tag: specification/postgresql/resource-manager/readme.md#tag-package-2020-01-01 |
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]
There are no breaking changes.
- Compared Swaggers (Based on Oad v0.8.8)
- original: preview/2020-02-14-preview/postgresql.json <---> new: preview/2021-03-25-preview/postgresql.json
️⚠️[Staging] Cross Version BreakingChange (Base on stable version): 65 Warnings warning [Detail]
- Compared Swaggers (Based on Oad v0.8.8)
- original: stable/2017-12-01/postgresql.json <---> new: preview/2021-03-25-preview/postgresql.json
Only 10 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DBForPostgreSQL/servers/{serverName}' removed or restructured? Old: Microsoft.DBforPostgreSQL/stable/2017-12-01/postgresql.json#L37:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DBForPostgreSQL/servers' removed or restructured? Old: Microsoft.DBforPostgreSQL/stable/2017-12-01/postgresql.json#L244:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.DBForPostgreSQL/servers' removed or restructured? Old: Microsoft.DBforPostgreSQL/stable/2017-12-01/postgresql.json#L286:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DBForPostgreSQL/servers/{serverName}/replicas' removed or restructured? Old: Microsoft.DBforPostgreSQL/stable/2017-12-01/postgresql.json#L325:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DBForPostgreSQL/servers/{serverName}/restart' removed or restructured? Old: Microsoft.DBforPostgreSQL/stable/2017-12-01/postgresql.json#L370:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DBForPostgreSQL/servers/{serverName}/firewallRules/{firewallRuleName}' removed or restructured? Old: Microsoft.DBforPostgreSQL/stable/2017-12-01/postgresql.json#L413:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DBForPostgreSQL/servers/{serverName}/firewallRules' removed or restructured? Old: Microsoft.DBforPostgreSQL/stable/2017-12-01/postgresql.json#L567:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DBForPostgreSQL/servers/{serverName}/virtualNetworkRules/{virtualNetworkRuleName}' removed or restructured? Old: Microsoft.DBforPostgreSQL/stable/2017-12-01/postgresql.json#L612:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DBForPostgreSQL/servers/{serverName}/virtualNetworkRules' removed or restructured? Old: Microsoft.DBforPostgreSQL/stable/2017-12-01/postgresql.json#L757:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DBForPostgreSQL/servers/{serverName}/databases/{databaseName}' removed or restructured? Old: Microsoft.DBforPostgreSQL/stable/2017-12-01/postgresql.json#L799:5 |
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation
- The following tags are being changed in this PR
️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
Swagger Generation Artifacts
|
|
NewApiVersionRequired reason: |
Author
|
Tagging @Sameer-Arora @rajsell @QingqingYuan @shinilm to please help review this PR from PG Team's side. Thank you. |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
Hi @aishrk123, Your PR has some issues. Please fix the CI sequentially by following the order of
|
openapi-pipeline-app
bot
added
CI-FixRequiredOnFailure
and removed
CI-FixRequiredOnFailure
labels
Contributor
|
@PhoenixHe-msft could you guild on how to fix the SDK automation failure? |
|
Hi, @aishrk123 your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). cc @jianyexi |
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
|
Hi, @aishrk123. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
|
@aishrk123 Please resolve conflict. The issue should be resolved after rerun. |
|
Hi, @aishrk123. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
| input-file: | ||
| - Microsoft.DBforPostgreSQL/preview/2021-03-25-preview/postgresql.json | ||
| directive: | ||
| - suppress: R4009 |
Member
There was a problem hiding this comment.
@aishrk123 - ARM began rolling out the systemData requirement in 2019. At this time, it is required for all RPs and for all resource types. What is your timeline for implementing systemData?
|
Hi, @aishrk123. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
ghost
closed this
|
Hi, @aishrk123. The PR will be closed since the PR has no update for 28 days. If you still need the PR review to proceed, please reopen it and @ mention PR assignee. |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
*Date not yet available, tentatively March-May 2021
*Date not yet available, tentatively March-May 2021
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.