[text analytics] fix casing of certainty enum by iscai-msft · Pull Request #13277 · Azure/azure-rest-api-specs

iscai-msft · 2021-03-04T17:03:37Z

DISCLAIMERS: I wasn't able to repro any value for certainty besides negative, so I'm not 100% sure all of them are lowercase. Additionally, I'm only able to get a value for certainty out of the 3 assertion properties, so I'm not sure the other enums are correctly cased

openapi-workflow-bot · 2021-03-04T17:03:39Z

Hi, @iscai-msft Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

openapi-pipeline-app · 2021-03-04T17:03:40Z

Swagger pipeline can not start as the pull request has merge conflicts.

openapi-pipeline-app · 2021-03-04T17:03:40Z

Swagger pipeline can not start as the pull request has merge conflicts.

…into fix_certainty_swagger * 'master' of https://github.com/Azure/azure-rest-api-specs: Network november release (#13224) read replica added (#12567) Fix parent class of ClusterResource and DataCenterResource in .NET SDK (#13244) Update credential scope for Python. (#13263) [Hub Generated] Review request for Face to add version stable/v1.0 (#12739) Update Certainty enum (#13247) Added Swagger Doc for Settings API (#13241) [Hub Generated] Review request for Microsoft.Consumption to add version stable/2019-10-01 (#12822) fix web python.md (#13162) Peering new api version 2021-01-01 (#12855) Update Device Update for IoT Hub control plane autorest file for C# with correct namespace and output folder (#13251) update swagger reviews for translator text (#13246) [deviceupdate] make changes to readme in time for first release (#13240)

openapi-pipeline-app · 2021-03-04T17:04:36Z

Swagger Validation Report

️❌BreakingChange: 1 Errors, 0 Warnings failed [Detail]

Compared Swaggers (Based on Oad v0.8.6)
- original: preview/v3.1-preview.4/TextAnalytics.json <---> new: preview/v3.1-preview.4/TextAnalytics.json

Rule	Message
`❌` 1020 - AddedEnumValue	The new version is adding enum value(s) 'positive, positivepossible, neutralpossible, negativepossible, negative' from the old version. New: TextAnalytics/preview/v3.1-preview.4/TextAnalytics.json#L1882:9 Old: TextAnalytics/preview/v3.1-preview.4/TextAnalytics.json#L1882:9

️️✔️LintDiff succeeded [Detail] [Expand]

Validation passes for LintDiff.

Linted configuring files (Based on source branch, openapi-validator v1.7.0 , classic-openapi-validator v1.1.5 )
- data-plane/TextAnalytics/readme.md tag:release_3_1_preview.4
Linted configuring files (Based on target branch, openapi-validator v1.7.0 , classic-openapi-validator v1.1.5 )
- data-plane/TextAnalytics/readme.md tag:release_3_1_preview.4

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️❌ModelValidation: 1 Errors, 0 Warnings failed [Detail]

Rule	Message
`❌` ENUM_CASE_MISMATCH	Enum does not match case for: Positive Url: TextAnalytics/preview/v3.1-preview.4/TextAnalytics.json#L1882 JsonUrl: preview/v3.1-preview.4/examples/SuccessfulHealthStatusRequest.json

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️⚠️[Staging] SDK Track2 Validation: 1 Warnings warning [Detail]

The following tags are being changed in this PR

cognitiveservices/data-plane/TextAnalytics/readme.md#release_3_1_preview.4

Rule	Message
⚠️ PreCheck/CheckDuplicateSchemas	"readme":"cognitiveservices/data-plane/TextAnalytics/readme.md", "tag":"release_3_1_preview.4", "details":"Checking for duplicate schemas, this could take a (long) while. Run with --verbose for more detail."

️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️❌[Staging] SpellCheck: 3 Errors, 0 Warnings failed [Detail]

Rule	Message
`❌` HowToFix	Unknown word (positivepossible), please fix the error or add words to ./custom-words.txt path: TextAnalytics/preview/v3.1-preview.4/TextAnalytics.json#L1887:14
`❌` HowToFix	Unknown word (neutralpossible), please fix the error or add words to ./custom-words.txt path: TextAnalytics/preview/v3.1-preview.4/TextAnalytics.json#L1888:14
`❌` HowToFix	Unknown word (negativepossible), please fix the error or add words to ./custom-words.txt path: TextAnalytics/preview/v3.1-preview.4/TextAnalytics.json#L1889:14

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2021-03-04T17:04:36Z

Swagger Generation Artifacts

️🔄[Staging] ApiDocPreview inProgress [Detail]

️⚠️ azure-sdk-for-python warning [Detail]

⚠️Warning [Logs] Generate from dc101114bbd1039101ce076b3cbd80787ef26b62. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmdout	[automation_generate.sh] [Autorest]../azure-sdk-for-python_tmp/generateOutput.json does not exist!!!
warn	File azure-sdk-for-python_tmp/generateOutput.json not found to read

️✔️azure-ai-textanalytics [View full logs] [Preview SDK Changes]

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs] Generate from dc101114bbd1039101ce076b3cbd80787ef26b62. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] 2021-03-04 17:10:09 ERROR [Skip] readme path does not format as specification/*/resource-manager/readme.md
warn	No file changes detected after generation
warn	No package detected after generation

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from dc101114bbd1039101ce076b3cbd80787ef26b62. SDK Automation 14.0.0

command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️cognitiveservices/v2.1/textanalytics [View full logs] [Preview SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️cognitiveservices/v2.0/textanalytics [View full logs] [Preview SDK Changes]
```
info	[Changelog] No exported changes
```

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from dc101114bbd1039101ce076b3cbd80787ef26b62. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.4.4 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/cognitiveservices/data-plane/TextAnalytics/readme.md

️✔️@azure/cognitiveservices-textanalytics [View full logs] [Preview SDK Changes]

azure-cognitiveservices-textanalytics-4.0.0.tgz

cmderr	[npmPack] loaded rollup.config.js with warnings
cmderr	[npmPack] (!) Unused external imports
cmderr	[npmPack] default imported from external module 'rollup' but never used
cmderr	[npmPack] ./esm/textAnalyticsClient.js → ./dist/cognitiveservices-textanalytics.js...
cmderr	[npmPack] created ./dist/cognitiveservices-textanalytics.js in 175ms

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2021-03-04T17:06:48Z

Hi @iscai-msft, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff.

Task	How to fix	Priority	Support (Microsoft alias)
Avocado	Fix-Avocado	High	ruowan
Semantic validation	Fix-SemanticValidation-Error	High	raychen, jianyxi
Model validation	Fix-ModelValidation-Error	High	raychen,jianyxi
LintDiff	Fix-LintDiff	high	jianyxi, ruoxuan

If you need further help, please feedback via swagger feedback."

iscai-msft · 2021-03-05T19:06:32Z

closing this PR, service team will handle the swagger refactoring to ensure it's correct

fix casing

ec70ad3

iscai-msft requested a review from yangyuan as a code owner March 4, 2021 17:03

openapi-assignment-bot bot assigned anuchandy Mar 4, 2021

openapi-pipeline-app bot added the CI-FixRequiredOnFailure label Mar 4, 2021

openapi-pipeline-app bot removed the CI-FixRequiredOnFailure label Mar 4, 2021

iscai-msft mentioned this pull request Mar 4, 2021

[text analytics] assertions Azure/azure-sdk-for-python#17098

Merged

iscai-msft closed this Mar 5, 2021

iscai-msft deleted the fix_certainty_swagger branch March 5, 2021 19:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[text analytics] fix casing of certainty enum#13277

[text analytics] fix casing of certainty enum#13277
iscai-msft wants to merge 2 commits intoAzure:masterfrom
iscai-msft:fix_certainty_swagger

iscai-msft commented Mar 4, 2021

Uh oh!

openapi-workflow-bot bot commented Mar 4, 2021

Uh oh!

openapi-pipeline-app bot commented Mar 4, 2021

Uh oh!

openapi-pipeline-app bot commented Mar 4, 2021

Uh oh!

openapi-pipeline-app bot commented Mar 4, 2021 •

edited

Loading

Uh oh!

openapi-pipeline-app bot commented Mar 4, 2021 •

edited

Loading

Uh oh!

openapi-workflow-bot bot commented Mar 4, 2021

Uh oh!

iscai-msft commented Mar 5, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

iscai-msft commented Mar 4, 2021

Uh oh!

openapi-workflow-bot bot commented Mar 4, 2021

Uh oh!

openapi-pipeline-app bot commented Mar 4, 2021

Uh oh!

openapi-pipeline-app bot commented Mar 4, 2021

Uh oh!

openapi-pipeline-app bot commented Mar 4, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Swagger Validation Report

Uh oh!

openapi-pipeline-app bot commented Mar 4, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Swagger Generation Artifacts

Uh oh!

openapi-workflow-bot bot commented Mar 4, 2021

Uh oh!

iscai-msft commented Mar 5, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

openapi-pipeline-app bot commented Mar 4, 2021 •

edited

Loading

openapi-pipeline-app bot commented Mar 4, 2021 •

edited

Loading