Deviceupdate controlplane autorest csharp#13250
Closed
Conversation
Previous link missing SkuName property is missing
|
Hi, @dpokluda Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
Swagger Validation Report
|
| Rule | Message |
|---|---|
| "readme":"consumption/resource-manager/readme.md", "tag":"package-2019-10", "details":"The schema 'MeterDetails' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"consumption/resource-manager/readme.md", "tag":"package-2019-10", "details":"The schema 'UsageDetailsListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"consumption/resource-manager/readme.md", "tag":"package-2019-10", "details":"The schema 'LegacyUsageDetailProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"consumption/resource-manager/readme.md", "tag":"package-2019-10", "details":"The schema 'ModernUsageDetailProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"consumption/resource-manager/readme.md", "tag":"package-2019-10", "details":"The schema 'ReservationSummariesListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"consumption/resource-manager/readme.md", "tag":"package-2019-10", "details":"The schema 'ReservationSummaryProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"consumption/resource-manager/readme.md", "tag":"package-2019-10", "details":"The schema 'ReservationDetailsListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"consumption/resource-manager/readme.md", "tag":"package-2019-10", "details":"The schema 'ReservationDetailProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"consumption/resource-manager/readme.md", "tag":"package-2019-10", "details":"The schema 'ReservationRecommendationDetailsProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"consumption/resource-manager/readme.md", "tag":"package-2019-10", "details":"The schema 'ReservationRecommendationDetailsCalculatedSavingsProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
Swagger Generation Artifacts
|
| Rule | Message |
|---|---|
|
"logUrl":"https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=198441&view=logs&j=fd490c07-0b22-5182-fac9-6d67fe1e939b", "detail":"Run.ps1 failed with exit code 128 " |
️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]
️✔️Succeeded [Logs] Generate from 1f0084bd5a50a901fffcb7e120b9500283027f1a. Schema Automation 14.0.0warn Skip initScript due to not configured command npx n 12 warn specification/deviceupdate/resource-manager/readme.md skipped due to azure-resource-manager-schemas not found in swagger-to-sdk command autorest --use=@autorest/azureresourceschema@3.0.92 --version=3.0.6374 --azureresourceschema --multiapi --title=none --pass-thru:subset-reducer --azureresourceschema-folder=/home/vsts/work/1/s/azure-resource-manager-schemas/azure-resource-manager-schemas ../../azure-rest-api-specs/specification/consumption/resource-manager/readme.md
️✔️consumption [View full logs] [Preview Schema Changes]cmderr [resource-manager] node-pre-gyp cmderr [resource-manager] WARN Using request for node-pre-gyp https download cmderr [resource-manager] WARN template-schema-validation-tools@1.0.0 No repository field. cmderr [resource-manager] npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@2.1.3 (node_modules/fsevents): cmderr [resource-manager] npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@2.1.3: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
️✔️Succeeded [Logs] Generate from 1f0084bd5a50a901fffcb7e120b9500283027f1a. SDK Automation 14.0.0warn Skip initScript due to not configured warn specification/deviceupdate/resource-manager/readme.md skipped due to azure-sdk-for-js not found in swagger-to-sdk command autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.4.4 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/consumption/resource-manager/readme.md
️✔️@azure/arm-consumption [View full logs] [Preview SDK Changes]cmderr [npmPack] loaded rollup.config.js with warnings cmderr [npmPack] (!) Unused external imports cmderr [npmPack] default imported from external module 'rollup' but never used cmderr [npmPack] ./esm/consumptionManagementClient.js → ./dist/arm-consumption.js... cmderr [npmPack] created ./dist/arm-consumption.js in 560ms
️⚠️ azure-sdk-for-python-track2 warning [Detail]
⚠️Warning [Logs] Generate from 1f0084bd5a50a901fffcb7e120b9500283027f1a. SDK Automation 14.0.0command sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json cmderr [automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed. command sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
️✔️track2_azure-mgmt-consumption [View full logs] [Preview SDK Changes]info [Changelog] **Features** info [Changelog] info [Changelog] - Model ChargeSummary has a new parameter etag info [Changelog] - Model LotSummary has a new parameter etag info [Changelog] - Model ReservationRecommendationDetailsModel has a new parameter etag info [Changelog] - Model TagsResult has a new parameter previous_link info [Changelog] - Model TagsResult has a new parameter next_link info [Changelog] - Model ModernReservationRecommendation has a new parameter sku_name info [Changelog] - Model ModernReservationRecommendation has a new parameter etag info [Changelog] - Model Forecast has a new parameter etag info [Changelog] - Model Resource has a new parameter etag info [Changelog] - Model UsageDetail has a new parameter etag info [Changelog] - Model ModernUsageDetail has a new parameter etag info [Changelog] - Model ModernUsageDetail has a new parameter pay_g_price info [Changelog] - Model Tag has a new parameter value info [Changelog] - Model EventSummary has a new parameter etag info [Changelog] - Model Balance has a new parameter etag info [Changelog] - Model ModernChargeSummary has a new parameter etag info [Changelog] - Model PriceSheetResult has a new parameter etag info [Changelog] - Model ReservationRecommendation has a new parameter etag info [Changelog] - Model LegacyChargeSummary has a new parameter etag info [Changelog] - Model ManagementGroupAggregatedCostResult has a new parameter etag info [Changelog] - Model ReservationSummary has a new parameter etag info [Changelog] - Model Marketplace has a new parameter etag info [Changelog] - Model Operation has a new parameter id info [Changelog] - Model ReservationDetail has a new parameter etag info [Changelog] - Model ReservationRecommendationsListResult has a new parameter previous_link info [Changelog] - Model LegacyReservationRecommendation has a new parameter etag info [Changelog] - Model LegacyReservationRecommendation has a new parameter resource_type info [Changelog] - Model CreditSummary has a new parameter etag info [Changelog] - Model LegacyUsageDetail has a new parameter etag
️⚠️ azure-sdk-for-java warning [Detail]
⚠️Warning [Logs] Generate from 1f0084bd5a50a901fffcb7e120b9500283027f1a. SDK Automation 14.0.0command ./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json command ./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json cmderr [generate.py] 2021-03-03 02:14:15 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-consumption" cmderr [generate.py] 2021-03-03 02:14:15 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1" cmderr [generate.py] 2021-03-03 02:14:15 INFO autorest --version=3.0.6369 --use=@autorest/java@4.0.17 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/consumption/azure-resourcemanager-consumption --java.namespace=com.azure.resourcemanager.consumption --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/consumption/resource-manager/readme.md cmderr [generate.py] 2021-03-03 02:15:02 INFO [CI][Success] Write to ci.yml cmderr [generate.py] 2021-03-03 02:15:02 INFO [POM][Process] dealing with pom.xml cmderr [generate.py] 2021-03-03 02:15:02 INFO [POM][Skip] pom already has module azure-resourcemanager-consumption cmderr [generate.py] 2021-03-03 02:15:02 INFO [POM][Success] Write to pom.xml cmderr [generate.py] 2021-03-03 02:15:02 INFO [POM][Process] dealing with root pom cmderr [generate.py] 2021-03-03 02:15:02 INFO [POM][Success] Write to root pom
️✔️azure-resourcemanager-consumption [View full logs] [Preview SDK Changes]- pom.xml
- azure-resourcemanager-consumption-1.0.0-beta.1.jar
- azure-resourcemanager-consumption-1.0.0-beta.1-sources.jar
- azure-resourcemanager-consumption-1.0.0-beta.1-javadoc.jar
cmderr [Inst] 2021-03-03 02:18:50 DEBUG Got artifact_id: azure-resourcemanager-consumption cmderr [Inst] 2021-03-03 02:18:50 DEBUG Got artifact: pom.xml cmderr [Inst] 2021-03-03 02:18:50 DEBUG Got artifact: azure-resourcemanager-consumption-1.0.0-beta.1.jar cmderr [Inst] 2021-03-03 02:18:50 DEBUG Match jar package: azure-resourcemanager-consumption-1.0.0-beta.1.jar cmderr [Inst] 2021-03-03 02:18:50 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/13250/azure-sdk-for-java/azure-resourcemanager-consumption/azure-resourcemanager-consumption-1.0.0-beta.1.jar\" -o azure-resourcemanager-consumption-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-consumption -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-consumption-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true ```"}
️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
️✔️Succeeded [Logs] Generate from 1f0084bd5a50a901fffcb7e120b9500283027f1a. SDK Automation 14.0.0warn Skip initScript due to not configured command sudo apt-get install -y dotnet-sdk-5.0 command autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/consumption/resource-manager/readme.md cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied command autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/deviceupdate/resource-manager/readme.md cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied
️✔️Microsoft.Azure.Management.Consumption [View full logs] [Preview SDK Changes]️✔️Microsoft.Azure.Management.DeviceUpdate [View full logs] [Preview SDK Changes]
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
️✔️Succeeded [Logs] Generate from 1f0084bd5a50a901fffcb7e120b9500283027f1a. SDK Automation 14.0.0command sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json command go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
- Only show 10 items here, please refer to log for details.
️✔️consumption/mgmt/2019-10-01/consumption [View full logs] [Preview SDK Changes] Breaking Change Detectedinfo [Changelog] - New field `ResourceType` in struct `LegacyReservationRecommendationProperties` info [Changelog] - New field `Etag` in struct `ChargeSummary` info [Changelog] - New field `Etag` in struct `LegacyChargeSummary` info [Changelog] - New field `Etag` in struct `Resource` info [Changelog] - New field `ID` in struct `Operation` info [Changelog] - New field `PreviousLink` in struct `ReservationRecommendationsListResult` info [Changelog] - New field `Etag` in struct `ModernUsageDetail` info [Changelog] info [Changelog] Total 3 breaking change(s), 33 additive change(s). info [Changelog]
️✔️consumption/mgmt/2019-01-01/consumption [View full logs] [Preview SDK Changes]info [Changelog] No exported changes
️✔️consumption/mgmt/2018-10-01/consumption [View full logs] [Preview SDK Changes]info [Changelog] No exported changes
️✔️consumption/mgmt/2018-08-31/consumption [View full logs] [Preview SDK Changes]info [Changelog] No exported changes
️✔️consumption/mgmt/2018-06-30/consumption [View full logs] [Preview SDK Changes]info [Changelog] No exported changes
️✔️consumption/mgmt/2018-05-31/consumption [View full logs] [Preview SDK Changes]info [Changelog] No exported changes
️✔️consumption/mgmt/2018-03-31/consumption [View full logs] [Preview SDK Changes]info [Changelog] No exported changes
️✔️consumption/mgmt/2018-01-31/consumption [View full logs] [Preview SDK Changes]info [Changelog] No exported changes
️✔️consumption/mgmt/2017-11-30/consumption [View full logs] [Preview SDK Changes]info [Changelog] No exported changes
️✔️preview/consumption/mgmt/2017-12-30-preview/consumption [View full logs] [Preview SDK Changes]info [Changelog] No exported changes
️✔️preview/consumption/mgmt/2017-04-24-preview/consumption [View full logs] [Preview SDK Changes]info [Changelog] No exported changes
️✔️preview/deviceupdate/mgmt/2020-03-01-preview/deviceupdate [View full logs] [Preview SDK Changes]info [Changelog] No exported changes
️⚠️ azure-sdk-for-python warning [Detail]
⚠️Warning [Logs] Generate from 1f0084bd5a50a901fffcb7e120b9500283027f1a. SDK Automation 14.0.0command sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json cmderr [automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed. warn specification/deviceupdate/resource-manager/readme.md skipped due to azure-sdk-for-python not found in swagger-to-sdk command sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
️✔️azure-mgmt-consumption [View full logs] [Preview SDK Changes] Breaking Change Detectedinfo [Changelog] **Features** info [Changelog] info [Changelog] - Model Notification has a new parameter threshold_type info [Changelog] - Model Resource has a new parameter etag info [Changelog] - Model ReservationSummary has a new parameter utilized_percentage info [Changelog] - Model ReservationSummary has a new parameter used_quantity info [Changelog] - Model ReservationSummary has a new parameter kind info [Changelog] - Model ReservationSummary has a new parameter etag info [Changelog] - Model ReservationSummary has a new parameter total_reserved_quantity info [Changelog] - Model ReservationSummary has a new parameter purchased_quantity info [Changelog] - Model ReservationSummary has a new parameter remaining_quantity info [Changelog] - Model Balance has a new parameter etag info [Changelog] - Model Marketplace has a new parameter etag info [Changelog] - Model Forecast has a new parameter etag info [Changelog] - Model ManagementGroupAggregatedCostResult has a new parameter etag info [Changelog] - Model Budget has a new parameter filter info [Changelog] - Model TagsResult has a new parameter previous_link info [Changelog] - Model TagsResult has a new parameter next_link info [Changelog] - Model PriceSheetResult has a new parameter etag info [Changelog] - Model ReservationDetail has a new parameter instance_flexibility_ratio info [Changelog] - Model ReservationDetail has a new parameter instance_flexibility_group info [Changelog] - Model ReservationDetail has a new parameter kind info [Changelog] - Model ReservationDetail has a new parameter etag info [Changelog] - Model Operation has a new parameter id info [Changelog] - Model Tag has a new parameter value info [Changelog] - Added operation ReservationsDetailsOperations.list info [Changelog] - Added operation ReservationRecommendationsOperations.list info [Changelog] - Added operation ReservationsSummariesOperations.list info [Changelog] - Added operation ChargesOperations.list info [Changelog] - Added operation group ReservationRecommendationDetailsOperations info [Changelog] - Added operation group LotsOperations info [Changelog] - Added operation group EventsOperations info [Changelog] - Added operation group ReservationTransactionsOperations info [Changelog] - Added operation group CreditsOperations info [Changelog] info [Changelog] **Breaking changes** info [Changelog] info [Changelog] - Model Budget no longer has parameter filters info [Changelog] - Model ChargeSummary has a new signature info [Changelog] - Model UsageDetail has a new signature info [Changelog] - Model ReservationRecommendation has a new signature info [Changelog] - Removed operation UsageDetailsOperations.download info [Changelog] - Removed operation ChargesOperations.list_by_scope
This was referenced Mar 3, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.