[Hub Generated] Review request for Microsoft.StreamAnalytics to add version stable/2017-04-01#13233
Closed
[Hub Generated] Review request for Microsoft.StreamAnalytics to add version stable/2017-04-01#13233
Conversation
…/2017-04-01-preview to version 2017-04-01
Swagger Validation Report
|
| Rule | Message |
|---|---|
| The child tracked resource, 'functions' with immediate parent 'StreamingJob', must have a list by immediate parent operation. Location: Microsoft.StreamAnalytics/stable/2017-04-01/transformations.json#L222 |
|
| The child tracked resource, 'inputs' with immediate parent 'StreamingJob', must have a list by immediate parent operation. Location: Microsoft.StreamAnalytics/stable/2017-04-01/transformations.json#L222 |
|
| The child tracked resource, 'outputs' with immediate parent 'StreamingJob', must have a list by immediate parent operation. Location: Microsoft.StreamAnalytics/stable/2017-04-01/transformations.json#L222 |
|
| The child tracked resource, 'transformations' with immediate parent 'StreamingJob', must have a list by immediate parent operation. Location: Microsoft.StreamAnalytics/stable/2017-04-01/transformations.json#L222 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]
There are no breaking changes.
- Compared Swaggers (Based on Oad v0.8.6)
- original: preview/2017-04-01-preview/functions.json <---> new: stable/2017-04-01/functions.json
- original: preview/2017-04-01-preview/inputs.json <---> new: stable/2017-04-01/inputs.json
- original: preview/2017-04-01-preview/operations.json <---> new: stable/2017-04-01/operations.json
- original: preview/2017-04-01-preview/outputs.json <---> new: stable/2017-04-01/outputs.json
- original: preview/2017-04-01-preview/streamingjobs.json <---> new: stable/2017-04-01/streamingjobs.json
- original: preview/2017-04-01-preview/subscriptions.json <---> new: stable/2017-04-01/subscriptions.json
- original: preview/2017-04-01-preview/transformations.json <---> new: stable/2017-04-01/transformations.json
️⚠️[Staging] Cross Version BreakingChange (Base on stable version): 127 Warnings warning [Detail]
Only 10 items are listed, please refer to log for more details.
- Compared Swaggers (Based on Oad v0.8.6)
- original: stable/2016-03-01/functions.json <---> new: stable/2017-04-01/functions.json
- original: stable/2016-03-01/inputs.json <---> new: stable/2017-04-01/inputs.json
- original: stable/2016-03-01/outputs.json <---> new: stable/2017-04-01/outputs.json
- original: stable/2016-03-01/streamingjobs.json <---> new: stable/2017-04-01/streamingjobs.json
- original: stable/2016-03-01/subscriptions.json <---> new: stable/2017-04-01/subscriptions.json
- original: stable/2016-03-01/transformations.json <---> new: stable/2017-04-01/transformations.json
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️[Staging] SDK Track2 Validation: 119 Warnings warning [Detail]
Only 10 items are listed, please refer to log for more details.
- The following tags are being changed in this PR
| Rule | Message |
|---|---|
| "readme":"streamanalytics/resource-manager/readme.md", "tag":"package-2017-04", "details":"The schema 'Function' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"streamanalytics/resource-manager/readme.md", "tag":"package-2017-04", "details":"The schema 'FunctionProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"streamanalytics/resource-manager/readme.md", "tag":"package-2017-04", "details":"The schema 'FunctionConfiguration' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"streamanalytics/resource-manager/readme.md", "tag":"package-2017-04", "details":"The schema 'ScalarFunctionProperties' with an undefined type and 'allOf'/'anyOf'/'oneOf' is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"streamanalytics/resource-manager/readme.md", "tag":"package-2017-04", "details":"The schema 'FunctionInput' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"streamanalytics/resource-manager/readme.md", "tag":"package-2017-04", "details":"The schema 'FunctionOutput' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"streamanalytics/resource-manager/readme.md", "tag":"package-2017-04", "details":"The schema 'FunctionBinding' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"streamanalytics/resource-manager/readme.md", "tag":"package-2017-04", "details":"The schema 'AzureMachineLearningStudioFunctionBinding' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"streamanalytics/resource-manager/readme.md", "tag":"package-2017-04", "details":"The schema 'AzureMachineLearningStudioFunctionBindingProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"streamanalytics/resource-manager/readme.md", "tag":"package-2017-04", "details":"The schema 'AzureMachineLearningStudioInputs' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
|
Hi, @zesluo Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
Swagger Generation Artifacts
|
This was referenced Mar 2, 2021
zesluo
assigned
weidongxu-microsoft and unassigned
zhenglaizhang and
weidongxu-microsoft
atpham256
requested changes
Mar 2, 2021
Contributor
atpham256
left a comment
atpham256
left a comment
There was a problem hiding this comment.
I'm not sure what this PR is. We should not be adding a "2017-04-01" version. I would suggest revoking/closing this PR unless you have further clarity.
Even if we are, what is the difference between this and 2017-04-01-preview? I'm quite certain not all features in 2017-04-01-preview should be GA'd.
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
|
Hi, @zesluo your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). cc @weidongxu-microsoft |
Contributor
|
Please go through the contribution checklist added as part of the review and mark them completed. This is a requirement before review can be continued. |
Contributor
|
We should not be adding such an old version as GA. Please create new version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
swagger ready before 03/19
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.