Skip to content

AAS - Fix Swagger Correctness v6 #12999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
allenjzhang merged 8 commits into from
Mar 7, 2021
Merged

AAS - Fix Swagger Correctness v6 #12999

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
a5c1e62
Merge pull request #1 from Azure/master
david-msft Dec 28, 2020
4871a17
Merge pull request #2 from Azure/master
david-msft Jan 6, 2021
bfd34f2
Merge pull request #3 from Azure/master
david-msft Jan 13, 2021
21fe6f8
Merge pull request #4 from Azure/master
david-msft Jan 19, 2021
66282a6
Merge pull request #5 from Azure/master
david-msft Feb 3, 2021
b63f357
Merge pull request #6 from Azure/master
david-msft Feb 16, 2021
82c4b01
fix additional property
david-msft Feb 16, 2021
705c1e1
Fix to use ErrorDetail
david-msft Feb 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
84 changes: 20 additions & 64 deletions ...vices/resource-manager/Microsoft.AnalysisServices/stable/2017-08-01/analysisservices.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1342,31 +1342,7 @@
"GatewayError": {
"description": "Detail of gateway errors.",
"type": "object",
"properties": {
"code": {
"type": "string",
"description": "Error code of list gateway."
},
"message": {
"type": "string",
"description": "Error message of list gateway."
},
"subCode": {
"description": "The error sub code",
"type": "integer",
"format": "int32"
},
"httpStatusCode": {
"description": "The http status code",
"type": "integer",
"format": "int32"
},
"timeStamp": {
"description": "the timestamp for the error.",
"type": "string",
"readOnly": true
}
}
"$ref": "#/definitions/ErrorDetail"
},
"CheckServerNameAvailabilityParameters": {
"description": "Details of server name request body.",
Expand Down Expand Up @@ -1431,7 +1407,7 @@
"error": {
"type": "object",
"description": "The error detail of the operation if any.",
"$ref": "#/definitions/ErrorObject"
"$ref": "#/definitions/ErrorDetail"
}
}
},
Expand Down Expand Up @@ -1493,6 +1469,23 @@
"type": "string",
"description": "The error target."
},
"subCode": {
"readOnly": true,
"description": "The error sub code",
"type": "integer",
"format": "int32"
},
"httpStatusCode": {
"readOnly": true,
"description": "The http status code",
"type": "integer",
"format": "int32"
},
"timeStamp": {
"readOnly": true,
"description": "the timestamp for the error.",
"type": "string"
},
"details": {
"readOnly": true,
"type": "array",
Expand Down Expand Up @@ -1526,50 +1519,13 @@
},
"description": "The resource management error additional info."
},
"ErrorObject": {
"type": "object",
"description": "The error object",
"properties": {
"code": {
"description": "Error code",
"type": "string"
},
"message": {
"description": "Error message indicating why the operation failed.",
"type": "string"
},
"subCode": {
"description": "The error sub code",
"type": "integer",
"format": "int32"
},
"httpStatusCode": {
"description": "The http status code",
"type": "integer",
"format": "int32"
},
"timeStamp": {
"description": "the timestamp for the error.",
"type": "string",
"readOnly": true
},
"details": {
"readOnly": true,
"type": "array",
"items": {
"$ref": "#/definitions/ErrorDetail"
},
"description": "The error details."
}
}
},
"ErrorResponse": {
"description": "Describes the format of Error response.",
"type": "object",
"properties": {
"error": {
"description": "The error object",
"$ref": "#/definitions/ErrorObject"
"$ref": "#/definitions/ErrorDetail"
Copy link
Copy Markdown
Contributor

@chiragg4u chiragg4u Mar 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recommend referring to common definitions "$ref": "../../../../../common-types/resource-management/v1/types.json#/definitions/..." This will enforce the right schema.

}
}
}
Expand Down