Fixing error in lastModifiedAt description#12854
Conversation
In response to Issue Azure#12712, fixing the error in the description of the lastModifiedAt systemData property
|
Hi, @jennyhunter-msft Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
Swagger Validation Report
|
| Rule | Message |
|---|---|
MISSING_README |
Can not find readme.md in the folder. If no readme.md file, it will block SDK generation. folder: specification/common-types/resource-management/v1 |
MISSING_README |
Can not find readme.md in the folder. If no readme.md file, it will block SDK generation. folder: specification/common-types/resource-management/v2 |
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation
️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
|
Swagger pipeline restarted successfully, please wait for status update in this comment. |
|
Hi @jennyhunter-msft, Your PR has some issues. Please fix the CI sequentially by following the order of
|
|
This change does not include any new or change any existing APIs and should not need a Swagger. |
|
@ArcturusZhang, Let me know if you need anything more from my side. |
|
@ruowan could you take a look at the Avocado failure? It looks like an expected failure, do we need to force-merge this? |
| "type": "string", | ||
| "format": "date-time", | ||
| "description": "The type of identity that last modified the resource." | ||
| "description": "The timestamp when the resource was last modified (UTC)." |
There was a problem hiding this comment.
Hi @jennyhunter-msft, Can you also fix the same error in v1/types.json?
Updated the description for lastModifiedAt to address a typo
Updated the lastModifiedAt text to align with other documented sources
|
Updated the v1 description and updated the v2 to use the same wording found in other documentation about this property |
In response to Issue #12712, fixing the error in the description of the lastModifiedAt systemData property
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.