Skip to content

Fix links to schema files in x-ms-examples docs#12783

Merged
akning-ms merged 1 commit intoAzure:masterfrom
Simran-B:patch-2
Feb 4, 2021
Merged

Fix links to schema files in x-ms-examples docs#12783
akning-ms merged 1 commit intoAzure:masterfrom
Simran-B:patch-2

Conversation

@Simran-B
Copy link
Contributor

@Simran-B Simran-B commented Feb 2, 2021

Changelog

Fix broken links

  • 2 in docs about x-ms-examples

@openapi-workflow-bot
Copy link

Hi, @Simran-B Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Feb 2, 2021

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️LintDiff succeeded [Detail] [Expand]
    Validation passes for LintDiff.
    ️❌Avocado: 1 Errors, 0 Warnings failed [Detail]
    Rule Message
    MISSING_README Can not find readme.md in the folder. If no readme.md file, it will block SDK generation.
    folder: work/1/c93b354fd9c14905bb574a8834c4d69b/documentation
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Feb 2, 2021

    Swagger pipeline restarted successfully, please wait for status update in this comment.

    @ghost ghost added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Feb 2, 2021
    @ghost
    Copy link

    ghost commented Feb 2, 2021

    Thank you for your contribution Simran-B! We will review the pull request and get back to you soon.

    @openapi-workflow-bot
    Copy link

    Hi @Simran-B, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff.

    TaskHow to fixPrioritySupport (Microsoft alias)
    AvocadoFix-AvocadoHighruowan
    Semantic validationFix-SemanticValidation-ErrorHighraychen, jianyxi
    Model validationFix-ModelValidation-ErrorHighraychen,jianyxi
    LintDiffFix-LintDiffhighjianyxi, ruoxuan
    If you need further help, please feedback via swagger feedback."

    @Simran-B
    Copy link
    Contributor Author

    Simran-B commented Feb 2, 2021

    None of these issues is related to this PR.

    @akning-ms akning-ms merged commit ffc13ff into Azure:master Feb 4, 2021
    @Simran-B Simran-B deleted the patch-2 branch February 5, 2021 08:12
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    customer-reported Issues that are reported by GitHub users external to the Azure organization.

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    2 participants