[Service Fabric Managed Clusters] 2021-01-01-preview

[a-santamaria]

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

We already had a previous APIversion for managed clusters here: 2020-01-01-preview But we want to move it to its own swagger folder so we can manage APIs and SDKs independently and not face conflicts with models.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

1. What's the purpose of the update?
   • new service onboarding
   • new API version
   • update existing version for new feature
   • update existing version to fix swagger quality issue in s360
   • Other, please clarify
2. When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
   Target Date for new api version: 2/8/2021
3. When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
   2/5/2021
4. If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
   • SDK of .NET (need service team to ensure code readiness)
   • SDK of Python
   • SDK of Java
   • SDK of Js
   • SDK of Go
   • PowerShell
   • CLI
   • Terraform
   • No, no need to refresh for updates in this PR

Contribution checklist:

• I commit to follow the Breaking Change Policy of “no breaking changes
• I have reviewed the documentation for the workflow.
• Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

• Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

  • Adding new API(s)
  • Adding a new API version
  • Adding a new service

• Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

• If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

• Removing API(s) in stable version
• Removing properties in stable version
• Removing API version(s) in stable version
• Updating API in stable version with Breaking Change Validation errors
• Updating API(s) in preview over 1 year

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

[openapi-workflow-bot]

Hi, @a-santamaria Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

[openapi-pipeline-app]

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️LintDiff succeeded [Detail] [Expand]

Validation passes for LintDiff.

• Linted configuring files (Based on source branch, openapi-validator v1.7.0 , classic-openapi-validator v1.1.5 )
  • servicefabricmanagedclusters/resource-manager/readme.md tag:package-2021-01-preview
• Linted configuring files (Based on target branch, openapi-validator v1.7.0 , classic-openapi-validator v1.1.5 )
  • servicefabricmanagedclusters/resource-manager/readme.md tag:default

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

_{Posted by Swagger Pipeline | How to fix these errors?}

[openapi-workflow-bot]

Hi, @a-santamaria your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). cc @

[openapi-pipeline-app]

Swagger Generation Artifacts

️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]

• ️✔️Succeeded [Logs]Release - Generate from 0630625. Schema Automation 14.0.0

  warn	Skip initScript due to not configured
  command	npx n 12
  command	autorest --use=@autorest/azureresourceschema@3.0.92 --version=3.0.6369 --azureresourceschema --multiapi --title=none --pass-thru:subset-reducer --azureresourceschema-folder=/home/vsts/work/1/s/azure-resource-manager-schemas/azure-resource-manager-schemas ../../azure-rest-api-specs/specification/servicefabricmanagedclusters/resource-manager/readme.md

• ️✔️servicefabricmanagedclusters [View full logs]  [Release Schema Changes]

  cmderr	[resource-manager] node-pre-gyp
  cmderr	[resource-manager] WARN Using request for node-pre-gyp https download
  cmderr	[resource-manager] WARN template-schema-validation-tools@1.0.0 No repository field.
  cmderr	[resource-manager] WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@2.1.3 (node_modules/fsevents):
  cmderr	[resource-manager] npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@2.1.3: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})

️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]

• ️✔️Succeeded [Logs]Release - Generate from 0630625. SDK Automation 14.0.0

  warn	Skip initScript due to not configured
  command	sudo apt-get install -y dotnet-sdk-5.0
  command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/servicefabricmanagedclusters/resource-manager/readme.md
  cmderr	[Autorest] realpath(): Permission denied
  cmderr	[Autorest] realpath(): Permission denied
  cmderr	[Autorest] realpath(): Permission denied
  cmderr	[Autorest] realpath(): Permission denied
  cmderr	[Autorest] realpath(): Permission denied
  cmderr	[Autorest] realpath(): Permission denied

• ️✔️Microsoft.Azure.Management.ServiceFabricManagedClusters [View full logs]  [Release SDK Changes]

  warn	Skip artifact folder because it doesn't exist: artifacts/packages

️⚠️ azure-sdk-for-python warning [Detail]

• ⚠️Warning [Logs]Release - Generate from 0630625. SDK Automation 14.0.0

  command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
  cmderr	[automation_init.sh] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
  cmderr	[automation_init.sh]   Failed building wheel for ConfigArgParse
  cmderr	[automation_init.sh]   Failed building wheel for yarl
  cmderr	[automation_init.sh]   Failed building wheel for wrapt
  cmderr	[automation_init.sh]   Failed building wheel for multidict
  cmderr	[automation_init.sh] Cannot uninstall requirement azure-nspkg, not installed
  cmderr	[automation_init.sh] Command '['/home/vsts/work/1/s/azure-sdk-for-python_tmp/venv-sdk/bin/python', '-m', 'pip', 'uninstall', '-y', 'azure-nspkg']' returned non-zero exit status 1.
  command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json

• ️✔️azure-mgmt-servicefabricmanagedclusters [View full logs]  [Release SDK Changes] Breaking Change Detected
  • azure_mgmt_servicefabricmanagedclusters-2021_01_01_preview-py2.py3-none-any.whl
  • azure-mgmt-servicefabricmanagedclusters-2021-01-01-preview.zip

  info	[Changelog]   - Initial Release

️❌[Staging] ApiDocPreview: 1 Errors, 0 Warnings failed [Detail]

Rule	Message
❌ RestBuild error	"logUrl":"https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=192574&view=logs&j=fd490c07-0b22-5182-fac9-6d67fe1e939b", "detail":"Run.ps1 failed with exit code 1 "

_{Posted by Swagger Pipeline | How to fix these errors?}

[openapi-workflow-bot]

Hi @a-santamaria, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff.

Task	How to fix	Priority	Support (Microsoft alias)
Avocado	Fix-Avocado	High	ruowan
Semantic validation	Fix-SemanticValidation-Error	High	raychen, jianyxi
Model validation	Fix-ModelValidation-Error	High	raychen,jianyxi
LintDiff	Fix-LintDiff	high	jianyxi, ruoxuan

If you need further help, please feedback via swagger feedback."

[openapi-workflow-bot]

Hi, @a-santamaria your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). cc @ChenTanyi

[pilor]

A few comments. Up to @ChenTanyi how they feel about splitting out APIs that exist in the service fabric SDK to another SDK

[ChenTanyi]

A few comments. Up to @ChenTanyi how they feel about splitting out APIs that exist in the service fabric SDK to another SDK

@akning-ms @josefree @PhoenixHe-msft @jianyexi Would you take a look at it?

[a-santamaria]

@ChenTanyi I can't figure out what is the issue with the python SDK generation, can you help, please?
https://dev.azure.com/azure-sdk/internal/_build/results?buildId=708047&view=logs&j=b7f68bce-9df8-5468-1c9f-74766cfc9a39&t=25fc8ae6-51ed-58e2-b772-f4d054412fe3

[ChenTanyi]

@ChenTanyi I can't figure out what is the issue with the python SDK generation, can you help, please?
https://dev.azure.com/azure-sdk/internal/_build/results?buildId=708047&view=logs&j=b7f68bce-9df8-5468-1c9f-74766cfc9a39&t=25fc8ae6-51ed-58e2-b772-f4d054412fe3

@msyyc @PhoenixHe-msft Could you take a look at the python generation error?

[a-santamaria]

@ChenTanyi I can't figure out what is the issue with the python SDK generation, can you help, please?
https://dev.azure.com/azure-sdk/internal/_build/results?buildId=708047&view=logs&j=b7f68bce-9df8-5468-1c9f-74766cfc9a39&t=25fc8ae6-51ed-58e2-b772-f4d054412fe3

@msyyc @PhoenixHe-msft Could you take a look at the python generation error?

@msyyc @PhoenixHe-msft did you get a chance to look at the issue? I don't think its related to the changes its saying that it can't find bundle:

09:09:41.198 cmdout [automation_generate.sh] INFO:packaging_tools.swaggertosdk.SwaggerToSdkNewCLI:Execute after script: bundle install && rake arm:regen_all_profiles['azure_mgmt_service_fabric_managed_clusters'] 09:09:41.777 cmdout [automation_generate.sh] INFO:packaging_tools.swaggertosdk.autorest_tools:==[autorest]/bin/sh: 1: bundle: not found 09:09:41.778 cmdout [automation_generate.sh] ERROR:packaging_tools.swaggertosdk.autorest_tools:Command 'bundle install && rake arm:regen_all_profiles['azure_mgmt_service_fabric_managed_clusters']' returned non-zero exit status 127.

[PhoenixHe-NV]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 2 pipeline(s).

[a-santamaria]

@ChenTanyi I fixed the issue with the python sdk generation and it's signed off by ARM. Can we merge the pr?