AAS - Fix Swagger Correctness Issue v3 #12422

david-msft · 2021-01-13T21:35:48Z

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No, no need to refresh for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of “no breaking changes
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
- Adding a new API version
- Adding a new service
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable version with Breaking Change Validation errors
Updating API(s) in preview over 1 year

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

Merge Master

Merge latest master

openapi-workflow-bot · 2021-01-13T21:35:50Z

Hi, @david-msft Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

openapi-pipeline-app · 2021-01-13T21:35:52Z

Swagger Validation Report

️❌BreakingChange: 12 Errors, 0 Warnings failed [Detail]

Only 10 items are listed, please refer to log for more details.

Compared Swaggers (Based on Oad v0.8.5)
- original: preview/2017-08-01-beta/analysisservices.json <---> new: preview/2017-08-01-beta/analysisservices.json
- original: stable/2016-05-16/analysisservices.json <---> new: stable/2016-05-16/analysisservices.json
- original: stable/2017-07-14/analysisservices.json <---> new: stable/2017-07-14/analysisservices.json
- original: stable/2017-08-01/analysisservices.json <---> new: stable/2017-08-01/analysisservices.json

Rule	Message
`❌` 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.AnalysisServices/stable/2016-05-16/analysisservices.json#L1168:13 Old: Microsoft.AnalysisServices/stable/2016-05-16/analysisservices.json#L1117:13
`❌` 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.AnalysisServices/stable/2016-05-16/analysisservices.json#L1173:13 Old: Microsoft.AnalysisServices/stable/2016-05-16/analysisservices.json#L1121:13
`❌` 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.AnalysisServices/stable/2017-08-01/analysisservices.json#L1432:13 Old: Microsoft.AnalysisServices/stable/2017-08-01/analysisservices.json#L1379:13
`❌` 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.AnalysisServices/stable/2017-08-01/analysisservices.json#L1437:13 Old: Microsoft.AnalysisServices/stable/2017-08-01/analysisservices.json#L1383:13
`❌` 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.AnalysisServices/stable/2017-08-01/analysisservices.json#L1246:9 Old: Microsoft.AnalysisServices/stable/2017-08-01/analysisservices.json#L1246:9
`❌` 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.AnalysisServices/stable/2017-08-01/analysisservices.json#L1251:9 Old: Microsoft.AnalysisServices/stable/2017-08-01/analysisservices.json#L1250:9
`❌` 1026 - TypeChanged	The new version has a different type 'integer' than the previous one 'string'. New: Microsoft.AnalysisServices/stable/2016-05-16/analysisservices.json#L1168:13 Old: Microsoft.AnalysisServices/stable/2016-05-16/analysisservices.json#L1117:13
`❌` 1026 - TypeChanged	The new version has a different type 'integer' than the previous one 'string'. New: Microsoft.AnalysisServices/stable/2016-05-16/analysisservices.json#L1173:13 Old: Microsoft.AnalysisServices/stable/2016-05-16/analysisservices.json#L1121:13
`❌` 1026 - TypeChanged	The new version has a different type 'integer' than the previous one 'string'. New: Microsoft.AnalysisServices/stable/2017-08-01/analysisservices.json#L1432:13 Old: Microsoft.AnalysisServices/stable/2017-08-01/analysisservices.json#L1379:13
`❌` 1026 - TypeChanged	The new version has a different type 'integer' than the previous one 'string'. New: Microsoft.AnalysisServices/stable/2017-08-01/analysisservices.json#L1437:13 Old: Microsoft.AnalysisServices/stable/2017-08-01/analysisservices.json#L1383:13

️️✔️LintDiff succeeded [Detail] [Expand]

Validation passes for LintDiff.

Linted configuring files (Based on source branch, openapi-validator v1.6.0 , classic-openapi-validator v1.1.5 )
Linted configuring files (Based on target branch, openapi-validator v1.6.0 , classic-openapi-validator v1.1.5 )

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2021-01-13T21:35:53Z

Swagger Generation Artifacts

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs]Release - Generate from 33143c3. Schema Automation 14.0.0

warn	Skip initScript due to not configured
command	npx n 12
command	autorest --use=@autorest/[email protected] --version=3.0.6351 --azureresourceschema --multiapi --title=none --pass-thru:subset-reducer --azureresourceschema-folder=/home/vsts/work/1/s/azure-resource-manager-schemas/azure-resource-manager-schemas ../../azure-rest-api-specs/specification/analysisservices/resource-manager/readme.md
warn	No file changes detected after generation
warn	No package detected after generation

️❌ azure-sdk-for-net failed [Detail]

❌Failed [Logs]Release - Generate from 33143c3. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-5.0
command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/analysisservices/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied

❌Microsoft.Azure.Management.AnalysisServices [View full logs] [Release SDK Changes]

cmdout	[msbuild] /home/vsts/work/1/s/azure-sdk-for-net/sdk/analysisservices/Microsoft.Azure.Management.AnalysisServices/tests/ScenarioTests/ServerOperationsTests.cs(386,40): error CS0029: Cannot implicitly convert type 'string' to 'bool?' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/analysisservices/Microsoft.Azure.Management.AnalysisServices/tests/Microsoft.Azure.Management.AnalysisServices.Tests.csproj]
cmdout	[msbuild] /home/vsts/work/1/s/azure-sdk-for-net/sdk/analysisservices/Microsoft.Azure.Management.AnalysisServices/tests/ScenarioTests/ServerOperationsTests.cs(456,66): error CS0029: Cannot implicitly convert type 'string' to 'bool?' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/analysisservices/Microsoft.Azure.Management.AnalysisServices/tests/Microsoft.Azure.Management.AnalysisServices.Tests.csproj]
cmdout	[msbuild]      3>/home/vsts/work/1/s/azure-sdk-for-net/sdk/analysisservices/Microsoft.Azure.Management.AnalysisServices/tests/InMemoryTests/ServersTests.InMemory.cs(568,42): error CS1061: 'ErrorResponse' does not contain a definition for 'Code' and no accessible extension method 'Code' accepting a first argument of type 'ErrorResponse' could be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/analysisservices/Microsoft.Azure.Management.AnalysisServices/tests/Microsoft.Azure.Management.AnalysisServices.Tests.csproj]
cmdout	[msbuild]      3>/home/vsts/work/1/s/azure-sdk-for-net/sdk/analysisservices/Microsoft.Azure.Management.AnalysisServices/tests/ScenarioTests/ServerOperationsTests.cs(555,30): error CS0103: The name 'Status' does not exist in the current context [/home/vsts/work/1/s/azure-sdk-for-net/sdk/analysisservices/Microsoft.Azure.Management.AnalysisServices/tests/Microsoft.Azure.Management.AnalysisServices.Tests.csproj]
cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/analysisservices/Microsoft.Azure.Management.AnalysisServices/tests/ScenarioTests/ServerOperationsTests.cs(386,40): error CS0029: Cannot implicitly convert type 'string' to 'bool?' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/analysisservices/Microsoft.Azure.Management.AnalysisServices/tests/Microsoft.Azure.Management.AnalysisServices.Tests.csproj]
cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/analysisservices/Microsoft.Azure.Management.AnalysisServices/tests/ScenarioTests/ServerOperationsTests.cs(456,66): error CS0029: Cannot implicitly convert type 'string' to 'bool?' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/analysisservices/Microsoft.Azure.Management.AnalysisServices/tests/Microsoft.Azure.Management.AnalysisServices.Tests.csproj]
cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/analysisservices/Microsoft.Azure.Management.AnalysisServices/tests/InMemoryTests/ServersTests.InMemory.cs(568,42): error CS1061: 'ErrorResponse' does not contain a definition for 'Code' and no accessible extension method 'Code' accepting a first argument of type 'ErrorResponse' could be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/analysisservices/Microsoft.Azure.Management.AnalysisServices/tests/Microsoft.Azure.Management.AnalysisServices.Tests.csproj]
cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/analysisservices/Microsoft.Azure.Management.AnalysisServices/tests/InMemoryTests/ServersTests.InMemory.cs(569,42): error CS1061: 'ErrorResponse' does not contain a definition for 'Message' and no accessible extension method 'Message' accepting a first argument of type 'ErrorResponse' could be found (are you missing a using directive or an assembly reference?) [/home/vsts/work/1/s/azure-sdk-for-net/sdk/analysisservices/Microsoft.Azure.Management.AnalysisServices/tests/Microsoft.Azure.Management.AnalysisServices.Tests.csproj]
cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/analysisservices/Microsoft.Azure.Management.AnalysisServices/tests/ScenarioTests/ServerOperationsTests.cs(555,30): error CS0103: The name 'Status' does not exist in the current context [/home/vsts/work/1/s/azure-sdk-for-net/sdk/analysisservices/Microsoft.Azure.Management.AnalysisServices/tests/Microsoft.Azure.Management.AnalysisServices.Tests.csproj]
error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-net]: dotnet

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 33143c3. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/analysisservices/resource-manager/readme.md

️✔️@azure/arm-analysisservices [View full logs] [Release SDK Changes]

azure-arm-analysisservices-2.3.1.tgz

cmderr	[npmPack] loaded rollup.config.js with warnings
cmderr	[npmPack] (!) Unused external imports
cmderr	[npmPack] default imported from external module 'rollup' but never used
cmderr	[npmPack] ./esm/analysisServicesManagementClient.js → ./dist/arm-analysisservices.js...
cmderr	[npmPack] created ./dist/arm-analysisservices.js in 284ms

️❌ azure-sdk-for-go failed [Detail]

❌Failed [Logs]Release - Generate from 33143c3. SDK Automation 14.0.0

command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
cmderr	[main.go] [ERROR] this package does not exist even after the generation, this should never happen
error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go]: go run ./tools/generator/main.go
warn	Skip package processing as generation is failed

️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2021-01-13T21:39:21Z

Hi @david-msft, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
If you want to know the production traffic statistic, please see ARM Traffic statistic.
If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.

david-msft and others added 4 commits December 28, 2020 11:15

Merge pull request #1 from Azure/master

a5c1e62

Merge Master

Merge pull request #2 from Azure/master

4871a17

Merge Master

Merge pull request #3 from Azure/master

bfd34f2

Merge latest master

Add missing property and fix property type

a7c9e6b

openapi-sdkautomation bot mentioned this pull request Jan 13, 2021

[AutoPR @azure/arm-analysisservices] AAS - Fix Swagger Correctness Issue v3 AzureSDKAutomation/azure-sdk-for-js#3215

Closed

openapi-pipeline-app bot added the BreakingChangeReviewRequired label Jan 13, 2021

openapi-sdkautomation bot mentioned this pull request Jan 13, 2021

[AutoPR analysisservices] AAS - Fix Swagger Correctness Issue v3 AzureSDKAutomation/azure-resource-manager-schemas#1344

Draft

openapi-pipeline-app bot added the CI-BreakingChange-Go label Jan 13, 2021

openapi-sdkautomation bot mentioned this pull request Jan 13, 2021

[AutoPR Microsoft.Azure.Management.AnalysisServices] AAS - Fix Swagger Correctness Issue v3 AzureSDKAutomation/azure-sdk-for-net#2868

Closed

david-msft marked this pull request as ready for review January 13, 2021 22:34

openapi-assignment-bot bot assigned zhenglaizhang Jan 13, 2021

JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Jan 14, 2021

JeffreyRichter approved these changes Jan 14, 2021

View reviewed changes

zhenglaizhang merged commit 33143c3 into Azure:master Jan 15, 2021

This was referenced Jan 15, 2021

[ReleasePR @azure/arm-analysisservices] AAS - Fix Swagger Correctness v6 Azure/azure-sdk-for-js#12755

Closed

[ReleasePR Microsoft.Azure.Management.AnalysisServices] AAS - Fix Swagger Correctness v6 Azure/azure-sdk-for-net#17302

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

AAS - Fix Swagger Correctness Issue v3 #12422

AAS - Fix Swagger Correctness Issue v3 #12422

Uh oh!

david-msft commented Jan 13, 2021 •

edited

Loading

Uh oh!

openapi-workflow-bot bot commented Jan 13, 2021

Uh oh!

openapi-pipeline-app bot commented Jan 13, 2021 •

edited

Loading

Uh oh!

openapi-pipeline-app bot commented Jan 13, 2021 •

edited

Loading

Uh oh!

openapi-workflow-bot bot commented Jan 13, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

AAS - Fix Swagger Correctness Issue v3 #12422

AAS - Fix Swagger Correctness Issue v3 #12422

Uh oh!

Conversation

david-msft commented Jan 13, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

Uh oh!

openapi-workflow-bot bot commented Jan 13, 2021

Uh oh!

openapi-pipeline-app bot commented Jan 13, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Swagger Validation Report

Uh oh!

openapi-pipeline-app bot commented Jan 13, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Swagger Generation Artifacts

Uh oh!

openapi-workflow-bot bot commented Jan 13, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

david-msft commented Jan 13, 2021 •

edited

Loading

openapi-pipeline-app bot commented Jan 13, 2021 •

edited

Loading

openapi-pipeline-app bot commented Jan 13, 2021 •

edited

Loading