PII Types for 3.1-Preview.4#12392
Merged
tjprescott merged 11 commits intoAzure:dev-cognitiveservices-TextAnalytics-v3.1-preview.4from Jan 22, 2021
Merged
PII Types for 3.1-Preview.4#12392tjprescott merged 11 commits intoAzure:dev-cognitiveservices-TextAnalytics-v3.1-preview.4from
tjprescott merged 11 commits intoAzure:dev-cognitiveservices-TextAnalytics-v3.1-preview.4from
Conversation
|
Hi, @thediris Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
Swagger Validation Report
|
| Rule | Message |
|---|---|
|
"details":" "Channel": "fatal", "Details": null, "Text": "Newtonsoft.Json.JsonReaderException: Unexpected character encountered while parsing value: [. Path 'parameters.PiiCategories.default', line 1, position 61348.\n at Newtonsoft.Json.JsonTextReader.ReadStringValue(ReadType readType)\n at Newtonsoft.Json.JsonTextReader.ReadAsString()\n at Newtonsoft.Json.JsonReader.ReadForType(JsonContract contract, Boolean hasConverter)\n at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.PopulateObject(Object newObject, JsonReader reader, JsonObjectContract contract, JsonProperty member, String id)\n at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.CreateObject(JsonReader reader, Type objectType, JsonContract contract, JsonProperty member, JsonContainerContract containerContract, JsonProperty containerMember, Object existingValue)\n at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.PopulateDictionary(IDictionary dictionary, JsonReader reader, JsonDictionaryContract contract, JsonP", "location":"https://github.com/Azure/azure-rest-api-specs/blob/76dd8dc32e145392f1fa14a4295184176dd1342b/specification/cognitiveservices/data-plane/TextAnalytics/readme.md" |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️❌SemanticValidation: 23 Errors, 0 Warnings failed [Detail]
Only 10 items are listed, please refer to log for more details.
️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail]
| Rule | Message |
|---|---|
|
"new":"https://github.com/Azure/azure-rest-api-specs/blob/76dd8dc32e145392f1fa14a4295184176dd1342b/specification/cognitiveservices/data-plane/TextAnalytics/preview/v3.1-preview.4/TextAnalytics.json", "old":"https://github.com/Azure/azure-rest-api-specs/blob/master/specification/cognitiveservices/data-plane/TextAnalytics/preview/v3.1-preview.3/TextAnalytics.json", "details":"Error: Command failed: dotnet /home/vsts/work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/@azure/oad@0.8.6/node_modules/@azure/oad/dlls/OpenApiDiff.dll -o /tmp/old-resolved.json -n /tmp/new-resolved.json |
| Unhandled Exception: Newtonsoft.Json.JsonReaderException: Unexpected character encountered while parsing value: [. Path 'parameters.PiiCategories.default', line 1, position 65857.\n at Newtonsoft.Json.JsonTextReader.ReadStringValue(ReadType readType)\n at Newtonsoft.Json.JsonTextReader.ReadAsString()\n at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.ReadForType(JsonReader reader, JsonContract contract, Boolean hasConverter)\n at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.PopulateObject(Object newObject, JsonReader reader, JsonObjectContract contract, JsonProperty member, String id)\n at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.CreateObject(JsonReader reader, Type objectType, JsonContract contract, JsonProperty member, JsonContainerContract " |
️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail]
| Rule | Message |
|---|---|
|
"new":"https://github.com/Azure/azure-rest-api-specs/blob/76dd8dc32e145392f1fa14a4295184176dd1342b/specification/cognitiveservices/data-plane/TextAnalytics/preview/v3.1-preview.4/TextAnalytics.json", "old":"https://github.com/Azure/azure-rest-api-specs/blob/master/specification/cognitiveservices/data-plane/TextAnalytics/stable/v3.0/TextAnalytics.json", "details":"Error: Command failed: dotnet /home/vsts/work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/@azure/oad@0.8.6/node_modules/@azure/oad/dlls/OpenApiDiff.dll -o /tmp/old-resolved.json -n /tmp/new-resolved.json |
| Unhandled Exception: Newtonsoft.Json.JsonReaderException: Unexpected character encountered while parsing value: [. Path 'parameters.PiiCategories.default', line 1, position 65857.\n at Newtonsoft.Json.JsonTextReader.ReadStringValue(ReadType readType)\n at Newtonsoft.Json.JsonTextReader.ReadAsString()\n at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.ReadForType(JsonReader reader, JsonContract contract, Boolean hasConverter)\n at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.PopulateObject(Object newObject, JsonReader reader, JsonObjectContract contract, JsonProperty member, String id)\n at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.CreateObject(JsonReader reader, Type objectType, JsonContract contract, JsonProperty member, JsonContainerContract " |
Swagger Generation Artifacts
|
| Rule | Message |
|---|---|
|
"logUrl":"https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=189763&view=logs&j=fd490c07-0b22-5182-fac9-6d67fe1e939b", "detail":"Run.ps1 failed with exit code 128 " |
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
️✔️Succeeded [Logs] Generate from 2f3f4b1fb990e86053c25fbead37d8f5688d5940. SDK Automation 14.0.0command sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json command go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
️✔️cognitiveservices/v2.1/textanalytics [View full logs] [Preview SDK Changes]info [Changelog] No exported changes
️✔️cognitiveservices/v2.0/textanalytics [View full logs] [Preview SDK Changes]info [Changelog] No exported changes
️🔄 azure-sdk-for-python inProgress [Detail]
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
️✔️Succeeded [Logs] Generate from 2f3f4b1fb990e86053c25fbead37d8f5688d5940. SDK Automation 14.0.0warn Skip initScript due to not configured command autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.4.4 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/cognitiveservices/data-plane/TextAnalytics/readme.md
️✔️@azure/cognitiveservices-textanalytics [View full logs] [Preview SDK Changes]cmderr [npmPack] loaded rollup.config.js with warnings cmderr [npmPack] (!) Unused external imports cmderr [npmPack] default imported from external module 'rollup' but never used cmderr [npmPack] ./esm/textAnalyticsClient.js → ./dist/cognitiveservices-textanalytics.js... cmderr [npmPack] created ./dist/cognitiveservices-textanalytics.js in 179ms
️⚠️ azure-sdk-for-java warning [Detail]
⚠️Warning [Logs] Generate from 2f3f4b1fb990e86053c25fbead37d8f5688d5940. SDK Automation 14.0.0command ./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json command ./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json cmderr [generate.py] 2021-01-22 18:04:15 ERROR [Skip] readme path does not format as specification/*/resource-manager/readme.md warn No file changes detected after generation warn No package detected after generation
assafi
reviewed
Jan 12, 2021
...ication/cognitiveservices/data-plane/TextAnalytics/preview/v3.1-preview.4/TextAnalytics.json
Outdated
Show resolved
Hide resolved
|
Hi @thediris, Your PR has some issues. Please fix the CI sequentially by following the order of
|
Contributor
|
Could you also update the PII response example? |
abhahn
reviewed
Jan 12, 2021
...ication/cognitiveservices/data-plane/TextAnalytics/preview/v3.1-preview.4/TextAnalytics.json
Outdated
Show resolved
Hide resolved
...ication/cognitiveservices/data-plane/TextAnalytics/preview/v3.1-preview.4/TextAnalytics.json
Outdated
Show resolved
Hide resolved
openapi-pipeline-app
bot
added
CI-FixRequiredOnFailure
and removed
CI-FixRequiredOnFailure
labels
assafi
reviewed
Jan 15, 2021
...ication/cognitiveservices/data-plane/TextAnalytics/preview/v3.1-preview.4/TextAnalytics.json
Outdated
Show resolved
Hide resolved
openapi-pipeline-app
bot
added
CI-FixRequiredOnFailure
and removed
CI-FixRequiredOnFailure
labels
openapi-pipeline-app
bot
added
CI-FixRequiredOnFailure
and removed
CI-FixRequiredOnFailure
labels
openapi-pipeline-app
bot
added
CI-FixRequiredOnFailure
and removed
CI-FixRequiredOnFailure
labels
assafi
approved these changes
Jan 21, 2021
maririos
approved these changes
Jan 21, 2021
Member
|
@iscai-msft could you help get this PR merged? |
iscai-msft
reviewed
Jan 21, 2021
Contributor
iscai-msft
left a comment
iscai-msft
left a comment
There was a problem hiding this comment.
looks like there are still a couple of ci errors that seem valid. addressed some of them in my comments, but can help get it merged once it's fixed. thanks for doing this @thediris !
...ication/cognitiveservices/data-plane/TextAnalytics/preview/v3.1-preview.4/TextAnalytics.json
Show resolved
Hide resolved
...ication/cognitiveservices/data-plane/TextAnalytics/preview/v3.1-preview.4/TextAnalytics.json
Outdated
Show resolved
Hide resolved
openapi-pipeline-app
bot
added
CI-FixRequiredOnFailure
and removed
CI-FixRequiredOnFailure
labels
Member
|
@tjprescott can we get this merged ? |
tjprescott
merged commit 87f79f1
into
Azure:dev-cognitiveservices-TextAnalytics-v3.1-preview.4
anuchandy
added a commit
that referenced
this pull request
Feb 12, 2021
* Adds base for updating TextAnalytics from version preview/v3.1-preview.3 to version v3.1-preview.4 * Updates readme * Updates API version in new specs and examples * add entity linking task (#12366) * Opinion Mining API changes for Preview.4 (#12344) * Adding changed example * json change for om part 1 * Change API structure as well * refine text again * Getting back to false by default * word chagne * . * final wording change * fix for readme.md Co-authored-by: josuh <josuh@microsoft.com> * Analyze: made task results optional (#12373) * Made results array optional since tasks can be in a failed state with no results * Fixing a syntax issue in the README * Attempting to address an Autorest error in the README * Attempting to address an Autorest error in the README * Added some info about v3.1-preview.4 to the python readme file; attempting to correct syntax issues in readme.md * Attempting to fix generation for the Python SDK * Attempting to fix generation for the Python SDK Co-authored-by: Abigail Hartman <Abigail.Hartman@microsoft.com> * add stringtype parameter to entitylinking task (#12467) * TA v3.1-preview.4 - updated examples and definitions for TA for Health (#12340) * updated examples and health definitions for new preview version * fixed linting issue in readme * removed old properties in ta.json * undo changes to sentiment portion of response, update health response * fixed spelling issues * fixed more typose * remove linting issue in readme * added enums to assertions * add in ms-enum extension * ran prettier json linter over files * made assertion field singular * PII Types for 3.1-Preview.4 (#12392) * based off of correct branch now * change the request from enum to a generic list of strings * cleanup some other comments * add enum type * change type --> category * add categories to the swagger * update the types to make them read better * add in the NER types * add in address type as well * fix some typos * one last typo * Health descritpion and naming updates (#12616) * updated examples and health definitions for new preview version * fixed linting issue in readme * removed old properties in ta.json * undo changes to sentiment portion of response, update health response * fixed spelling issues * fixed more typose * remove linting issue in readme * added enums to assertions * add in ms-enum extension * ran prettier json linter over files * made assertion field singular * addressed comments and updated description * TA v3.1-preview.4 - Minor syntax changes to address comments on PR 12338 (#12650) * updated examples and health definitions for new preview version * fixed linting issue in readme * removed old properties in ta.json * undo changes to sentiment portion of response, update health response * fixed spelling issues * fixed more typose * remove linting issue in readme * added enums to assertions * add in ms-enum extension * ran prettier json linter over files * made assertion field singular * addressed comments and updated description * addressed comments for minor syntax changes * replaced all instances of well-known * fixed linting issue - pii category was set to list instead of string * [text analytics] Fixed Swagger validation issues for v3.1-preview.4 (#12660) * Trying to solve swagger validation issues * Removed x-ms-enum property from PiiCategories * Created a definition for PiiCategories in addition to a parameter in order to support passing the same thing in the body of a Task object * Ran 'prettier' to, uh... make it prettier. * Updated custom-words.txt * Corrected typos in Swagger and removed unneeded entries in custom-words.txt * Changed 'default' to 'x-ms-client-default' in order to pass both model validation and linting * Fixed a misspelled PII category * Reran prettier check * Removed an experimental line in the Swagger * Adding collectionFormat to fix an autorest error * Removing x-ms-client-default Co-authored-by: Abigail Hartman <Abigail.Hartman@microsoft.com> * Added Extensible Enum for Health Relation Types - Dev cognitiveservices text analytics v3.1 preview.4 (#12737) * updated examples and health definitions for new preview version * fixed linting issue in readme * removed old properties in ta.json * undo changes to sentiment portion of response, update health response * fixed spelling issues * fixed more typose * remove linting issue in readme * added enums to assertions * add in ms-enum extension * ran prettier json linter over files * made assertion field singular * addressed comments and updated description * addressed comments for minor syntax changes * replaced all instances of well-known * fixed linting issue - pii category was set to list instead of string * revert change to pii default * remove default value as this is an optional parameter * added extensible list to relation types for healthcare * revert change to pii default * changed enum type and made extensible via the modelAsString param * ran npm prettier check and fixed spelling error (#12947) Co-authored-by: Chris Tufts <christopher.tufts25@gmail.com> Co-authored-by: Mikael <mikael.sitruk@outlook.com> Co-authored-by: Joohee Suh <58048046+josuhazure@users.noreply.github.com> Co-authored-by: josuh <josuh@microsoft.com> Co-authored-by: Abigail Hartman <Abigail.Hahn@microsoft.com> Co-authored-by: Abigail Hartman <Abigail.Hartman@microsoft.com> Co-authored-by: Thaminda Edirisooriya <61993993+thediris@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for PII type filters as a request param - takes in a comma separated list of strings describing the types we support