Edit securityContact swagger for 2020-01-01 by ovedti · Pull Request #12265 · Azure/azure-rest-api-specs

ovedti · 2020-12-31T16:06:28Z

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No, no need to refresh for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of “no breaking changes
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
- Adding a new API version
- Adding a new service
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable version with Breaking Change Validation errors
Updating API(s) in preview over 1 year

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

openapi-workflow-bot · 2020-12-31T16:06:30Z

Hi, @ovedti Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

openapi-pipeline-app · 2020-12-31T16:06:32Z

Swagger Validation Report

️❌BreakingChange: 2 Errors, 0 Warnings failed [Detail]

Compared Swaggers (Based on Oad v0.8.6)
- original: preview/2020-01-01-preview/securityContacts.json <---> new: preview/2020-01-01-preview/securityContacts.json

Rule	Message
`❌` 1010 - AddingRequiredParameter	The required parameter 'securityContact' was added in the new version. New: Microsoft.Security/preview/2020-01-01-preview/securityContacts.json#L125:9
`❌` 1011 - AddingResponseCode	The new version adds a response code '200'. New: Microsoft.Security/preview/2020-01-01-preview/securityContacts.json#L146:11

️️✔️LintDiff succeeded [Detail] [Expand]

Validation passes for LintDiff.

Linted configuring files (Based on source branch, openapi-validator v1.7.0 , classic-openapi-validator v1.1.5 )
- security/resource-manager/readme.md tag:default
Linted configuring files (Based on target branch, openapi-validator v1.7.0 , classic-openapi-validator v1.1.5 )
- security/resource-manager/readme.md tag:default

️⚠️Avocado: 1 Warnings warning [Detail]

Rule	Message
⚠️ MULTIPLE_API_VERSION	The default tag contains multiple API versions swaggers. readme: specification/security/resource-manager/readme.md tag: specification/security/resource-manager/readme.md#tag-package-composite-v3

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2020-12-31T16:06:32Z

Swagger Generation Artifacts

️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️⚠️ azure-sdk-for-python warning [Detail]

⚠️Warning [Logs] Generate from da853b84d65d210e39e6bce0092c3cb18683c71f. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
cmderr	[automation_init.sh]   Failed building wheel for ConfigArgParse
cmderr	[automation_init.sh]   Failed building wheel for wrapt
cmderr	[automation_init.sh]   Failed building wheel for yarl
cmderr	[automation_init.sh]   Failed building wheel for multidict
cmderr	[automation_init.sh] Cannot uninstall requirement azure-nspkg, not installed
cmderr	[automation_init.sh] Command '['/home/vsts/work/1/s/azure-sdk-for-python_tmp/venv-sdk/bin/python', '-m', 'pip', 'uninstall', '-y', 'azure-nspkg']' returned non-zero exit status 1.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json

️✔️azure-mgmt-security [View full logs] [Preview SDK Changes] Breaking Change Detected

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Model IoTSecuritySolutionModel has a new parameter additional_workspaces
info	[Changelog]   - Model IoTSecuritySolutionModel has a new parameter system_data
info	[Changelog]   - Model IotAlertModel has a new parameter type
info	[Changelog]   - Model IotAlertModel has a new parameter name
info	[Changelog]   - Model IotAlertModel has a new parameter id
info	[Changelog]   - Model IotAlert has a new parameter type
info	[Changelog]   - Model IotAlert has a new parameter name
info	[Changelog]   - Model IotAlert has a new parameter id
info	[Changelog]   - Model PackageDownloads has a new parameter snmp
info	[Changelog]   - Model PackageDownloads has a new parameter authorized_devices_import_template
info	[Changelog]   - Model PackageDownloads has a new parameter wmi_tool
info	[Changelog]   - Model PackageDownloads has a new parameter device_information_update_import_template
info	[Changelog]   - Added operation IotDefenderSettingsOperations.download_manager_activation
info	[Changelog]   - Added operation OnPremiseIotSensorsOperations.download_reset_password
info	[Changelog]   - Added operation IotSensorsOperations.trigger_ti_package_update
info	[Changelog]   - Added operation IotSensorsOperations.download_reset_password
info	[Changelog]   - Added operation group IotSitesOperations
info	[Changelog]
info	[Changelog] **Breaking changes**
info	[Changelog]
info	[Changelog]   - Operation IotSensorsOperations.create_or_update has a new signature

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from da853b84d65d210e39e6bce0092c3cb18683c71f. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.4.4 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/security/resource-manager/readme.md

️✔️@azure/arm-security [View full logs] [Preview SDK Changes]

azure-arm-security-2.0.0.tgz

cmderr	[npmPack] loaded rollup.config.js with warnings
cmderr	[npmPack] (!) Unused external imports
cmderr	[npmPack] default imported from external module 'rollup' but never used
cmderr	[npmPack] ./esm/securityCenter.js → ./dist/arm-security.js...
cmderr	[npmPack] created ./dist/arm-security.js in 1.3s

️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from da853b84d65d210e39e6bce0092c3cb18683c71f. Schema Automation 14.0.0

warn	Skip initScript due to not configured
command	npx n 12
command	autorest --use=@autorest/azureresourceschema@3.0.92 --version=3.0.6369 --azureresourceschema --multiapi --title=none --pass-thru:subset-reducer --azureresourceschema-folder=/home/vsts/work/1/s/azure-resource-manager-schemas/azure-resource-manager-schemas ../../azure-rest-api-specs/specification/security/resource-manager/readme.md

️✔️security [View full logs] [Preview Schema Changes]

cmderr	[resource-manager] node-pre-gyp
cmderr	[resource-manager] WARN Using request for node-pre-gyp https download
cmderr	[resource-manager]  template-schema-validation-tools@1.0.0 No repository field.
cmderr	[resource-manager]  SKIPPING OPTIONAL DEPENDENCY: fsevents@2.1.3 (node_modules/fsevents):
cmderr	[resource-manager]  SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@2.1.3: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})

️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from da853b84d65d210e39e6bce0092c3cb18683c71f. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-5.0
command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/security/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.SecurityCenter [View full logs] [Preview SDK Changes]
- Microsoft.Azure.Management.SecurityCenter.2.2.0.nupkg
- Microsoft.Azure.Management.SecurityCenter.2.2.0.snupkg

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from da853b84d65d210e39e6bce0092c3cb18683c71f. SDK Automation 14.0.0

command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️preview/security/mgmt/v3.0/security [View full logs] [Preview SDK Changes] Breaking Change Detected

Only show 40 items here, please refer to log for details.

info	[Changelog] - New function `ConnectionFromIPNotAllowed.AsBasicCustomAlertRule() (BasicCustomAlertRule, bool)`
info	[Changelog] - New function `ListCustomAlertRule.AsConnectionFromIPNotAllowed() (*ConnectionFromIPNotAllowed, bool)`
info	[Changelog] - New function `ConnectionFromIPNotAllowed.AsLocalUserNotAllowed() (*LocalUserNotAllowed, bool)`
info	[Changelog] - New function `QueuePurgesNotInAllowedRange.AsConnectionFromIPNotAllowed() (*ConnectionFromIPNotAllowed, bool)`
info	[Changelog] - New function `ConnectionFromIPNotAllowed.AsHTTPC2DMessagesNotInAllowedRange() (*HTTPC2DMessagesNotInAllowedRange, bool)`
info	[Changelog] - New function `MqttC2DMessagesNotInAllowedRange.AsConnectionFromIPNotAllowed() (*ConnectionFromIPNotAllowed, bool)`
info	[Changelog] - New function `ConnectionFromIPNotAllowed.AsAmqpC2DMessagesNotInAllowedRange() (*AmqpC2DMessagesNotInAllowedRange, bool)`
info	[Changelog] - New function `PossibleCreatedByTypeValues() []CreatedByType`
info	[Changelog] - New function `ActiveConnectionsNotInAllowedRange.AsConnectionFromIPNotAllowed() (*ConnectionFromIPNotAllowed, bool)`
info	[Changelog] - New function `ConnectionFromIPNotAllowed.AsTwinUpdatesNotInAllowedRange() (*TwinUpdatesNotInAllowedRange, bool)`
info	[Changelog] - New function `ConnectionFromIPNotAllowed.AsMqttD2CMessagesNotInAllowedRange() (*MqttD2CMessagesNotInAllowedRange, bool)`
info	[Changelog] - New function `ConnectionFromIPNotAllowed.AsConnectionFromIPNotAllowed() (*ConnectionFromIPNotAllowed, bool)`
info	[Changelog] - New function `UnauthorizedOperationsNotInAllowedRange.AsConnectionFromIPNotAllowed() (*ConnectionFromIPNotAllowed, bool)`
info	[Changelog] - New function `ConnectionFromIPNotAllowed.AsDirectMethodInvokesNotInAllowedRange() (*DirectMethodInvokesNotInAllowedRange, bool)`
info	[Changelog] - New function `ConnectionFromIPNotAllowed.AsDenylistCustomAlertRule() (*DenylistCustomAlertRule, bool)`
info	[Changelog] - New function `ConnectionFromIPNotAllowed.AsProcessNotAllowed() (*ProcessNotAllowed, bool)`
info	[Changelog] - New function `ConnectionFromIPNotAllowed.AsUnauthorizedOperationsNotInAllowedRange() (*UnauthorizedOperationsNotInAllowedRange, bool)`
info	[Changelog] - New function `ConnectionFromIPNotAllowed.AsListCustomAlertRule() (*ListCustomAlertRule, bool)`
info	[Changelog] - New function `ConnectionFromIPNotAllowed.AsThresholdCustomAlertRule() (*ThresholdCustomAlertRule, bool)`
info	[Changelog] - New function `DirectMethodInvokesNotInAllowedRange.AsConnectionFromIPNotAllowed() (*ConnectionFromIPNotAllowed, bool)`
info	[Changelog] - New function `HTTPC2DRejectedMessagesNotInAllowedRange.AsConnectionFromIPNotAllowed() (*ConnectionFromIPNotAllowed, bool)`
info	[Changelog] - New function `ThresholdCustomAlertRule.AsConnectionFromIPNotAllowed() (*ConnectionFromIPNotAllowed, bool)`
info	[Changelog] - New struct `AdditionalWorkspacesProperties`
info	[Changelog] - New struct `ConnectionFromIPNotAllowed`
info	[Changelog] - New struct `ErrorAdditionalInfo`
info	[Changelog] - New struct `SystemData`
info	[Changelog] - New field `Details` in struct `CloudErrorBody`
info	[Changelog] - New field `AdditionalInfo` in struct `CloudErrorBody`
info	[Changelog] - New field `Target` in struct `CloudErrorBody`
info	[Changelog] - New field `AdditionalWorkspaces` in struct `IoTSecuritySolutionProperties`
info	[Changelog] - New field `Name` in struct `IotAlert`
info	[Changelog] - New field `Type` in struct `IotAlert`
info	[Changelog] - New field `ID` in struct `IotAlert`
info	[Changelog] - New field `SystemData` in struct `IoTSecuritySolutionModel`
info	[Changelog] - New field `ID` in struct `IotAlertModel`
info	[Changelog] - New field `Name` in struct `IotAlertModel`
info	[Changelog] - New field `Type` in struct `IotAlertModel`
info	[Changelog]
info	[Changelog] Total 14 breaking change(s), 92 additive change(s).
info	[Changelog]

️✔️preview/security/mgmt/v2.0/security [View full logs] [Preview SDK Changes] Breaking Change Detected

Only show 40 items here, please refer to log for details.

info	[Changelog] - Const `SecureScoreControls` has been removed
info	[Changelog] - Const `Assessments` has been removed
info	[Changelog] - Const `Alerts` has been removed
info	[Changelog] - Const `SubAssessments` has been removed
info	[Changelog] - Const `SettingKindAlertSuppressionSetting` has been removed
info	[Changelog] - Const `SecureScores` has been removed
info	[Changelog] - Function `SettingResource.MarshalJSON` has been removed
info	[Changelog] - Function `PossibleSettingKindValues` has been removed
info	[Changelog] - Struct `SettingResource` has been removed
info	[Changelog]
info	[Changelog] ### New Content
info	[Changelog]
info	[Changelog] - New const `EventSourceSecureScoresSnapshot`
info	[Changelog] - New const `EventSourceSecureScoreControlsSnapshot`
info	[Changelog] - New const `EventSourceRegulatoryComplianceAssessmentSnapshot`
info	[Changelog] - New const `EventSourceSubAssessments`
info	[Changelog] - New const `EventSourceAlerts`
info	[Changelog] - New const `EventSourceSecureScores`
info	[Changelog] - New const `EventSourceRegulatoryComplianceAssessment`
info	[Changelog] - New const `KindDataExportSetting`
info	[Changelog] - New const `KindSetting`
info	[Changelog] - New const `EventSourceSecureScoreControls`
info	[Changelog] - New const `EventSourceAssessments`
info	[Changelog] - New function `Setting.AsBasicSetting() (BasicSetting, bool)`
info	[Changelog] - New function `PossibleKindEnum1Values() []KindEnum1`
info	[Changelog] - New function `Setting.AsDataExportSetting() (*DataExportSetting, bool)`
info	[Changelog] - New function `DataExportSetting.AsSetting() (*Setting, bool)`
info	[Changelog] - New function `Setting.AsSetting() (*Setting, bool)`
info	[Changelog] - New function `DataExportSetting.AsBasicSetting() (BasicSetting, bool)`
info	[Changelog] - New function `*SettingsList.UnmarshalJSON([]byte) error`
info	[Changelog] - New function `*SettingModel.UnmarshalJSON([]byte) error`
info	[Changelog] - New function `DataExportSetting.AsDataExportSetting() (*DataExportSetting, bool)`
info	[Changelog] - New struct `ErrorAdditionalInfo`
info	[Changelog] - New struct `SettingModel`
info	[Changelog] - New field `AdditionalInfo` in struct `CloudErrorBody`
info	[Changelog] - New field `Target` in struct `CloudErrorBody`
info	[Changelog] - New field `Details` in struct `CloudErrorBody`
info	[Changelog]
info	[Changelog] Total 29 breaking change(s), 26 additive change(s).
info	[Changelog]

️✔️preview/security/mgmt/v1.0/security [View full logs] [Preview SDK Changes] Breaking Change Detected

Only show 40 items here, please refer to log for details.

info	[Changelog] - Const `SubAssessments` has been removed
info	[Changelog] - Const `Assessments` has been removed
info	[Changelog] - Const `SecureScores` has been removed
info	[Changelog] - Const `SettingKindAlertSuppressionSetting` has been removed
info	[Changelog] - Const `SecureScoreControls` has been removed
info	[Changelog] - Const `SettingKindDataExportSetting` has been removed
info	[Changelog] - Function `SettingResource.MarshalJSON` has been removed
info	[Changelog] - Function `PossibleSettingKindValues` has been removed
info	[Changelog] - Struct `SettingResource` has been removed
info	[Changelog]
info	[Changelog] ### New Content
info	[Changelog]
info	[Changelog] - New const `EventSourceSecureScoreControls`
info	[Changelog] - New const `KindDataExportSetting`
info	[Changelog] - New const `EventSourceSecureScoresSnapshot`
info	[Changelog] - New const `EventSourceSubAssessments`
info	[Changelog] - New const `EventSourceSecureScoreControlsSnapshot`
info	[Changelog] - New const `KindSetting`
info	[Changelog] - New const `EventSourceRegulatoryComplianceAssessment`
info	[Changelog] - New const `EventSourceAssessments`
info	[Changelog] - New const `EventSourceSecureScores`
info	[Changelog] - New const `EventSourceRegulatoryComplianceAssessmentSnapshot`
info	[Changelog] - New const `EventSourceAlerts`
info	[Changelog] - New function `*SettingModel.UnmarshalJSON([]byte) error`
info	[Changelog] - New function `PossibleKindEnum1Values() []KindEnum1`
info	[Changelog] - New function `Setting.AsBasicSetting() (BasicSetting, bool)`
info	[Changelog] - New function `Setting.AsDataExportSetting() (*DataExportSetting, bool)`
info	[Changelog] - New function `*SettingsList.UnmarshalJSON([]byte) error`
info	[Changelog] - New function `DataExportSetting.AsBasicSetting() (BasicSetting, bool)`
info	[Changelog] - New function `DataExportSetting.AsDataExportSetting() (*DataExportSetting, bool)`
info	[Changelog] - New function `Setting.AsSetting() (*Setting, bool)`
info	[Changelog] - New function `DataExportSetting.AsSetting() (*Setting, bool)`
info	[Changelog] - New struct `ErrorAdditionalInfo`
info	[Changelog] - New struct `SettingModel`
info	[Changelog] - New field `Target` in struct `CloudErrorBody`
info	[Changelog] - New field `Details` in struct `CloudErrorBody`
info	[Changelog] - New field `AdditionalInfo` in struct `CloudErrorBody`
info	[Changelog]
info	[Changelog] Total 29 breaking change(s), 26 additive change(s).
info	[Changelog]

_{Posted by Swagger Pipeline | How to fix these errors?}

ovedti · 2020-12-31T16:09:18Z

I see that this PR raised a "breaking chage" flag, but it is actually has not been published yet.
I just added another response code to PUT operation and change the name to meet the new capability (from "Create" to "Create Or Update")
Appreciate your approval :)

openapi-workflow-bot · 2020-12-31T16:10:23Z

Hi @ovedti, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
If you want to know the production traffic statistic, please see ARM Traffic statistic.
If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ma/swaggerfeedback.

yungezz · 2021-01-04T01:40:42Z

hi @msyyc could you pls help confirm impact to Python SDK?
hi @ArcturusZhang could you pls help confirm impact to Go SDK?

msyyc · 2021-01-04T01:59:56Z

hi @msyyc Yuchao Yan FTE could you pls help confirm impact to Python SDK?
hi @ArcturusZhang Dapeng Zhang FTE could you pls help confirm impact to Go SDK?

It's ok for python

ArcturusZhang · 2021-01-05T06:36:14Z

Go breaking changes are not introduced in this PR

yungezz · 2021-01-13T06:33:12Z

communicated with @ovedti over teams, this breaking change is necessary for the team. @ovedti is going through the process

ovedti · 2021-01-13T10:33:05Z

communicated with @ovedti over teams, this breaking change is necessary for the team. @ovedti is going through the process

Thanks! I created an ADO, waiting for their response 👍
https://msazure.visualstudio.com/One/_workitems/edit/9045005

yungezz · 2021-01-26T10:15:20Z

unfortunately, adding new statuscode to existing version is also breakingchange :(

openapi-workflow-bot · 2021-01-31T14:25:31Z

Hi @ovedti, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff.

Task	How to fix	Priority	Support (Microsoft alias)
Avocado	Fix-Avocado	High	ruowan
Semantic validation	Fix-SemanticValidation-Error	High	raychen, jianyxi
Model validation	Fix-ModelValidation-Error	High	raychen,jianyxi
LintDiff	Fix-LintDiff	high	jianyxi, ruoxuan

If you need further help, please feedback via swagger feedback."

...ecurity/resource-manager/Microsoft.Security/preview/2020-01-01-preview/securityContacts.json

yungezz · 2021-02-01T03:27:11Z

hi @msyyc Yuchao Yan FTE could you pls help confirm impact to Python SDK?
hi @ArcturusZhang Dapeng Zhang FTE could you pls help confirm impact to Go SDK?

It's ok for python

HI @ArcturusZhang @msyyc sorry the PR has new commit, which adding a new param to create call https://github.com/Azure/azure-rest-api-specs/pull/12265/files#diff-60a32dc7bc6d8e143ae6ecf7ab442860ae7666a2e0038ade276cf85d7bee3036R136. Could you pls re-evaluate impact to Go and Python SDKs? thanks

yungezz · 2021-02-02T12:04:40Z

hi @msyyc Yuchao Yan FTE could you pls help confirm impact to Python SDK?
hi @ArcturusZhang Dapeng Zhang FTE could you pls help confirm impact to Go SDK?

It's ok for python

HI @ArcturusZhang @msyyc sorry the PR has new commit, which adding a new param to create call https://github.com/Azure/azure-rest-api-specs/pull/12265/files#diff-60a32dc7bc6d8e143ae6ecf7ab442860ae7666a2e0038ade276cf85d7bee3036R136. Could you pls re-evaluate impact to Go and Python SDKs? thanks

hi @msyyc @ArcturusZhang could you pls confirm impact to Python and GO SDK? thanks

ArcturusZhang · 2021-02-03T06:46:23Z

@yungezz this PR does not introduce breaking changes to go SDK

ovedti · 2021-02-08T08:36:25Z

Yuchao Yan @msyyc
Hi, any updates regarding Python SDK?
Appreciate your feedback :)

msyyc · 2021-02-10T01:42:10Z

This PR is ok for Python

openapi-assignment-bot bot assigned yungezz Dec 31, 2020

openapi-pipeline-app bot added the BreakingChangeReviewRequired label Dec 31, 2020

openapi-sdkautomation bot mentioned this pull request Dec 31, 2020

[AutoPR azure-mgmt-security] Edit securityContact swagger for 2020-01-01 AzureSDKAutomation/azure-sdk-for-python#3523

Draft

openapi-pipeline-app bot added the CI-BreakingChange-Python label Dec 31, 2020

openapi-sdkautomation bot mentioned this pull request Dec 31, 2020

[AutoPR security] Edit securityContact swagger for 2020-01-01 AzureSDKAutomation/azure-resource-manager-schemas#1261

Draft

openapi-pipeline-app bot added the CI-BreakingChange-Go label Dec 31, 2020

This was referenced Dec 31, 2020

[AutoPR Microsoft.Azure.Management.SecurityCenter] Edit securityContact swagger for 2020-01-01 AzureSDKAutomation/azure-sdk-for-net#2756

Draft

[AutoPR @azure/arm-security] Edit securityContact swagger for 2020-01-01 AzureSDKAutomation/azure-sdk-for-js#3099

Draft

ovedti force-pushed the master branch 2 times, most recently from 867c650 to 4158e2d Compare January 3, 2021 14:05

yungezz mentioned this pull request Jan 4, 2021

Wrong link in PR comment #12272

Closed

Edit securityContact swagger for 2020-01-01

e18b726

ovedti force-pushed the master branch from 4158e2d to e18b726 Compare January 26, 2021 10:04

openapi-pipeline-app bot added the CI-FixRequiredOnFailure label Jan 31, 2021

openapi-pipeline-app bot removed the CI-FixRequiredOnFailure label Jan 31, 2021

add request body to SecurityContacts PUT

2e3e62b

ovedti force-pushed the master branch from 6a12b64 to 2e3e62b Compare January 31, 2021 14:46

mikreite reviewed Jan 31, 2021

View reviewed changes

...ecurity/resource-manager/Microsoft.Security/preview/2020-01-01-preview/securityContacts.json Show resolved Hide resolved

JeffreyRichter approved these changes Feb 1, 2021

View reviewed changes

JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Feb 1, 2021

yungezz approved these changes Feb 10, 2021

View reviewed changes

yungezz merged commit 09961d9 into Azure:master Feb 10, 2021

Conversation

ovedti commented Dec 31, 2020 • edited by JackTn Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

Uh oh!

openapi-workflow-bot bot commented Dec 31, 2020

Uh oh!

openapi-pipeline-app bot commented Dec 31, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Swagger Validation Report

Uh oh!

openapi-pipeline-app bot commented Dec 31, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Swagger Generation Artifacts

Uh oh!

ovedti commented Dec 31, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openapi-workflow-bot bot commented Dec 31, 2020

Uh oh!

yungezz commented Jan 4, 2021

Uh oh!

msyyc commented Jan 4, 2021

Uh oh!

ArcturusZhang commented Jan 5, 2021

Uh oh!

yungezz commented Jan 13, 2021

Uh oh!

ovedti commented Jan 13, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yungezz commented Jan 26, 2021

Uh oh!

openapi-workflow-bot bot commented Jan 31, 2021

Uh oh!

Uh oh!

yungezz commented Feb 1, 2021

Uh oh!

yungezz commented Feb 2, 2021

Uh oh!

ArcturusZhang commented Feb 3, 2021

Uh oh!

ovedti commented Feb 8, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

msyyc commented Feb 10, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

ovedti commented Dec 31, 2020 •

edited by JackTn

Loading

openapi-pipeline-app bot commented Dec 31, 2020 •

edited

Loading

openapi-pipeline-app bot commented Dec 31, 2020 •

edited

Loading

ovedti commented Dec 31, 2020 •

edited

Loading

ovedti commented Jan 13, 2021 •

edited

Loading

ovedti commented Feb 8, 2021 •

edited

Loading