Dev cost management microsoft.cost management 2020 12 01 preview new#12259
Merged
yungezz merged 12 commits intoAzure:masterfrom Feb 10, 2021
Conversation
|
Hi, @absyed Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
Swagger Validation Report
|
| Rule | Message |
|---|---|
| The operation 'GenerateDetailedCostReportOperationResults_Get' returns 202 status code, which indicates a long running operation, please enable 'x-ms-long-running-operation. New: Microsoft.CostManagement/preview/2020-12-01-preview/costmanagement.generatedetailedcostreport.json#L123 |
|
| OperationId should contain the verb: 'generatedetailedcostreport' in:'GenerateDetailedCostReport_CreateOperation'. Consider updating the operationId New: Microsoft.CostManagement/preview/2020-12-01-preview/costmanagement.generatedetailedcostreport.json#L41 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
Swagger Generation Artifacts
|
|
Hi, @absyed your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). cc @yungezz |
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
This was referenced Dec 30, 2020
This was referenced Dec 30, 2020
...urce-manager/Microsoft.CostManagement/preview/2020-12-01-preview/costmanagement.exports.json
Outdated
Show resolved
Hide resolved
...ent/resource-manager/Microsoft.CostManagement/preview/2020-12-01-preview/costmanagement.json
Outdated
Show resolved
Hide resolved
| "description": "The URL to download the generated report.", | ||
| "type": "string" | ||
| }, | ||
| "validTill": { |
Contributor
There was a problem hiding this comment.
perhaps consider a different name such as expirationDate, also might be worth adding the format as part of the description: e.g. 2020-10-01 01:01 UTC something like that.
Contributor
Author
There was a problem hiding this comment.
Added more information in description
| "modelAsString": true | ||
| } | ||
| }, | ||
| "timePeriod": { |
Contributor
There was a problem hiding this comment.
What happens when a POST operation has timePeriod and billingPeriod? which one wins? consider adding this info as part of the description.
Contributor
Author
There was a problem hiding this comment.
If the customer has both timePeriod and billingPeriod, API will return back a 400 and ask the client to only use one. This is what I have in description for them, let me know if I should update it "Can only have one of either timePeriod or invoiceId or billingPeriod parameters."
yungezz
reviewed
Jan 4, 2021
| } | ||
| } | ||
| }, | ||
| "Resource": { |
Member
There was a problem hiding this comment.
Curious why all properties are readOnly?
Contributor
Author
There was a problem hiding this comment.
Keeping it consistent with how it already has been defined in costmangement.json
Member
|
Need ARM review since new API version added. hi @absyed, could you pls fix LintDiff CI failure? |
|
Hi @absyed, Your PR has some issues. Please fix the CI sequentially by following the order of
|
openapi-pipeline-app
bot
added
CI-FixRequiredOnFailure
and removed
CI-FixRequiredOnFailure
labels
openapi-pipeline-app
bot
added
CI-BreakingChange-Python
and removed
CI-FixRequiredOnFailure
labels
Contributor
|
ARM signed off |
jorgecotillo
added
ARMSignedOff
yungezz
reviewed
Jan 5, 2021
|
|
||
| These settings apply only when `--tag=package-preview-2020-12` is specified on the command line. | ||
|
|
||
| ```yaml $(tag) == 'package-preview-2020-12' |
Member
There was a problem hiding this comment.
why this preview tag contains table version Swaggers?
Member
|
hi @msyyc could you pls check impact to Python SDK? thanks |
yungezz
added
the
DoNotMerge
Member
It's ok for Python |
|
Hi, @absyed. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
ghost
added
the
Contributor
Author
Member
Member
|
For python, the breaking change is not caused by this PR |
Contributor
Author
Hi @yungezz, server side changes are in Production now and the PR is Ok to be merged in. |
yungezz
reviewed
Feb 2, 2021
| "description": "The URL to check the status of the asynchronous operation.", | ||
| "type": "string" | ||
| }, | ||
| "Azure-AsyncOperation": { |
Member
There was a problem hiding this comment.
what's difference between Azure-AsyncOperation and Azure-Consumption-AsyncOperation?
Contributor
Author
There was a problem hiding this comment.
The both return the same value.
We have been offering both headers for this service for some time, so am maintaining consistency here.
yungezz
removed
the
DoNotMerge
yungezz
approved these changes
Feb 2, 2021
Member
|
hi @absyed, before merging, one thing to confirm, about the swagger file name |
Contributor
Author
Hi @yungezz, this is following the costmanagement.export.json which already exist. In this new preview API version is the first time generatedetailedcostreport API is being introduced. |
Contributor
Author
|
@lirenhe can you please let me know if there is anything else required for this PR to be checked in? |
yungezz
approved these changes
Feb 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.