-
Notifications
You must be signed in to change notification settings - Fork 5.6k
[synapse] Mark 'sparkJobs' as nullable #12258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
```System.Text.Json.JsonException : A property 'sparkJobs' defined as non-nullable but received as null from the service. This exception only happens in DEBUG builds of the library and would be ignored in the release build```
|
Hi, @chamons Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
Swagger Validation Report
|
|
Swagger pipeline restarted successfully, please wait for status update in this comment. |
idear1203
approved these changes
Jan 5, 2021
chamons
added a commit
to Azure/azure-sdk-for-net
that referenced
this pull request
Jan 12, 2021
- Add a LRO for spark operations that require special Livy poling - The logic in these LRO is ported from test helpers written by the client team (and removed here as well) - This is a rebase of #17677 - I had to shut up a few tests due to more nullability issues (fixing in Azure/azure-rest-api-specs#12258) Co-authored-by: Mariana Rios Flores <[email protected]> Co-authored-by: Christopher Scott <[email protected]>
chamons
added a commit
to Azure/azure-sdk-for-net
that referenced
this pull request
Jan 12, 2021
minnieliu
pushed a commit
to minnieliu/azure-sdk-for-net
that referenced
this pull request
Jan 23, 2021
- Add a LRO for spark operations that require special Livy poling - The logic in these LRO is ported from test helpers written by the client team (and removed here as well) - This is a rebase of Azure#17677 - I had to shut up a few tests due to more nullability issues (fixing in Azure/azure-rest-api-specs#12258) Co-authored-by: Mariana Rios Flores <[email protected]> Co-authored-by: Christopher Scott <[email protected]>
minnieliu
pushed a commit
to minnieliu/azure-sdk-for-net
that referenced
this pull request
Jan 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
System.Text.Json.JsonException : A property 'sparkJobs' defined as non-nullable but received as null from the service. This exception only happens in DEBUG builds of the library and would be ignored in the release buildMSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.