Skip to content

Conversation

@nathannfan
Copy link
Contributor

@nathannfan nathannfan commented May 12, 2017

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • [] If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger


This change is Reviewable

@balajikris
Copy link
Contributor

Hey @nathannfan - so all commits to this PR are purely moving stuff from one spec to another? No other additions/deletions expected?

@nathannfan
Copy link
Contributor Author

@balajikris yep, just doing this to rework the categories we're generating in docs.microsoft.com. I did have to copy SubResource to servers.json as a dependency, but nothing new.

@balajikris
Copy link
Contributor

For existing warns/errors, there is a open workitem that we're tracking. This PR doesn't create any new violations. I've reviewed the changes and I'm okay with it. Merging in as is.

@balajikris balajikris merged commit 87c798c into Azure:master May 15, 2017
@nathannfan
Copy link
Contributor Author

Thanks, @balajikris!

@AutorestCI
Copy link

No modification for NodeJS

@AutorestCI
Copy link

@AutorestCI
Copy link

mccleanp pushed a commit that referenced this pull request Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants