Skip to content

Pluaralize ComputePolicies operation group#1214

Merged
fearthecowboy merged 1 commit intoAzure:masterfrom
begoldsm:master
May 10, 2017
Merged

Pluaralize ComputePolicies operation group#1214
fearthecowboy merged 1 commit intoAzure:masterfrom
begoldsm:master

Conversation

@begoldsm
Copy link
Copy Markdown
Contributor

@begoldsm begoldsm commented May 10, 2017

This was missed during initial swagger review. This new group should by
pluralized since it also contains an object called "ComputePolicy"

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

This was missed during initial swagger review. This new group should by
pluralized since it also contains an object called "ComputePolicy"
@begoldsm
Copy link
Copy Markdown
Contributor Author

@amarzavery I do not believe this has resulted in anything being published yet, so this should not be a breaking change. I have not triggered any publish jobs and the AutoRestCI PRs triggered from the original change (#1182) are both still open, so we should be good to merge this and then publish from these changes.

@fearthecowboy fearthecowboy merged commit 12b641f into Azure:master May 10, 2017
begoldsm pushed a commit to begoldsm/azure-sdk-for-net that referenced this pull request May 10, 2017
This swagger update is from PR:
Azure/azure-rest-api-specs#1214
* Rename ComputePolicy operation to ComputePolicies

ComputePolicy was never published, so this is not a breaking change and
it was caught as part of a sanity check prior to publishing, so there is
no risk in this change.
shahabhijeet pushed a commit to Azure/azure-sdk-for-net that referenced this pull request May 11, 2017
This swagger update is from PR:
Azure/azure-rest-api-specs#1214
* Rename ComputePolicy operation to ComputePolicies

ComputePolicy was never published, so this is not a breaking change and
it was caught as part of a sanity check prior to publishing, so there is
no risk in this change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants