Skip to content

[Hub Generated] Review request for Microsoft.Authorization to add version stable/2020-09-01 #11961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jan 6, 2021
Merged

[Hub Generated] Review request for Microsoft.Authorization to add version stable/2020-09-01 #11961

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
d14cbff
Ensuring dataPolicyManifests follow the rules of autorest/docs/extens…
feruilob Dec 4, 2020
5a86d51
Following the rulesof autorest/docs/extensions/readme.md#x-ms-externa…
feruilob Dec 4, 2020
ce73bf3
Adds suppression to readme
feruilob Dec 4, 2020
5f43df9
Fix linter error missing description
feruilob Dec 4, 2020
d0d4e71
Merge branch 'dev-resources-Microsoft.Authorization-2020-09-01-dec-ed…
feruilob Dec 4, 2020
c1afdbc
Rolling back the version to fix swagger linter errors
feruilob Dec 9, 2020
e8c70ee
Fixing linter errors for version 2020-03-01 as well
feruilob Dec 9, 2020
08cdace
Remove suppresion because it is no longer needed
feruilob Dec 9, 2020
5273bae
Removing CloudeError definition and adding the reference directly
feruilob Jan 4, 2021
49b2e92
Updating error response
feruilob Jan 4, 2021
2915886
Updating to v2 of error response
feruilob Jan 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion ...sources/resource-manager/Microsoft.Authorization/stable/2020-03-01/policyAssignments.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -579,7 +579,11 @@
"definitions": {
"CloudError": {
"x-ms-external": true,
"$ref": "../../../../../common-types/resource-management/v2/types.json#/definitions/ErrorResponse",
"properties": {
"error": {
"$ref": "../../../../../common-types/resource-management/v1/types.json#/definitions/ErrorResponse"
}
},
"description": "An error response from a policy operation."
},
"PolicyAssignmentProperties": {
Expand Down
6 changes: 5 additions & 1 deletion ...sources/resource-manager/Microsoft.Authorization/stable/2020-03-01/policyDefinitions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -491,7 +491,11 @@
"definitions": {
"CloudError": {
"x-ms-external": true,
"$ref": "../../../../../common-types/resource-management/v2/types.json#/definitions/ErrorResponse",
"properties": {
"error": {
"$ref": "../../../../../common-types/resource-management/v1/types.json#/definitions/ErrorResponse"
}
},
"description": "An error response from a policy operation."
},
"PolicyDefinitionProperties": {
Expand Down
6 changes: 5 additions & 1 deletion ...rces/resource-manager/Microsoft.Authorization/stable/2020-03-01/policySetDefinitions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -506,7 +506,11 @@
"definitions": {
"CloudError": {
"x-ms-external": true,
"$ref": "../../../../../common-types/resource-management/v2/types.json#/definitions/ErrorResponse",
"properties": {
"error": {
"$ref": "../../../../../common-types/resource-management/v1/types.json#/definitions/ErrorResponse"
}
},
"description": "An error response from a policy operation."
},
"PolicySetDefinitionProperties": {
Expand Down
6 changes: 5 additions & 1 deletion ...urces/resource-manager/Microsoft.Authorization/stable/2020-09-01/dataPolicyManifests.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,11 @@
"definitions": {
"CloudError": {
"x-ms-external": true,
"$ref": "../../../../../common-types/resource-management/v2/types.json#/definitions/ErrorResponse",
"properties": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original is right, why did you put the $ref into an "error" object

Copy link
Contributor Author

@feruilob feruilob Dec 7, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because of this comment: #10986 (comment)

I was told it had to be like this example

@colawwj @raych1 could you please clarify which version is the correct one?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is error the property that should refer to "../../../../../common-types/resource-management/v2/types.json#/definitions/ErrorResponse" not the CloudError itself.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@feruilob , please change the $ref to ../../../../../common-types/resource-management/v1/types.json#/definitions/ErrorResponse as this file.
@colawwj , can you please investigate what's the purpose of x-ms-external extension and what's the impact of removing it? Thanks.

Copy link
Contributor Author

@feruilob feruilob Dec 9, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@raych1 done. I also removed a suppression in the README that I had done, but the lintdiff is still failing. Any ideas on why this may be?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@colawwj , do you confirm if your suggestion is the only approach found so far for the fix?

Copy link
Contributor

@colawwj colawwj Dec 14, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@raych1
We have test the approach like $ref to ../../../../../common-types/resource-management/v1/types.json#/definitions/ErrorResponse,but it still reports an error the same as before.
Maybe there are other solutions,but we know that the above method only.
Cc : @qiaozha

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@feruilob , could you take @colawwj's advice for the fix?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright. Doing this for other files in Microsoft.Authorization/stable/2020-09-01 and 2020-03-01 also

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just confirming: it's v2 not v1, right? ../../../../../common-types/resource-management/v2/types.json#/definitions/ErrorResponse

"error": {
"$ref": "../../../../../common-types/resource-management/v1/types.json#/definitions/ErrorResponse"
}
},
"description": "An error response from a policy operation."
},
"DataManifestCustomResourceFunctionDefinition": {
Expand Down
6 changes: 5 additions & 1 deletion ...sources/resource-manager/Microsoft.Authorization/stable/2020-09-01/policyAssignments.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -582,7 +582,11 @@
"definitions": {
"CloudError": {
"x-ms-external": true,
"$ref": "../../../../../common-types/resource-management/v2/types.json#/definitions/ErrorResponse",
"properties": {
"error": {
"$ref": "../../../../../common-types/resource-management/v1/types.json#/definitions/ErrorResponse"
}
},
"description": "An error response from a policy operation."
},
"PolicyAssignmentProperties": {
Expand Down
6 changes: 5 additions & 1 deletion ...sources/resource-manager/Microsoft.Authorization/stable/2020-09-01/policyDefinitions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -491,7 +491,11 @@
"definitions": {
"CloudError": {
"x-ms-external": true,
"$ref": "../../../../../common-types/resource-management/v2/types.json#/definitions/ErrorResponse",
"properties": {
"error": {
"$ref": "../../../../../common-types/resource-management/v1/types.json#/definitions/ErrorResponse"
}
},
"description": "An error response from a policy operation."
},
"PolicyDefinitionProperties": {
Expand Down
6 changes: 5 additions & 1 deletion ...rces/resource-manager/Microsoft.Authorization/stable/2020-09-01/policySetDefinitions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -506,7 +506,11 @@
"definitions": {
"CloudError": {
"x-ms-external": true,
"$ref": "../../../../../common-types/resource-management/v2/types.json#/definitions/ErrorResponse",
"properties": {
"error": {
"$ref": "../../../../../common-types/resource-management/v1/types.json#/definitions/ErrorResponse"
}
},
"description": "An error response from a policy operation."
},
"PolicySetDefinitionProperties": {
Expand Down