Skip to content

[Hub Generated] Review request for Microsoft.Cache to add version stable/2020-06-01 #11882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sspeaks610 wants to merge 1 commit into from
Closed

[Hub Generated] Review request for Microsoft.Cache to add version stable/2020-06-01 #11882

sspeaks610 wants to merge 1 commit into from

Conversation

@sspeaks610
Copy link
Contributor

@sspeaks610 sspeaks610 commented Dec 1, 2020

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
  3. When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
  4. If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No, no need to refresh for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service

  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable version with Breaking Change Validation errors
  • Updating API(s) in preview over 1 year

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Dec 1, 2020 •
edited
Loading

Swagger Validation Report

️❌BreakingChange: 7 Errors, 0 Warnings failed [Detail]

Rule Message
❌ 1027 - DefaultValueChanged The new version has a different default value than the previous one.
New: Microsoft.Cache/stable/2020-06-01/redis.json#L1861:9
Old: Microsoft.Cache/stable/2020-06-01/redis.json#L1861:9
❌ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'error' renamed or removed?
New: Microsoft.Cache/stable/2020-06-01/redis.json#L2464:7
Old: common-types/resource-management/v2/types.json#L312:7
❌ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'actionsRequired' renamed or removed?
New: Microsoft.Cache/stable/2020-06-01/redis.json#L2715:7
Old: common-types/resource-management/v1/privatelinks.json#L55:7
❌ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'error' renamed or removed?
New: common-types/resource-management/v2/types.json#L275:7
Old: common-types/resource-management/v2/types.json#L312:7
❌ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'error' renamed or removed?
New: common-types/resource-management/v2/types.json#L275:7
Old: common-types/resource-management/v2/types.json#L312:7
❌ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'actionsRequired' renamed or removed?
New: Microsoft.Cache/stable/2020-06-01/redis.json#L2715:7
Old: common-types/resource-management/v1/privatelinks.json#L55:7
❌ 1041 - AddedPropertyInResponse The new version has a new property 'actionRequired' in response that was not found in the old version.
New: Microsoft.Cache/stable/2020-06-01/redis.json#L2715:7
Old: common-types/resource-management/v1/privatelinks.json#L55:7
️❌LintDiff: 3 Errors, 0 Warnings failed [Detail]

Rule Message
❌ R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
New: Microsoft.Cache/stable/2020-06-01/redis.json#L635
❌ R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
New: Microsoft.Cache/stable/2020-06-01/redis.json#L1546
❌ R4007 - DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
New: Microsoft.Cache/stable/2020-06-01/redis.json#L1602
️️✔️Avocado succeeded [Detail] [Expand] 
Validation passes for Avocado.
️❌ModelValidation: 2 Errors, 0 Warnings failed [Detail]
Rule Message
❌ OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: actionRequired
Url: common-types/resource-management/v1/privatelinks.json#L54
JsonUrl: stable/2020-06-01/examples/RedisCacheGet.json
❌ OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: actionRequired
Url: common-types/resource-management/v1/privatelinks.json#L54
JsonUrl: stable/2020-06-01/examples/RedisCacheListByResourceGroup.json
️️✔️SemanticValidation succeeded [Detail] [Expand] 
Validation passes for SemanticValidation.
️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand] 
There are no breaking changes.
️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand] 
There are no breaking changes.
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Dec 1, 2020 •
edited
Loading

Swagger Generation Artifacts

️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand] 
 Please click here to preview with your @microsoft account.
️️✔️ azure-sdk-for-python succeeded [Detail] [Expand] 
- Breaking Change Detected
  • ️✔️Succeeded [Logs] Generate from 2ef75bca822756b0a2f71eea6c4984dd2f7c2f9e. SDK Automation 14.0.0 
    warn	Skip initScript due to not configured
command	npx n 12
command	python3 -m venv venv
command	pip install setuptools wheel
command	pip install pathlib jinja2 msrestazure
command	autorest --version=V2 [email protected]/autorest.python@~4.0.71 --python --python-mode=update --multiapi --keep-version-file --no-async --python-sdks-folder=/home/vsts/work/1/s/w/azure-sdk-for-python/sdk ../azure-rest-api-specs/specification/redis/resource-manager/readme.md
  • ️✔️azure-mgmt-redis [View full logs]  [Preview SDK Changes] Breaking Change Detected
    cmderr	[buildPackage] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
cmderr	[buildPackage]   warnings.warn(msg)
cmderr	[buildPackage] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
cmderr	[buildPackage]   warnings.warn(msg)
cmderr	[changelogSetup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
cmderr	[changelogSetup] Cannot uninstall requirement azure-nspkg, not installed
cmderr	[changelogSetup] Command '['/home/vsts/work/1/s/w/azure-sdk-for-python_tmp/venv/bin/python', '-m', 'pip', 'uninstall', '-y', 'azure-nspkg']' returned non-zero exit status 1.
cmderr	[changelogReport] INFO:__main__:Looking for Autorest generated package in azure.mgmt.redis
cmderr	[changelogReport] INFO:__main__:Found azure.mgmt.redis
cmderr	[changelogReport] INFO:__main__:Working on azure.mgmt.redis
cmderr	[changelogReport] INFO:__main__:Report written to sdk/redis/azure-mgmt-redis/code_reports/latest/report.json
cmderr	[changelogReportLatest] INFO:__main__:Download versions of azure-mgmt-redis on PyPI
cmderr	[changelogReportLatest] INFO:__main__:Got ['0.30.0a1', '0.30.0rc1', '0.30.0rc2', '0.30.0rc3', '0.30.0rc4', '0.30.0rc5', '1.0.0', '2.0.0', '3.0.0', '4.0.0', '4.1.0', '4.1.1', '5.0.0', '6.0.0', '7.0.0rc1', '7.0.0rc2', '12.0.0b1', '12.0.0']
cmderr	[changelogReportLatest] INFO:__main__:Only keep last PyPI version
cmderr	[changelogReportLatest] INFO:__main__:Installing version 7.0.0rc2 of azure-mgmt-redis in a venv
cmderr	[changelogReportLatest] INFO:__main__:Looking for Autorest generated package in azure.mgmt.redis
cmderr	[changelogReportLatest] INFO:__main__:Found azure.mgmt.redis
cmderr	[changelogReportLatest] INFO:__main__:Working on azure.mgmt.redis
cmderr	[changelogReportLatest] INFO:__main__:Report written to sdk/redis/azure-mgmt-redis/code_reports/7.0.0rc2/report.json
cmdout	[Changelog] Size of delta 42.776% size of original (original: 28771 chars, delta: 12307 chars)
cmdout	[Changelog] **Features**
cmdout	[Changelog]   - Model RedisUpdateParameters has a new parameter public_network_access
cmdout	[Changelog]   - Model RedisPatchSchedule has a new parameter location
cmdout	[Changelog]   - Model RedisResource has a new parameter public_network_access
cmdout	[Changelog]   - Model RedisResource has a new parameter private_endpoint_connections
cmdout	[Changelog]   - Model RedisCreateParameters has a new parameter public_network_access
cmdout	[Changelog]   - Added operation RedisOperations.list_by_subscription
cmdout	[Changelog]   - Added operation FirewallRulesOperations.list
cmdout	[Changelog]   - Added operation group PrivateLinkResourcesOperations
cmdout	[Changelog]   - Added operation group PrivateEndpointConnectionsOperations
cmdout	[Changelog] **Breaking changes**
cmdout	[Changelog]   - Removed operation RedisOperations.list
cmdout	[Changelog]   - Removed operation FirewallRulesOperations.list_by_redis_resource
warn	Breaking change found in changelog
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs] Generate from 2ef75bca822756b0a2f71eea6c4984dd2f7c2f9e. SDK Automation 14.0.0 
    warn	Skip initScript due to not configured
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --typescript-sdks-folder=/home/vsts/work/1/s/w/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/redis/resource-manager/readme.md
  • ️✔️@azure/arm-rediscache [View full logs]  [Preview SDK Changes] 
    cmderr	[npmPack] loaded rollup.config.js with warnings
cmderr	[npmPack] (!) Unused external imports
cmderr	[npmPack] default imported from external module 'rollup' but never used
cmderr	[npmPack] ./esm/redisManagementClient.js → ./dist/arm-rediscache.js...
cmderr	[npmPack] created ./dist/arm-rediscache.js in 342ms
️⚠️ azure-sdk-for-net warning [Detail]
  • ⚠️Warning [Logs] Generate from 2ef75bca822756b0a2f71eea6c4984dd2f7c2f9e. SDK Automation 14.0.0 
    warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-5.0
command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --csharp-sdks-folder=/home/vsts/work/1/s/w/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/redis/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
  • ️✔️Microsoft.Azure.Management.Redis [View full logs]  [Preview SDK Changes]
️❌ azure-sdk-for-go failed [Detail]
  • ❌Failed [Logs] Generate from 2ef75bca822756b0a2f71eea6c4984dd2f7c2f9e. SDK Automation 14.0.0 
    command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
cmderr	[main.go] [ERROR] generation meets an error: cannot generate: stat services/preview/redis/mgmt/2019-07-01-preview/redis/CHANGELOG.md: no such file or directory
error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go]: go run ./tools/generator/main.go
warn	Skip package processing as generation is failed
️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs] Generate from 2ef75bca822756b0a2f71eea6c4984dd2f7c2f9e. Schema Automation 14.0.0 
    warn	Skip initScript due to not configured
command	npx n 12
command	autorest --use=@autorest/[email protected] --version=3.0.6320 --azureresourceschema --multiapi --title=none --pass-thru:subset-reducer --azureresourceschema-folder=/home/vsts/work/1/s/w/azure-resource-manager-schemas/azure-resource-manager-schemas ../../azure-rest-api-specs/specification/redis/resource-manager/readme.md
  • cmderr	[resource-manager] node-pre-gyp
cmderr	[resource-manager] WARN Using request for node-pre-gyp https download
cmderr	[resource-manager]  [email protected] No repository field.
cmderr	[resource-manager] WARN optional SKIPPING OPTIONAL DEPENDENCY: [email protected] (node_modules/fsevents):
cmderr	[resource-manager] npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for [email protected]: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
️⚠️ azure-sdk-for-java warning [Detail]
Posted by Swagger Pipeline | How to fix these errors?

@openapi-workflow-bot
Copy link

openapi-workflow-bot bot commented Dec 1, 2020

Hi @sspeaks610, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ma/swaggerfeedback.

This was referenced Dec 1, 2020
Draft
Draft
This was referenced Dec 1, 2020
Draft
Draft
Draft
Draft
@ghost
Copy link

ghost commented Dec 22, 2020

Hi, sspeaks610. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

@ghost ghost added the no-recent-activity label Dec 22, 2020
@ghost ghost closed this Mar 22, 2021
@ghost
Copy link

ghost commented Mar 22, 2021

Hi, @sspeaks610. The PR will be closed since the PR has no update for 28 days. If you still need the PR review to proceed, please reopen it and @ mention PR assignee .

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TimLovellSmith TimLovellSmith Awaiting requested review from TimLovellSmith TimLovellSmith will be requested when the pull request is marked ready for review TimLovellSmith is a code owner

Assignees

No one assigned

Labels

CI-BreakingChange-Python

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@sspeaks610