Skip to content

Conversation

@btasdoven
Copy link
Contributor

@btasdoven btasdoven commented May 2, 2017

This change adds Failover Groups back to the public swagger list for Microsoft.Sql since I am in the process of adding .NET SDK tests for Failover Groups, and changes the type of failoverGroupId property in Database resource from Guid to string since this property represents the resource identifier of the failover group that contains the database.

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@sergey-shandar sergey-shandar merged commit 885fb5b into Azure:master May 2, 2017
@btasdoven
Copy link
Contributor Author

@jaredmoo, FYI, I sent this out as I am almost done with .NET SDK tests. I will follow up with a pull request for .NET SDK tests.

@AutorestCI
Copy link

@jaredmoo
Copy link
Contributor

jaredmoo commented May 2, 2017

Already merged but looks great anyway :)

@AutorestCI
Copy link

@AutorestCI
Copy link

No modification for NodeJS

mccleanp pushed a commit that referenced this pull request Mar 23, 2022
Adding swagger for Microsoft.Datadog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants