Review request for Microsoft.Billing to add version preview/2020-11-01-privatepreview by asarkar84 · Pull Request #11679 · Azure/azure-rest-api-specs

asarkar84 · 2020-11-14T02:29:15Z

Review request for Microsoft.Billing to add version preview/2020-11-01-privatepreview

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No, no need to refresh for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of “no breaking changes
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
- Adding a new API version
- Adding a new service
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable version with Breaking Change Validation errors
Updating API(s) in preview over 1 year

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

…1-privatepreview Review request for Microsoft.Billing to add version preview/2020-11-01-privatepreview

openapi-pipeline-app · 2020-11-14T02:29:19Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️⚠️LintDiff: 1 Warnings warning [Detail]

Linted configuring files (Based on source branch, openapi-validator v1.6.0 , classic-openapi-validator v1.1.5 )
- billing/resource-manager/readme.md tag:package-preview-2020-11
Linted configuring files (Based on target branch, openapi-validator v1.6.0 , classic-openapi-validator v1.1.5 )
- billing/resource-manager/readme.md tag:default

Rule	Message
⚠️ R4021 - DescriptionAndTitleMissing	'ErrorSubDetails' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. New: Microsoft.Billing/preview/2018-03-01-preview/billingV2.json#L343

️⚠️Avocado: 1 Warnings warning [Detail]

Rule	Message
⚠️ MULTIPLE_API_VERSION	The default tag contains multiple API versions swaggers. readme: specification/billing/resource-manager/readme.md tag: specification/billing/resource-manager/readme.md#tag-package-2020-05

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2020-11-14T02:29:20Z

Swagger Generation Artifacts

️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️️✔️ azure-sdk-for-python succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from 5e585e57fff7e52763df3b15ddeecb7ce778e421. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	npx n 12
command	python3 -m venv venv
command	pip install --upgrade setuptools wheel pip
command	pip install pathlib jinja2 msrestazure
command	autorest --version=V2 --use=@microsoft.azure/autorest.python@~4.0.71 --python --python-mode=update --multiapi --keep-version-file --no-async --python-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-python/sdk ../azure-rest-api-specs/specification/billing/resource-manager/readme.md

️✔️azure-mgmt-billing [View full logs] [Preview SDK Changes] Breaking Change Detected

cmderr	[buildConf] INFO:packaging_tools:Building template azure-mgmt-billing
cmderr	[buildConf] INFO:packaging_tools.conf:Skipping default conf since the file exists
cmderr	[buildConf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
cmderr	[buildConf] INFO:packaging_tools:Template done azure-mgmt-billing
cmderr	[changelogSetup] WARNING: Skipping azure-nspkg as it is not installed.
cmderr	[changelogReport] INFO:__main__:Looking for Autorest generated package in azure.mgmt.billing
cmderr	[changelogReport] INFO:__main__:Found azure.mgmt.billing
cmderr	[changelogReport] INFO:__main__:Working on azure.mgmt.billing
cmderr	[changelogReport] INFO:__main__:Report written to sdk/billing/azure-mgmt-billing/code_reports/latest/report.json
cmderr	[changelogReportLatest] INFO:__main__:Download versions of azure-mgmt-billing on PyPI
cmderr	[changelogReportLatest] INFO:__main__:Got ['0.1.0', '0.2.0', '1.0.0', '6.0.0b1']
cmderr	[changelogReportLatest] INFO:__main__:Only keep last PyPI version
cmderr	[changelogReportLatest] INFO:__main__:Installing version 1.0.0 of azure-mgmt-billing in a venv
cmderr	[changelogReportLatest] Cache entry deserialization failed, entry ignored
cmderr	[changelogReportLatest] INFO:__main__:Looking for Autorest generated package in azure.mgmt.billing
cmderr	[changelogReportLatest] INFO:__main__:Found azure.mgmt.billing
cmderr	[changelogReportLatest] INFO:__main__:Working on azure.mgmt.billing
cmderr	[changelogReportLatest] INFO:__main__:Report written to sdk/billing/azure-mgmt-billing/code_reports/1.0.0/report.json
cmdout	[Changelog] Size of delta 1.137% size of original (original: 73885 chars, delta: 840 chars)
cmdout	[Changelog] **Features**
cmdout	[Changelog]   - Added operation InvoicesOperations.download_multiple_billing_subscription_invoices
cmdout	[Changelog]   - Added operation InvoicesOperations.download_multiple_billing_profile_invoices
cmdout	[Changelog] **Breaking changes**
cmdout	[Changelog]   - Removed operation InvoicesOperations.download_multiple_billing_subscription_invoice
cmdout	[Changelog]   - Removed operation InvoicesOperations.download_multiple_modern_invoice
warn	Breaking change found in changelog

️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from 5e585e57fff7e52763df3b15ddeecb7ce778e421. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-5.0
command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/billing/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.Billing [View full logs] [Preview SDK Changes]
- Microsoft.Azure.Management.Billing.4.1.0.nupkg
- Microsoft.Azure.Management.Billing.4.1.0.snupkg

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs] Generate from 5e585e57fff7e52763df3b15ddeecb7ce778e421. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] 2020-12-23 01:19:58 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-billing"
cmderr	[generate.py] 2020-12-23 01:19:58 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
cmderr	[generate.py] 2020-12-23 01:19:58 INFO autorest --version=3.0.6350 --use=@autorest/java@4.0.6 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/billing/azure-resourcemanager-billing --java.namespace=com.azure.resourcemanager.billing  --package-version=1.0.0-beta.1 --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --pipeline.modelerfour.flatten-payloads=false --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/billing/resource-manager/readme.md
cmderr	[generate.py] 2020-12-23 01:20:48 INFO [CI][Success] Write to ci.yml
cmderr	[generate.py] 2020-12-23 01:20:48 INFO [POM][Process] dealing with pom.xml
cmderr	[generate.py] 2020-12-23 01:20:48 INFO [POM][Success] Write to pom.xml
cmderr	[generate.py] 2020-12-23 01:20:48 INFO [POM][Process] dealing with root pom
cmderr	[generate.py] 2020-12-23 01:20:48 INFO [POM][Success] Write to root pom
cmderr	[generate.py] WARNING: An illegal reflective access operation has occurred
cmderr	[generate.py] WARNING: Illegal reflective access by org.codehaus.groovy.reflection.ReflectionUtils (file:/home/vsts/.m2/repository/org/codehaus/groovy/groovy/3.0.0-beta-2/groovy-3.0.0-beta-2-indy.jar) to method java.util.Collections$UnmodifiableCollection.toString()
cmderr	[generate.py] WARNING: Please consider reporting this to the maintainers of org.codehaus.groovy.reflection.ReflectionUtils
cmderr	[generate.py] WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
cmderr	[generate.py] WARNING: All illegal access operations will be denied in a future release

️✔️azure-resourcemanager-billing [View full logs] [Preview SDK Changes]

cmderr	[Inst] 2020-12-23 01:23:13 DEBUG Got artifact_id: azure-resourcemanager-billing
cmderr	[Inst] 2020-12-23 01:23:13 DEBUG Got artifact: pom.xml
cmderr	[Inst] 2020-12-23 01:23:13 DEBUG Got artifact: azure-resourcemanager-billing-1.0.0-beta.1-javadoc.jar
cmderr	[Inst] 2020-12-23 01:23:13 DEBUG Got artifact: azure-resourcemanager-billing-1.0.0-beta.1-sources.jar
cmderr	[Inst] 2020-12-23 01:23:13 DEBUG Got artifact: azure-resourcemanager-billing-1.0.0-beta.1.jar
cmderr	[Inst] 2020-12-23 01:23:13 DEBUG Match jar package: azure-resourcemanager-billing-1.0.0-beta.1.jar
cmderr	[Inst] 2020-12-23 01:23:13 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/11679/azure-sdk-for-java/azure-resourcemanager-billing/azure-resourcemanager-billing-1.0.0-beta.1.jar\" -o azure-resourcemanager-billing-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-billing -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-billing-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true
```"}

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from 5e585e57fff7e52763df3b15ddeecb7ce778e421. SDK Automation 14.0.0

command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️preview/billing/mgmt/2020-05-01-preview/billing [View full logs] [Preview SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️preview/billing/mgmt/2018-11-01-preview/billing [View full logs] [Preview SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️preview/billing/mgmt/2018-03-01-preview/billing [View full logs] [Preview SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️preview/billing/mgmt/2017-04-24-preview/billing [View full logs] [Preview SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️preview/billing/mgmt/2017-02-27-preview/billing [View full logs] [Preview SDK Changes]
```
info	[Changelog] No exported changes
```

️🔄 azure-cli-extensions inProgress [Detail]

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from 5e585e57fff7e52763df3b15ddeecb7ce778e421. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.4.4 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/billing/resource-manager/readme.md

️✔️@azure/arm-billing [View full logs] [Preview SDK Changes]

azure-arm-billing-3.0.0.tgz

cmderr	[npmPack] loaded rollup.config.js with warnings
cmderr	[npmPack] (!) Unused external imports
cmderr	[npmPack] default imported from external module 'rollup' but never used
cmderr	[npmPack] ./esm/billingManagementClient.js → ./dist/arm-billing.js...
cmderr	[npmPack] created ./dist/arm-billing.js in 696ms

️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from 5e585e57fff7e52763df3b15ddeecb7ce778e421. Schema Automation 14.0.0

warn	Skip initScript due to not configured
command	npx n 12
command	autorest --use=@autorest/azureresourceschema@3.0.92 --version=3.0.6320 --azureresourceschema --multiapi --title=none --pass-thru:subset-reducer --azureresourceschema-folder=/home/vsts/work/1/s/azure-resource-manager-schemas/azure-resource-manager-schemas ../../azure-rest-api-specs/specification/billing/resource-manager/readme.md

️✔️billing [View full logs] [Preview Schema Changes]

cmderr	[resource-manager] node-pre-gyp
cmderr	[resource-manager] WARN Using request for node-pre-gyp https download
cmderr	[resource-manager]  WARN template-schema-validation-tools@1.0.0 No repository field.
cmderr	[resource-manager] WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@2.1.3 (node_modules/fsevents):
cmderr	[resource-manager] npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@2.1.3: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2020-11-14T02:29:44Z

Hi, @asarkar84 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

asarkar84 · 2020-11-14T02:33:23Z

@raych1 We already got ARM approval for this PR on the private repo. Please refer this PR:
https://github.com/Azure/azure-rest-api-specs-pr/pull/2352

openapi-workflow-bot · 2020-11-16T03:40:06Z

Hi, @asarkar84 your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). cc @raych1

raych1 · 2020-11-16T03:41:09Z

This is the origin PR reviewed in private repository.

...lling/resource-manager/Microsoft.Billing/preview/2020-11-01-privatepreview/transactions.json

majastrz · 2020-11-25T04:44:11Z

Confirmed by manual diffing that private approved swagger is identical to this one.

majastrz

Signed off from ARM side.

raych1 · 2020-11-27T01:47:06Z

Confirmed by manual diffing that private approved swagger is identical to this one.

Thanks @majastrz! FYI - we will have the feature of publishing private PR to public repo release soon when we don't bother ARM
to do the same review. //CC: @zhenglaizhang.

ghost · 2020-12-22T15:03:09Z

Hi, asarkar84. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

raych1 · 2020-12-23T01:15:25Z

/azp run

azure-pipelines · 2020-12-23T01:15:40Z

Azure Pipelines successfully started running 2 pipeline(s).

raych1 · 2020-12-23T01:16:06Z

@ArcturusZhang , can you confirm the go breaking change? Thanks.

ArcturusZhang · 2020-12-23T05:44:14Z

@raych1 no changes now for go SDK

raych1 · 2020-12-24T02:13:39Z

@asarkar84 , please let me know if this PR is ready to merge.

ghost · 2021-01-10T16:00:45Z

Hi, @asarkar84. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

raych1 · 2021-02-03T06:18:23Z

@asarkar84 , I close this PR due to no response and please feel free to re-open this PR.

Review request for Microsoft.Billing to add version preview/2020-11-0…

5ce2b4d

…1-privatepreview Review request for Microsoft.Billing to add version preview/2020-11-01-privatepreview

asarkar84 requested a review from wilcobmsft as a code owner November 14, 2020 02:29

openapi-assignment-bot bot assigned raych1 Nov 14, 2020

openapi-sdkautomation bot mentioned this pull request Nov 14, 2020

[AutoPR @azure/arm-billing] Review request for Microsoft.Billing to add version preview/2020-11-01-privatepreview AzureSDKAutomation/azure-sdk-for-js#2580

Draft

openapi-pipeline-app bot added the CI-BreakingChange-Python label Nov 14, 2020

openapi-sdkautomation bot mentioned this pull request Nov 14, 2020

[AutoPR billing] Review request for Microsoft.Billing to add version preview/2020-11-01-privatepreview AzureSDKAutomation/azure-resource-manager-schemas#835

Draft

openapi-pipeline-app bot added the CI-BreakingChange-Go label Nov 14, 2020

openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Nov 16, 2020

raych1 reviewed Nov 25, 2020

View reviewed changes

...lling/resource-manager/Microsoft.Billing/preview/2020-11-01-privatepreview/transactions.json Show resolved Hide resolved

majastrz added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Nov 25, 2020

majastrz approved these changes Nov 25, 2020

View reviewed changes

raych1 added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Nov 27, 2020

ghost added the no-recent-activity label Dec 22, 2020

openapi-pipeline-app bot removed the CI-BreakingChange-Go label Dec 23, 2020

ghost removed the no-recent-activity label Dec 23, 2020

openapi-sdkautomation bot mentioned this pull request Dec 23, 2020

[AutoPR azure-resourcemanager-billing] Review request for Microsoft.Billing to add version preview/2020-11-01-privatepreview AzureSDKAutomation/azure-sdk-for-java#7055

Draft

ghost added the no-recent-activity label Jan 10, 2021

raych1 closed this Feb 3, 2021

Comments

Conversation

asarkar84 commented Nov 14, 2020 • edited by raych1 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

Uh oh!

openapi-pipeline-app bot commented Nov 14, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Swagger Validation Report

Uh oh!

openapi-pipeline-app bot commented Nov 14, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Swagger Generation Artifacts

Uh oh!

openapi-workflow-bot bot commented Nov 14, 2020

Uh oh!

asarkar84 commented Nov 14, 2020

Uh oh!

openapi-workflow-bot bot commented Nov 16, 2020

Uh oh!

raych1 commented Nov 16, 2020

Uh oh!

Uh oh!

majastrz commented Nov 25, 2020

Uh oh!

majastrz left a comment

Choose a reason for hiding this comment

Uh oh!

raych1 commented Nov 27, 2020

Uh oh!

ghost commented Dec 22, 2020

Uh oh!

raych1 commented Dec 23, 2020

Uh oh!

azure-pipelines bot commented Dec 23, 2020

Uh oh!

raych1 commented Dec 23, 2020

Uh oh!

ArcturusZhang commented Dec 23, 2020

Uh oh!

raych1 commented Dec 24, 2020

Uh oh!

ghost commented Jan 10, 2021

Uh oh!

raych1 commented Feb 3, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

asarkar84 commented Nov 14, 2020 •

edited by raych1

Loading

openapi-pipeline-app bot commented Nov 14, 2020 •

edited

Loading

openapi-pipeline-app bot commented Nov 14, 2020 •

edited

Loading